Comments (9)
Are you sure this is an issue with the angular modal service and not simply an issue with the bootstrap modal?
from angular-modal-service.
I went to the bootstrap modal demo and did not see the same problem, theirs is directing the tab keys into the modal
Your demo page has the issue of the tab key cyclng thru items on the page
AngularUI has the same problem, the tab key cycles thru items on the page
Maybe Angular is 'helping' ?
from angular-modal-service.
Possibly, although it might be more that the bootstrap documentation page
has a little bit of JavaScript to stop it from happening
On 4 March 2015 at 15:03, allen joslin [email protected] wrote:
I went to the bootstrap modal demo and did not see the same problem,
theirs is directing the tab keys into the modalYour demo page has the issue of the tab key cyclng thru items on the page
AngularUI has the same problem, the tab key cycles thru items on the page
Maybe Angular is 'helping' ?
—
Reply to this email directly or view it on GitHub
#45 (comment)
.
from angular-modal-service.
I just ran thru the 1st 3 pages of google results on: bootstrap modal
they all have the same problem except for this one:
http://codepen.io/SitePoint/pen/KkHyw
I sure hope that you can figure something out and add it to your code, I'm behind the 8-ball on a big project and your modals are otherwise working wonderfully for me...
If I can be of any help let me know!
from angular-modal-service.
Just make sure that when you tab past the last focusable element you manually suppress the event and go to the first focusable element in the modal:
http://jsfiddle.net/dwmkerr/5botatz3/
You can probably event generalise to find the last focusable element in a container via a selector.
from angular-modal-service.
I just went over to the AngularUI project and they have been trying to find the best solution for a while now. [https://github.com/angular-ui/bootstrap/issues/738]
They point out: Modal.prototype.enforceFocus() in Bootstrap 3 (which I found being called inside the Modal.show() ) and claim that it does the trick...
Now why is that not working for everyone who uses Modal ?
from angular-modal-service.
any news?
from angular-modal-service.
This was also a problem with Angular UI Bootstrap's modal for a while (angular-ui/bootstrap#738) but some contributers eventually fixed it. It does not appear to be an easy task. I will take stab at it, because I need it for a custom modal that I am making. If I get it working I'll submit a PR.
from angular-modal-service.
This is a challenge for many users, I am collecting all of the open issues related to this and closing them in favour of #209
from angular-modal-service.
Related Issues (20)
- ModalService.closeModals() - Dont close other modals HOT 2
- modal dismiss HOT 4
- Memory leak HOT 2
- modal is not showing up but code js is ok
- Modal not getting closed HOT 3
- Modal service not working with bootstrap 4 beta (popper.js issue)
- Request: Upgrade to Angular 2 (and higher) HOT 2
- Browser support for angular-modal-service HOT 2
- doing operations on modal close HOT 1
- An in-range update of karma is breaking the build 🚨 HOT 15
- Close callback being called multiple times when location changes
- null is not an object (evaluating 'r.resolve')
- request: make it compatible with AngularJS 1.7 HOT 1
- Jquery datepicker not open issue in modal HOT 1
- An in-range update of webpack is breaking the build 🚨 HOT 21
- Latest version capture any angular error through the modal service
- Component bindings are bound too late HOT 3
- Can't overlay modals HOT 1
- An in-range update of uglify-js is breaking the build 🚨 HOT 22
- Close in a single controller?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-modal-service.