updateModal needed for transitions about angular-modal-service HOT 2 CLOSED

Had a similar concern but my thought was that it might be convenient to pass the modal in the catch callback, e.g.

ModalService.showModal({
    // pretend this template has a conditional div that displays any errors
    templateUrl: "some/template.html",
    // pretend this controller has an 'errorMessages' array
    controller: "SomeController"  
}).then(function(modal){
    // called on success...
}).catch(function(error, modal){
    modal.controller.errorMessages.push("Oh dear, this happened: " + error);
})

In lieu of such a feature, my approach was to pass an errorMessages closure into the showModal() 'inputs' option, and then update it in the catch callback, but I haven't confirmed whether that would work.

from angular-modal-service.

@robhicks @nobodyman the catch function should only be hit when something mechanistic fails, which means that in all likelihood we cannot expect the modal to be in a state where we can update it with error information. I would probably aim for handling this in the application like so:

ModalService.showModal({
templateUrl: "some/template.html",
controller: "SomeController"
}).then(function(modal) {
// only called on success...
}).catch(function(error) {
AlertService.showError("Something went wrong");
});

the AlertService would be defined by the app, it could show an alert, a modal, log or whatever. But assuming that we can actually somehow interact with the modal is probably wrong because we know that we have failed to create it. Thoughts?

from angular-modal-service.