durancristhian / meetup-randomizer Goto Github PK

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml
• Replaced the old Node.js version in your .nvmrc with the new one
• The new Node.js version is in-range for the engines in 1 of your package.json files, so that was left alone

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

Version 3.2.1 of jquery just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As jquery is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 0.13.3 of husky just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As husky is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

When attempting to get a random attendee from an event that doesn't have any confirmed non-hosts attending, meetup-randomizer errors out with the following:

There was an error when we tried to show the winner's image
Error description: Cannot read property 'photoURL' of undefined
undefined

When attempting to access a private Meetup group, meetup-randomizer currently just errors out with the following:

TypeError: membersList.filter is not a function
    at Promise (/private/tmp/foo/node_modules/meetup-randomizer/lib/program.js:16:49)
    at excludeHosts (/private/tmp/foo/node_modules/meetup-randomizer/lib/program.js:15:10)
    at process._tickCallback (internal/process/next_tick.js:109:7)

The Meetup API responds with the following whenever an attempt to access information is made against a private group (group details omitted):

{
  "errors": [
    {
      "code": "privacy_error",
      "message": "This content is available only to members",
      "info": {
        "group": {
          "id": 00000,
          "urlname": "xxxxx",
          "name": "xxxxx",
          "who": "xxxxx",
          "members": 000,
          "join_mode": "approval",
          "group_photo": {
            "id": 0000000,
            "highres_link": "https://secure.meetupstatic.com/photos/event/...",
            "photo_link": "https://secure.meetupstatic.com/photos/event/...",
            "thumb_link": "https://secure.meetupstatic.com/photos/event/...",
            "type": "event",
            "base_url": "https://secure.meetupstatic.com"
          }
        }
      }
    }
  ]
}

The use of fetch would reduce one dependency on browser environments:
https://github.com/matthew-andrews/isomorphic-fetch

Hey @a0viedo

You told me you'd like to have a "blacklist" feature in the module and I started to think a bit about it.

I'd like to know your opinion about how to do it considering that:

• we can run the tool as a CLI or as a module: we could ask for a file with the list but it's not the best solution considering the "portability" (ability to use the module at client-side implementations).
• we need to provide the right information to perform the "filter". Meetup_id would be great but I consider annoying the fact that we need to look for it first. We can implement the filter with another property, like the name, but we have to remember the issue about unauthenticated requests and, also, that some people may have "asdasd" as username, turning the feature a little bit "odd" to use.

What are your thoughts?

PS: Remember that, at the moment, we're performing 2 steps of filtering:

• hosts
• non-confirmed members

The Node version in the engines stanza of package.json is set to "6". This prevents yarn from adding meetup-randomizer as a dependency when running in Node 7. Would it be possible to change it to ">= 6" or is it truly restricted to 6.x? (I tested it briefly on 7.5.0 and it behaved as expected, but my testing was by no means extensive.)

Here is the yarn output, for reference:

error [email protected]: The engine "node" is incompatible with this module. Expected version "6".
error Found incompatible module

Thanks.