duncan3dc / cache Goto Github PK

I've noticed that the FilesystemPool example in the readme is incorrect:

<?php

$cache = new \duncan3dc\Cache\FilesystemPool;

There is no default for the expected $path parameter of the constructor, so it looks like a path needs to be provided, unless there is some magic behind mkdir() when passing in an undefined variable that I don't know about. 😄

I would propose either updating the example so it shows the correct usage or changing FilesystemPool so it uses an appropriate default (a subdirectory of the system temp directory?) if no path is provided.