duboviy / dist Goto Github PK

Hi there Duboviy

I just realized the M_PI is actually binding to the #include made within dist.c
This is a tight coupling of the dist.h with the dist.c
I feel, I shall include the math header inside the dist.h instead.

Hey Duboviy,

I find your projects awesome !
Would like to participate a bit.
Why using those magic numbers here ? Seems to me that we can make that code more generic right ?

Hi Duboviy,

Amazing work here.
I have one question though... wouldn't be more interesting to use programmation by contract and protect the function in case the given pointers aren't valid ?
I mean, using something like

assert(self != NULL && args != NULL);

Could you please consider to drop python 2 support (and six usage).