dual-life / autodie Goto Github PK

$ perl -Mautodie -E 'stat("/foobar"); say $!; say "alive"'
No such file or directory
alive

kill(0, $pid) is often used to check if a process exists and can be signaled.  The current version of autodie (2.19) dies if $pid doesn't exist or can't be signaled by the current user.  When the signal number is 0, autodie should not die.

On Tue Jun 18 10:54:44 2013, JSIRACUSA wrote:
> kill(0, $pid) is often used to check if a process exists and can be
> signaled.  The current version of autodie (2.19) dies if $pid doesn't
> exist or can't be signaled by the current user.  When the signal
> number is 0, autodie should not die.

For reference: This is (now?) also filed on github as issue #47[1]

~Niels

[1] https://github.com/pjf/autodie/issues/47

On Tue Oct 07 11:12:11 2014, [email protected] wrote:

> For reference: This is (now?) also filed on github as issue #47[1]


Still happening nearly 5 years after this announcement.  Will the fix be rolled out any time soon?

njh@microcenter:/tmp$ cat autodie 
#!/usr/bin/env perl

use strict;
use warnings;
use autodie qw(:all);

if(kill(0, 10000)) {
	print "there\n";
}

print "done\n";
njh@microcenter:/tmp$ ./autodie 
Can't kill('0', '10000'): No such process at ./autodie line 7
njh@microcenter:/tmp$ 

$ cpanm -v autodie
cpanm (App::cpanminus) 1.6922 on perl 5.016003 built for x86_64-linux-thread-multi
Work directory is /root/.cpanm/work/1493999664.44
You have make /usr/bin/make
You have LWP 6.05
You have /usr/bin/tar: tar (GNU tar) 1.26
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by John Gilmore and Jay Fenlason.
You have /usr/bin/unzip
Searching autodie on cpanmetadb ...
--> Working on autodie
Fetching http://www.cpan.org/authors/id/P/PJ/PJF/autodie-2.29.tar.gz ... OK
Unpacking autodie-2.29.tar.gz
autodie-2.29
autodie-2.29/AUTHORS
autodie-2.29/Changes
autodie-2.29/t
autodie-2.29/t/pod.t
autodie-2.29/LICENSE
autodie-2.29/dist.ini
autodie-2.29/t/args.t
autodie-2.29/t/exec.t
autodie-2.29/t/fork.t
autodie-2.29/t/kill.t
autodie-2.29/t/open.t
autodie-2.29/t/recv.t
autodie-2.29/t/skip.t
autodie-2.29/t/read.t
autodie-2.29/META.yml
autodie-2.29/MANIFEST
autodie-2.29/cpanfile
autodie-2.29/META.json
autodie-2.29/README.md
autodie-2.29/t/Fatal.t
autodie-2.29/t/chown.t
autodie-2.29/t/flock.t
autodie-2.29/t/hints.t
autodie-2.29/t/lex58.t
autodie-2.29/t/utime.t
autodie-2.29/t/chmod.t
autodie-2.29/t/mkdir.t
autodie-2.29/t/caller.t
autodie-2.29/t/critic.t
autodie-2.29/t/fileno.t
autodie-2.29/t/lethal.t
autodie-2.29/t/repeat.t
autodie-2.29/t/socket.t
autodie-2.29/t/touch_me
autodie-2.29/t/unlink.t
autodie-2.29/t/system.t
autodie-2.29/t/00-load.t
autodie-2.29/t/autodie.t
autodie-2.29/t/binmode.t
autodie-2.29/t/context.t
autodie-2.29/t/crickey.t
autodie-2.29/t/no_carp.t
autodie-2.29/t/sysopen.t
autodie-2.29/t/usersub.t
autodie-2.29/t/version.t
autodie-2.29/t/dbmopen.t
autodie-2.29/Makefile.PL
autodie-2.29/lib
autodie-2.29/lib/Fatal.pm
autodie-2.29/t/kwalitee.t
autodie-2.29/t/rt-74246.t
autodie-2.29/t/truncate.t
autodie-2.29/t/internal.t
autodie-2.29/MANIFEST.SKIP
autodie-2.29/t/utf8_open.t
autodie-2.29/lib/autodie.pm
autodie-2.29/t/backcompat.t
autodie-2.29/t/blog_hints.t
autodie-2.29/t/eval_error.t
autodie-2.29/t/scope_leak.t
autodie-2.29/t/exceptions.t
autodie-2.29/t/filehandles.t
autodie-2.29/t/version_tag.t
autodie-2.29/t/import-into.t
autodie-2.29/t/lib
autodie-2.29/t/lib/lethal.pm
autodie-2.29/t/hints_insist.t
autodie-2.29/t/pod-coverage.t
autodie-2.29/t/user-context.t
autodie-2.29/t/author-critic.t
autodie-2.29/benchmarks
autodie-2.29/benchmarks/call.pl
autodie-2.29/benchmarks/leak.pl
autodie-2.29/t/format-clobber.t
autodie-2.29/t/lib/my
autodie-2.29/t/lib/my/pragma.pm
autodie-2.29/lib/autodie
autodie-2.29/lib/autodie/skip.pm
autodie-2.29/lib/autodie/Util.pm
autodie-2.29/t/context_lexical.t
autodie-2.29/t/exception_class.t
autodie-2.29/t/autodie_skippy.pm
autodie-2.29/t/lib/OtherTypes.pm
autodie-2.29/t/lib/Hints_test.pm
autodie-2.29/t/lib/my/autodie.pm
autodie-2.29/lib/autodie/hints.pm
autodie-2.29/t/basic_exceptions.t
autodie-2.29/t/string-eval-leak.t
autodie-2.29/t/lib/Some
autodie-2.29/t/lib/Some/Module.pm
autodie-2.29/t/lib/pujHa
autodie-2.29/t/lib/pujHa/ghach.pm
autodie-2.29/t/string-eval-basic.t
autodie-2.29/t/release-pod-syntax.t
autodie-2.29/benchmarks/raw-call.pl
autodie-2.29/t/hints_pod_examples.t
autodie-2.29/t/hints_provider_isa.t
autodie-2.29/t/lib/Caller_helper.pm
autodie-2.29/benchmarks/benchmark.pl
autodie-2.29/t/hints_provider_does.t
autodie-2.29/t/internal-backcompat.t
autodie-2.29/t/release-pod-coverage.t
autodie-2.29/lib/autodie/exception.pm
autodie-2.29/t/autodie_test_module.pm
autodie-2.29/t/lib/autodie/test
autodie-2.29/t/lib/autodie/test/au.pm
autodie-2.29/t/core-trampoline-slurp.t
autodie-2.29/lib/autodie/Scope
autodie-2.29/lib/autodie/Scope/Guard.pm
autodie-2.29/t/lib/pujHa/ghach
autodie-2.29/t/lib/pujHa/ghach/Dotlh.pm
autodie-2.29/t/lib/Hints_pod_examples.pm
autodie-2.29/t/lib/Hints_provider_isa.pm
autodie-2.29/t/lib/Hints_provider_does.pm
autodie-2.29/t/lib/autodie/test/badname.pm
autodie-2.29/t/lib/autodie/test/missing.pm
autodie-2.29/lib/autodie/Scope/GuardStack.pm
autodie-2.29/lib/autodie/exception
autodie-2.29/lib/autodie/exception/system.pm
autodie-2.29/t/hints_provider_easy_does_it.t
autodie-2.29/t/lib/autodie/test/au
autodie-2.29/t/lib/autodie/test/au/exception.pm
autodie-2.29/benchmarks/Fatal_Leaky_Benchmark.pm
autodie-2.29/t/lib/Hints_provider_easy_does_it.pm
Entering autodie-2.29
Checking configure dependencies from META.json
Checking if you have ExtUtils::MakeMaker 0 ... Yes (7.24)
Configuring autodie-2.29 ... Running Makefile.PL
Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for autodie
Writing MYMETA.yml and MYMETA.json
OK
Checking dependencies from MYMETA.json ...
Checking if you have Scalar::Util 0 ... Yes (1.45)
Checking if you have FindBin 0 ... Yes (1.51)
Checking if you have File::Spec 0 ... Yes (3.40)
Checking if you have IO::Handle 0 ... Yes (1.33)
Checking if you have Fcntl 0 ... Yes (1.11)
Checking if you have if 0 ... Yes (0.0602)
Checking if you have POSIX 0 ... Yes (1.30)
Checking if you have lib 0 ... Yes (0.63)
Checking if you have Socket 0 ... Yes (2.021)
Checking if you have File::Copy 0 ... Yes (2.23)
Checking if you have warnings 0 ... Yes (1.13)
Checking if you have parent 0 ... Yes (0.225)
Checking if you have ExtUtils::MakeMaker 0 ... Yes (7.24)
Checking if you have overload 0 ... Yes (1.18)
Checking if you have constant 0 ... Yes (1.27)
Checking if you have B 0 ... Yes (1.35)
Checking if you have Exporter 5.57 ... Yes (5.68)
Checking if you have Carp 0 ... Yes (1.26)
Checking if you have Test::More 0 ... Yes (1.302049)
Checking if you have strict 0 ... Yes (1.07)
Checking if you have File::Temp 0 ... Yes (0.2301)
Checking if you have Tie::RefHash 0 ... Yes (1.39)
Building and testing autodie-2.29 ... cp lib/autodie/Util.pm blib/lib/autodie/Util.pm
cp lib/autodie/hints.pm blib/lib/autodie/hints.pm
cp lib/Fatal.pm blib/lib/Fatal.pm
cp lib/autodie/Scope/Guard.pm blib/lib/autodie/Scope/Guard.pm
cp lib/autodie/Scope/GuardStack.pm blib/lib/autodie/Scope/GuardStack.pm
cp lib/autodie/exception.pm blib/lib/autodie/exception.pm
cp lib/autodie/skip.pm blib/lib/autodie/skip.pm
cp lib/autodie.pm blib/lib/autodie.pm
cp lib/autodie/exception/system.pm blib/lib/autodie/exception/system.pm
Manifying 9 pod documents
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/00-load.t ...................... ok
t/args.t ......................... ok
t/author-critic.t ................ skipped: these tests are for testing by the author
t/autodie.t ...................... ok
t/backcompat.t ................... ok
t/basic_exceptions.t ............. ok
t/binmode.t ...................... ok
t/blog_hints.t ................... ok
t/caller.t ....................... ok
t/chmod.t ........................ ok
t/chown.t ........................ ok
t/context.t ...................... ok
t/context_lexical.t .............. ok
t/core-trampoline-slurp.t ........ ok
t/crickey.t ...................... ok
t/critic.t ....................... skipped: Author test.  Set $ENV{AUTHOR_TESTING} to true to run.
t/dbmopen.t ...................... ok
t/eval_error.t ................... ok
t/exception_class.t .............. ok
t/exceptions.t ................... ok
t/exec.t ......................... ok
t/Fatal.t ........................ ok
t/filehandles.t .................. ok
t/fileno.t ....................... ok
t/flock.t ........................ ok
t/fork.t ......................... skipped: BSD::Resource required to test fork()
t/format-clobber.t ............... ok
# Sub::Identify is loaded
t/hints.t ........................ ok
t/hints_insist.t ................. ok
t/hints_pod_examples.t ........... ok
t/hints_provider_does.t .......... ok
t/hints_provider_easy_does_it.t .. ok
t/hints_provider_isa.t ........... ok
t/import-into.t .................. skipped: Test needs Import::Into >= 1.002004
t/internal-backcompat.t .......... ok
t/internal.t ..................... ok
t/kill.t ......................... skipped: Can unexpectedly signal process 1. Won't run as root.
t/kwalitee.t ..................... skipped: Test::Kwalitee not installed; skipping
t/lethal.t ....................... ok
t/lex58.t ........................ skipped: IPC::System::Simple required
t/mkdir.t ........................ ok
t/no_carp.t ...................... ok
t/open.t ......................... ok
t/pod-coverage.t ................. skipped: Author test.  Set $ENV{AUTHOR_TESTING} to true to run.
t/pod.t .......................... skipped: Author test.  Set $ENV{AUTHOR_TESTING} to true to run.
t/read.t ......................... ok
t/recv.t ......................... ok
Can't locate Pod/Coverage/TrustPod.pm in @INC (@INC contains: /root/.cpanm/work/1493999664.44/autodie-2.29/blib/lib /root/.cpanm/work/1493999664.44/autodie-2.29/blib/arch /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at t/release-pod-coverage.t line 13.
BEGIN failed--compilation aborted at t/release-pod-coverage.t line 13.
t/release-pod-coverage.t ......... 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
t/release-pod-syntax.t ........... ok
t/repeat.t ....................... ok
t/rt-74246.t ..................... ok
t/scope_leak.t ................... ok
t/skip.t ......................... ok
t/socket.t ....................... skipped: Author test.  Set $ENV{AUTHOR_TESTING} to true to run.
t/string-eval-basic.t ............ ok
t/string-eval-leak.t ............. ok
t/sysopen.t ...................... ok
t/system.t ....................... skipped: IPC::System::Simple not installed
t/truncate.t ..................... ok
t/unlink.t ....................... ok
t/user-context.t ................. ok
t/usersub.t ...................... ok
t/utf8_open.t .................... ok
t/utime.t ........................ ok
t/version.t ...................... ok
t/version_tag.t .................. ok

Test Summary Report
-------------------
t/release-pod-coverage.t       (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
Files=66, Tests=508,  4 wallclock secs ( 0.25 usr  0.08 sys +  3.60 cusr  0.57 csys =  4.50 CPU)
Result: FAIL
Failed 1/66 test programs. 0/508 subtests failed.
make: *** [test_dynamic] Error 255
FAIL
! Installing autodie failed. See /root/.cpanm/work/1493999664.44/build.log for details. Retry with --force to force install it.

use strict;
use autodie;
use local::lib './local_lib'; # local_lib has List::Util 1.50 
use List::Util 1.50 ();
print "ok\n";

use strict;
use local::lib './local_lib';
use autodie;
use List::Util 1.50 ();
print "ok\n";

Using custom exception classes for autodie fails if the packages are
defined inline and do not reside in a separate file.

I have attached a patch with a testcase as well as a possible fix.

An 'undef' return from fileno indicates a filehandle is closed so
autodie should not make it fatal.

Example:

$ perl -Mautodie -wE 'say( fileno FOO ? "open" : "closed" )'
Can't fileno('FOO'):  at -e line 1

7efcc3ce7000-7efcc3cf1000 r-xp 00000000 fd:01 878942                     /usr/local/cpanel/3rdparty/perl/528/lib/perl5/5.28.0/x86_64-linux-64int/auto/List/Util/Util.so
7efcc3cf1000-7efcc3ef0000 ---p 0000a000 fd:01 878942                     /usr/local/cpanel/3rdparty/perl/528/lib/perl5/5.28.0/x86_64-linux-64int/auto/List/Util/Util.so
7efcc3ef0000-7efcc3ef1000 r--p 00009000 fd:01 878942                     /usr/local/cpanel/3rdparty/perl/528/lib/perl5/5.28.0/x86_64-linux-64int/auto/List/Util/Util.so
7efcc3ef1000-7efcc3ef2000 rw-p 0000a000 fd:01 878942                     /usr/local/cpanel/3rdparty/perl/528/lib/perl5/5.28.0/x86_64-linux-64int/auto/List/Util/Util.so

Windows 10, Strawberry Perl 5.26.1 cpan upgrade of autodie 2.3.1 seems to go OK, but then "cpan" tries to install BSD::Resource (for testing?)...

Running install for module 'BSD::Resource'
Fetching with LWP:
http://cpan.strawberryperl.com/authors/id/J/JH/JHI/BSD-Resource-1.2911.tar.gz
Checksum for C:\STRAWB~1\cpan\sources\authors\id\J\JH\JHI\BSD-Resource-1.2911.tar.gz ok
Configuring J/JH/JHI/BSD-Resource-1.2911.tar.gz with Makefile.PL

Configuring BSD::Resource...

Checking whether you have certain header files...
The system cannot find the path specified.
The system cannot find the path specified.
Your operating system does not seem to have <sys/resource.h> or <sys/rusage.h>.

(Run "perl Makefile.PL" with the environment variable VERBOSE set to 1 (one)
 too see in more detail what went wrong.)

There is no way BSD::Resource is going to work.

I am awfully sorry but I cannot go further.

Aborting configuration of BSD::Resource.
Warning: No success on command[C:\Strawberry\perl\bin\perl.exe Makefile.PL]
  JHI/BSD-Resource-1.2911.tar.gz
  C:\Strawberry\perl\bin\perl.exe Makefile.PL -- NOT OK
Running install for module 'BSD::Resource'
  JHI/BSD-Resource-1.2911.tar.gz
  Has already been unwrapped into directory C:\STRAWB~1\cpan\build\BSD-Resource-1.2911-0
  JHI/BSD-Resource-1.2911.tar.gz
  'C:\Strawberry\perl\bin\perl.exe Makefile.PL' returned status 512, not re-running
Failed during this command:
 (optional) JHI/BSD-Resource-1.2911.tar.gz    : writemakefile NO 'C:\Strawberry\perl\bin\perl.exe Makefile.PL' returned status 512

cpan> i autodie
Module id = autodie
    CPAN_USERID  TODDR (Todd Rinaldo <[email protected]>)
    CPAN_VERSION 2.31
    CPAN_FILE    T/TO/TODDR/autodie-2.31.tar.gz
    UPLOAD_DATE  2020-01-08
    MANPAGE      autodie - Replace functions with ones that succeed or die with lexical scope
    INST_FILE    C:\Strawberry\perl\site\lib\autodie.pm
    INST_VERSION 2.31

cpan> i BSD::Resource
Fetching with LWP:
http://cpan.strawberryperl.com/authors/id/J/JH/JHI/CHECKSUMS
Module id = BSD::Resource
    CPAN_USERID  JHI (Jarkko Hietaniemi <[email protected]>)
    CPAN_VERSION 1.2911
    CPAN_FILE    J/JH/JHI/BSD-Resource-1.2911.tar.gz
    UPLOAD_DATE  2017-04-09
    MANPAGE      BSD::Resource - BSD process resource limit and priority functions
    INST_FILE    (not installed)

It looks like autodie itself is trying to install BSD::Resource, and it appears to be uninstallable on Windows. You might want to consider bypassing this if you're not on a supported system.

Running make for T/TO/TODDR/autodie-2.31.tar.gz
---- Unsatisfied dependencies detected during ----
----         TODDR/autodie-2.31.tar.gz        ----
    BSD::Resource [build_requires,optional]
    Import::Into [build_requires,optional]

autodie seems to claim to be up to date, but I'm not sure if it completed its testing. If BSD::Resource is truly optional, I think it should be skipped on non-BSD systems so such alarming messages aren't given.

pvm92@peter:~> cat no-autodie-twice.pl 
#!/usr/bin/perl
{ no autodie; }
{ no autodie; }
system("echo something");

pvm92@peter:~> ./no-autodie-twice.pl 
Undefined subroutine called at ./no-autodie-twice.pl line 4.

pvm92@peter:~> perl -Mautodie -E 'say $autodie::VERSION'
2.29

# It doesn't help to use the git master HEAD
pvm92@peter:~> (cd autodie && git log -1)
commit 79f7f102680de60bbb6eaee0e89b4032bf4547c9
Merge: bbfe28c 933b8fc
Author: Niels Thykier <[email protected]>
Date:   Sun Sep 25 11:22:47 2016 +0200

    Merge pull request #74 from pjf/ack
    
    Ackrc: Ignore build directories

pvm92@peter:~> perl -Iautodie/lib ./no-autodie-twice.pl 
Undefined subroutine called at ./no-autodie-twice.pl line 4.

pvm92@peter:~> perl -V | grep ^Summary
Summary of my cperl (revision 5 version 29 subversion 0) configuration:

$ rm foo; rm bar
$ touch foo
$ perl -Mautodie -e'unlink("foo","bar")'

use autodie (':all', -caller => 'Some::Other::Namespace');

If umask(2) is not implemented on your system and you are trying
to restrict access for *yourself* (i.e., "(EXPR & 0700) > 0"),
raises an exception. If umask(2) is not implemented and you are
not trying to restrict access for yourself, returns "undef".

#!/usr/bin/env perl

package CORE::GLOBAL;

use strict;
use warnings;
use subs qw(chmod);

sub chmod {
    print qq{overrided chmod\n};

    return;
}

package main;

use autodie qw(chmod);

chmod 0777, './adsadas';

1;
__END__

$ perl -wle 'use Path::Tiny;  path("/foo/bar")->openr'
Can't open '/foo/bar' for reading: 'No such file or directory' at /Users/schwern/perl5/perlbrew/perls/perl-5.16.2-threads/lib/site_perl/5.16.2/Path/Tiny.pm line 200

$ perl -wle 'use Path::Tiny;  path("/foo/bar")->openr'
Can't open '/foo/bar' for reading: 'No such file or directory' at -e line 1

Here is a simple examle which works good without autodie and dies with
message "Undefined subroutine &Config::Simpliest::read called" when
using autodie:

package main;

my $cfg = Config::Simpliest::read("/tmp/t.txt");

package Config::Simpliest;

use strict;
use autodie;

sub read {
	my $fname = shift;
	open my $fh, $fname;
	
	my %cfg;
	while (<$fh>) {
		chomp;
		my ($k, $v) = split /\s*=\s*/;
		$cfg{$k} = $v;
	}
	
	close $fh;
	return \%cfg;
}

On Sun Aug 28 05:06:24 2011, OLEG wrote:
> Here is a simple examle which works good without autodie and dies with
> message "Undefined subroutine &Config::Simpliest::read called" when
> using autodie:
> 
> [...]

Seems related to github issue #11[1].

~Niels

[1] https://github.com/pjf/autodie/issues/11

==================
root@felipe 14:08:36 case88745 /usr/local/cpanel
 > perl -e'open FH, "<", "yglzdfvxbfg" or die;'
Died at -e line 1.

ENOENT (2)
==================
root@felipe 14:06:08 case88745 /usr/local/cpanel
 > cat | perl -Mautodie
`perl -Mautodie -e'open FH, "<", "yglzdfvxbfg"'`;
print 0+$? . $/;
print $? . $/;
Can't open 'yglzdfvxbfg' for reading: 'No such file or directory' at -e 
line 1
65280
65280

OK
==================

When an exception from autodie causes perl to exit(), the exit code 
should correspond to the value of $! as perl �natively� does as in the 
first example above.


-Felipe Gasper
cPanel, Inc.

On 2014-03-10 20:12, [email protected] via RT wrote:
> Mon Mar 10 15:12:14 2014: Request 93716 was acted upon.
> Transaction: Ticket created by [email protected]
>        Queue: autodie
>      Subject: autodie should exit($!)
>    Broken in: (no value)
>     Severity: (no value)
>        Owner: Nobody
>   Requestors: [email protected]
>       Status: new
>  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=93716 >
> 
> 
> [...]
> 
> When an exception from autodie causes perl to exit(), the exit code 
> should correspond to the value of $! as perl �natively� does as in the 
> first example above.
> 
> 
> -Felipe Gasper
> cPanel, Inc.
> 

Hi Felipe,

What version of autodie are you using?  Namely, I suspect that the
problem would be fixed in autodie 2.21 due to:

"""
        * INTERNAL : $" and $! are no longer arbitrarily messed with
          for no reason via autodie.  (They're still messed with when
          using Fatal.)
"""

Which would ensure that "$!" is (still) set to 2 and die should DTRT
from there.  Previously, $! would be "protected" by a local, causing it
to be reset to (in your example above) 0.

~Niels

On 10.3.14, 2:22 PM, Niels Thykier via RT wrote:
> <URL: https://rt.cpan.org/Ticket/Display.html?id=93716 >
>
> On 2014-03-10 20:12, [email protected] via RT wrote:
>> Mon Mar 10 15:12:14 2014: Request 93716 was acted upon.
>> Transaction: Ticket created by [email protected]
>>         Queue: autodie
>>       Subject: autodie should exit($!)
>>     Broken in: (no value)
>>      Severity: (no value)
>>         Owner: Nobody
>>    Requestors: [email protected]
>>        Status: new
>>   Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=93716 >
>>
>>
>> [...]
>>
>> When an exception from autodie causes perl to exit(), the exit code
>> should correspond to the value of $! as perl �natively� does as in the
>> first example above.
>>
>>
>> -Felipe Gasper
>> cPanel, Inc.
>>
>
> Hi Felipe,
>
> What version of autodie are you using?  Namely, I suspect that the
> problem would be fixed in autodie 2.21 due to:
>
> """
>          * INTERNAL : $" and $! are no longer arbitrarily messed with
>            for no reason via autodie.  (They're still messed with when
>            using Fatal.)
> """
>
> Which would ensure that "$!" is (still) set to 2 and die should DTRT
> from there.  Previously, $! would be "protected" by a local, causing it
> to be reset to (in your example above) 0.
>

Hm. I was using 2.12. That sounds like it would fix the issue, but I 
tried updating my laptop�s autodie version to 2.22, to no avail:

felipe@Macintosh-19 14:25:15 /
 > perl -Mautodie -e'print $autodie::VERSION'
2.22
OK
felipe@Macintosh-19 14:26:53 /
 > cat | perl -Mautodie
`perl -Mautodie -e'open FH, "<", "yglzdfvxbfg"'`;
print ($? >> 8) . $/;
Can't open 'yglzdfvxbfg' for reading: 'No such file or directory' at -e 
line 1
255

-F

Current Behavior:

$>perl -Ilib -Mautodie -e'open FH, "<", "qweqweqerwr"; print "Should not reach here\n"'; echo $?
Can't open 'qweqweqerwr' for reading: 'No such file or directory' at -e line 1
255

Felipe believes it should ext 2: "Normally Perl uses $! as the exit value when an exception ends the program."

#> perl -e'open FH, "<", "qweqweqerwr" or die'; echo $?
Died at -e line 1.
2

$ ./0.pl
Can't open('FILE'): No such file or directory at ./0.pl line 8

xxxx/yyyyyy:  open("does not exist\0", 0x0, 0x1B6) = -1 Err#2

open("does not exist.txt", O_RDONLY) = -1 ENOENT (No such file or directory)

If EXPR is omitted, the global (package) scalar variable of the same name as the FILEHANDLE contains the filename.

#perl -c -Mstrict -Mautodie=truncate -e 'truncate(F,0)'
Bareword "F" not allowed while "strict subs" in use at -e line 1.

#perl -c -Mstrict -e 'truncate(F,0)'
-e syntax OK

autodie does not catch errors in the implicit open done by the <> operator.

# perl -e 'use autodie qw(open); <>; print("did not autodie!\n");' foo

Can't open foo: No such file or directory at -e line 1.
did not autodie!

An explicit open with an error is caught.

# perl -e 'use autodie qw(open); open(FH, "foo"); print("did not autodie!\n");'
Can't open 'foo' for reading: 'No such file or directory' at -e line 1

Ubuntu 10.10,  perl, v5.10.1 (*) built for x86_64-linux-gnu-thread-multi, 2.6.35-32-server #64-Ubuntu SMP Tue Jan 3 02:11:24 UTC 2012 x86_64 GNU/Linux, perl-modules 5.10.1-12ubuntu2.1

Still a problem in 2.30

#!/usr/bin/env perl
use Practices;                     # ----- load company's best practices

open my $fh, "nonexistent.file";   # ----- this should die

package Practices;

use strict;
use warnings;
use autodie;

sub import {

    strict->import();
    warnings->import();

    # ----- TODO what for autodie ?
}

1;

use warnings;
use autodie qw(:all);

open FH, '<:raw', 'file.txt';

Wouldn't it be cool if...

    use autodie;

    {
        open my $fh, ">", $file;
        print $fh @a_lot_of_stuff;
    }

Failed when it ran out of disk space?  This does.

    use autodie;

    {
        open my $fh, ">", $file;
        print $fh @a_lot_of_stuff;
        close $fh;
    }

But because the implicit close of a lexical filehandle is so convenient
one would not bother with an explicit one.

I'm throwing this out there to see if there's a clever way to implement
it.  One is to have open() return a glob object which does an explicit
close() on DESTROY.

This would also offer a solution to another problem...

    Can't close(GLOB(0x803704)) filehandle: 'No space left on device'

It would allow open to attach the original filename to the filehandle
object which can be used to generate better error messages down the line.

On the down side, it will break code that expects open() to return a
non-blessed reference.  autodie is lexical, but filehandles get passed
around.

One work around would be to take advantage of the IO::Handle magic. 
autodie could treat the filehandle as an inside out object to store data
on it and put accessor methods into IO::Handle.  It could add an
IO::Handle::DESTROY to do the extra close.

Blarf.  While the idea of using IO::Handle::DESTROY works A) Perl sends
out a "helpful" warning about it, which I suppose isn't so bad, but B)
$@ gets lost somewhere along the line and C) the eval block doesn't
fail, it looks at the last evaluated lexical statement inside.

  use IO::Handle;

  use warnings;
  no warnings "redefine";
  sub IO::Handle::DESTROY { die "DESTRRRRROY!" }

  print "Eval failed.\n" if !eval {
      open my $fh, "/dev/null";
  };
  print "Caught: $@\n";
  __END__
        (in cleanup) DESTRRRRROY! at - line 5.
Caught: 
	(in cleanup) DESTRRRRROY! at - line 5 during global destruction.

"grep -P . 2" works from command line, and system, and
IPC::System::Simple, but not with autodie=system

echo >2
cat 2
grep -P . 2
perl -Mautodie=system -e " system qw[ grep -P . 2]"
perl -MIPC::System::Simple=system -e " system qw[ grep -P . 2]"
perl -Mautodie=system -MDevel::ModList -e 1
perl -Mautodie=:all -d:Trace -e " system qw[ grep -P . 2]"
>trace.autodie-2.06_01.txt 2>&1




D:\>echo >2

D:\>cat 2
ECHO is on.

D:\>grep -P . 2
ECHO is on.

D:\>perl -Mautodie=system -e " system qw[ grep -P . 2]"
Subroutine IPC::System::Simple::WIFEXITED redefined at
C:/perl/site/5.10.1/lib/IPC/System/Simple.pm line 109.
Subroutine IPC::System::Simple::WEXITSTATUS redefined at
C:/perl/site/5.10.1/lib/IPC/System/Simple.pm line 110.
Subroutine IPC::System::Simple::WIFSIGNALED redefined at
C:/perl/site/5.10.1/lib/IPC/System/Simple.pm line 111.
Subroutine IPC::System::Simple::WTERMSIG redefined at
C:/perl/site/5.10.1/lib/IPC/System/Simple.pm line 112.
grep: invalid option -- ,
Usage: grep [OPTION]... PATTERN [FILE]...
Try `grep --help' for more information.
"grep" unexpectedly returned exit value 2 at (eval 10) line 13
 at -e line 1

D:\>perl -MIPC::System::Simple=system -e " system qw[ grep -P . 2]"
Subroutine IPC::System::Simple::WIFEXITED redefined at
C:/perl/site/5.10.1/lib/IPC/System/Simple.pm line 109.
Subroutine IPC::System::Simple::WEXITSTATUS redefined at
C:/perl/site/5.10.1/lib/IPC/System/Simple.pm line 110.
Subroutine IPC::System::Simple::WIFSIGNALED redefined at
C:/perl/site/5.10.1/lib/IPC/System/Simple.pm line 111.
Subroutine IPC::System::Simple::WTERMSIG redefined at
C:/perl/site/5.10.1/lib/IPC/System/Simple.pm line 112.
ECHO is on.

D:\>perl -Mautodie=system -MDevel::ModList -e 1
Subroutine IPC::System::Simple::WIFEXITED redefined at
C:/perl/site/5.10.1/lib/IPC/System/Simple.pm line 109.
Subroutine IPC::System::Simple::WEXITSTATUS redefined at
C:/perl/site/5.10.1/lib/IPC/System/Simple.pm line 110.
Subroutine IPC::System::Simple::WIFSIGNALED redefined at
C:/perl/site/5.10.1/lib/IPC/System/Simple.pm line 111.
Subroutine IPC::System::Simple::WTERMSIG redefined at
C:/perl/site/5.10.1/lib/IPC/System/Simple.pm line 112.
AutoLoader             5.69
Carp                   1.11
Carp::Heavy
Config
Config_git.pl
Config_heavy.pl
Devel::ModList
DynaLoader             1.10
Exporter               5.63
Fatal                2.06_01
Fcntl                  1.06
File::Spec              3.3
File::Spec::Unix        3.3
File::Spec::Win32       3.3
IPC::System::Simple    1.18
List::Util             1.21
POSIX                  1.17
Scalar::Util           1.21
Tie::Hash              1.03
Tie::RefHash           1.38
Win32                  0.39
Win32::Process         0.14
XSLoader               0.10
autodie              2.06_01
autodie::exception   2.06_01
autodie::exception::system 2.06_01
base                   2.14
constant               1.19
if                     0.05
overload               1.07
re                     0.09
vars                   1.01
warnings               1.06
warnings::register     1.01

D:\>perl -Mautodie=:all -d:Trace -e " system qw[ grep -P . 2]"
>trace.autodie-2.06_01.txt 2>&1

D:\>
D:\>

plackup -e 'sub { use autodie; open my $fh, "<:utf8", "/tmp/x/y/z" }'

Internal autodie::exception error: Don't know how to format mode '<:utf8'. at ...

Can't mkdir($dir, 511): $!