dsyph3r / curl-php Goto Github PK

Changes need to be made to handle HTTP headers according to the HTTP Spec.

1. HTTP headers should end with CRLF but can end with LF. Need to ensure library can handle this
2. HTTP headers are in the form of name: value. There maybe any number of white space characters between the name: and value part. Library currently will fail to handle this.
3. HTTP status line parts should be split by 1 space, but library should handle any number of white space characters between parts (There are 2 parts here, HTTP version, Status Code, Status Message)

Example echo $response['response']:

HTTP/1.0 100 Continue

HTTP/1.0 200 OK
Date: Wed, 21 Sep 2011 12:54:49 GMT
Server: Apache/2.2.17 (Ubuntu)
X-Powered-By: PHP/5.3.5-1ubuntu7.2
Set-Cookie: PHPSESSID=9i8mj6uroahvasactro0bmapr0; path=/
cache-control: no-cache
Vary: Accept-Encoding
Content-Length: 223
Connection: close
Content-Type: text/html; charset=UTF-8

my custom data response is ok

Original Code:

$results = array(
'curl_info' => $response['curl_info'],
'status' => $response['curl_info']['http_code'],
'headers' => $this->splitHeaders($responseSplit[0]),
'data' => $responseSplit[1],
);

I changed :

'headers' => $this->splitHeaders($responseSplit[0]),
'data' => $responseSplit[1],

by:

'headers' => $this->splitHeaders($responseSplit[$responseCount-2]),
'data' => $responseSplit[$responseCount-1],

where $responseCount = count($responseSplit);

Example:
$responseSplit = explode("\r\n\r\n", $response['response']);
$responseCount = count($responseSplit);
$results = array(
'curl_info' => $response['curl_info'],
'status' => $response['curl_info']['http_code'],
'headers' => $this->splitHeaders($responseSplit[$responseCount-2]),
'data' => $responseSplit[$responseCount-1],
);
return $results;

Ignoring HTTP status code 100 if exists