So, while the bot was on, i tried to delete a role.

Guild cache seems to behave randomly sometimes.

Have to send GUILD_SYNC after READY for user tokens.

We should implement the ability to access audit logs.

So, I tried to do commands to the bot privately between me and him. But when i do that, the bot crashes.

                    DiscordRole r = e.Guild.Roles.Find(x => x.Name.Contains("VIP"));
                    if ((await e.Guild.GetMember(e.Message.Author.ID)).Roles.Contains(r.ID))
                    {
                        await e.Message.Respond("You dont have permissions for this command.");
                    }
                    else
                    {
                        await e.Message.Respond("You dont have permissions for this command.");
                    }
                }

After successfully sending a file with SendFile it remains used by the process meaning it cannot be moved, deleted, edited, etc.

afroraydude#5627 @ Discord API (Channel: dotnet_dsharpplus) reported:

Reactions integration

Add the following:

• Add reaction
• Remove reaction
• Get reactions
• Reaction object(?)
• Reaction event

Relevant:
discord/discord-api-docs#166

Hi!

I'm getting a System.NullReferenceException when I'm using _client.UpdateStatus("!help");

Any idea why?

Thank you.

Error: 736621096
User: afroraydude#5627
Time: 10/28/2016 1:52:08 PM
Message:

Reaction Integration

InteractivityExtension.Split cuts off the end of text. I replaced it with this and it works for me.

public static IEnumerable<string> Split(this string str, int chunkSize)
{
    var len = str.Length;
    var i = 0;

    while (i < len)
    {
        var size = Math.Min(len - i, chunkSize);
        yield return str.Substring(i, size);
        i += size;
    }
}

We appear to be missing event handlers for the message pin/unpin and pin update events. We should implement them.

Since there were many changes to library's internals recently, selfbots should be checked out and fixed if necessary.

Though @nick-strohm has provided me with a fix before, it did not seem to work.
Exceptions seem to occur for this line.

I have temporarily commented this part out to keep the library working w/o exceptions.

SendPaginatedMessage page navigation doesn't clamp the CurrentIndex value so it can go out of bounds and start throwing exceptions.

It's easy to get rate limited when removing the reactions, also it requires the "Manage Messages" permission which might worry some server admins. Instead we could treat the MessageReactionAdd and MessageReactionRemove as "click" events, both being able to switch the page.

Hey. I've come up with a quick solution to work with your library on Windows 7 on master branch and would like to share. How would like it to be contributed? Patch? Pull request? My weird idea is to currently maintain master-websocket4net branch and update it with master branch from time to time. Not super convenient, but that's what I'm currently using right now :)

Cheers!

If Internet connectivity is lost for more the 5 seconds, the lib will fail to reconnect and hang. Instead of this we could have it retry every 2 mins or so. Just ideas.

could we have the ability to get all messages since a certain date in a discord channel? i think that would be amazing.
Thanks in advance

I believe this is because of this line:
[JsonProperty("is_bot", NullValueHandling = NullValueHandling.Ignore)]
I think it's supposed to be "bot" only according to Discord's documentation.

Currently, I think the only way to send an embed is (DiscordClient is client in this example)

e.Channel.SendMessage("", false, embed).

Maybe we can get client.SendMessage(e.Channel.ID, "", false, embed)?

This part of the code is giving me an error exception
if (!e.Channel.IsPrivate)
{
if(client.Guilds[e.Guild.ID].Members.Find(x => x.User.ID == e.Message.Author.ID).Roles.Contains(248495023132246017))
{
do stuff here
}
}

This can be bad for performance depending on what the actual type is. It could be a LINQ query and in that case the query will run every time something like First(), Count(), or ToArray() is used.

Should just eagerly ToList() at the start of the method and use that instead.

Naamloos#2887 @ Naamloos' chat (Channel: spam) reported:

Something goes wrong when sending a DM, not sure what -Naam

http://i.kingdgrizzle.tk/2017/02/e4V4J6.png

Seems like theres a lib error. it happens on self-bots, i don't know about other bots

Error: 428367488
User: @189199638450929664
Time: 10/14/2016 8:12:45 PM
Message:

testitonemoretime

Error: 267321056
User: @189199638450929664
Time: 10/14/2016 7:48:00 PM
Message:

test

404s apparently. Needs a fix.

Hey man,

Been using your lib for a bit now but I can't get my head around an issue I'm having when following your tutorials. I think they might be out of date or maybe there is a bug.

DiscordClient _client = new DiscordClient(new DiscordConfig()
{
       Token = "qsdfqsdf.qsdf.qsdf",
       AutoReconnect = true
});

_client.MessageCreated += async (e) =>
{
    if (!e.Message.Author.IsBot)
    {
          if (e.Message.Content.StartsWith("!hello"))
          await e.Channel.SendMessage($"Hello, {e.Message.Author.Username}");
     }
};

var c = new CommandConfig
{
    Prefix = "!",
    SelfBot = false
};

_client.UseCommands(c);

_client.AddCommand("hello", async (e) =>
{
      await e.Message.Parent.SendMessage($"Hello, {e.Message.Author.Mention}");
});

_client.Connect();
Console.ReadLine();

I get the following exception :
{"Method not found: 'DSharpPlus.DiscordMessage DSharpPlus.MessageCreateEventArgs.get_Message()'."}
System.MissingMethodException

And it happens as soon as a message is sent (not specifically with the prefix, just any message).

I'm guessing I'm just using the lib like a retard but I couldn't find a working scenario, could you possibly send some love to make it work ? :D

Thanks man

May have found a typo in the InternalModifyGuildRole method in DiscordClient.cs.
Looks like a missing "/", didn't look into whether this should be fixed on the line (2459 in github) or somewhere else.

Current: string url = Utils.GetAPIBaseUri() + Endpoints.Guilds + "/" + guild_id + Endpoints.Roles + role_id;
Fixed: string url = Utils.GetAPIBaseUri() + Endpoints.Guilds + "/" + guild_id + Endpoints.Roles + "/" + role_id;

Naamloos#2887 @ Naamloos' chat (Channel: spam) reported:

Fix issue with DiscordClient.SocketClosed in combination with DiscordClient.Connect to reconnect. 
Example: http://prntscr.com/d0xxsq

GET request don't support payloads (.NET), though it has to for Discord's API. The Get Channel Messages endpoint requires a payload with a message ID and a limit. Neither of these can be filled in as .NET doesn't support this. We have two possible solutions.

1. Keep it like this, limited to only the 50 latest messages
2. 3rd party library for webrequests

So, what are we going to do? Any other suggestions?

Official Discord docs say "source url of the thumbnail (only supports http(s) and attachments)"
https://discordapp.com/developers/docs/resources/channel#embed-thumbnail-structure

Yet, when using an http url, Discord will not display the image (it does work with other libraries, as seen here https://cdn.discordapp.com/attachments/146044397861994496/310709387318788096/unknown.png )

Naamloos#2887 @ Naamloos' chat (Channel: dsharpplus) reported:

changing avatar throws exception

Fix my bad. I made the thing pull data for each user it gets.

Or skip the reactions. The TimeoutBehavior should probably still be respected.

So people know when they can't flick through pages anymore.

Guild lists will only return a maximum of 100 guilds soon, we need to add the before, after and limit params.

More info:
discord/discord-api-docs#151

Getting shards count:
https://github.com/hammerandchisel/discord-api-docs/blob/master/docs/topics/Gateway.md#get-gateway--get-gatewaybot

Naamloos#2887 @ Naamloos' chat (Channel: dsharpplus_dev) reported:

test issue reporting github stuff

Before we release, we should put some finishing touches on CNext:

• Implement proper [RequireOwner] attribute.
• Implement proper [RequirePermission(Permission)] attribute. It should also have an option to automatically deny or allow in DMs.
• Implement case insensitivity.
• Implement [RemainingText] attribute
• Make string splitter ignore any escape other than `, ", and whitespace.
• Integrate string splitter with type converter.
• Perhaps sudo functionality.

DiscordRole.Position doesnt update when doing Guild.UpdateRole, Emzi0767 said that it's not implemented yet

Was trying to make a command that lists a server's roles, but accessing ctx.Guild.Roles always throws a NullReferenceException... (EnableDms is false)

It's not just for one message but for every single message that the server sends, and for all the channels. I did not try kicking and rejoining the bot unfortunately.

For SendPaginatedMessage. Some people found it confusing that only a specific user could switch pages.

Naamloos#2887 @ Discord API (Channel: dotnet_dsharpplus) reported:

email pass endpoint was removed. Make obsolete.

So @Emzi0767 gave me some ideas for future versions of the library. These ideas should further improve the library in a lot of ways. I'm excited!

Here's a "little" checklist:

• Incoming voice
• Organize class members so that they are not all over the place, but are ordered according to some key. No effect on end-users, and will make maintenance easier.
• Make all entities immutable, and perform mutation via events only. This is potentially mildly breaking, but it will also eliminate some weird cases.
• Implement a message cache.
• Abstract data structures. This will make maintenance infinitely easier. No effect on end-users.
• Port VoiceNext to 2.x
• .SetMute and .SetDeaf methods for DiscordMembers
• Multi file uploading (to one message ofc)
• Settle on argument naming. I'm in favour of snake_case. Shouldn't affect compatiblity.
• Setting on private field naming. Ditto as above.
• Rename all awaitable methods to ...Async(). This could be potentially breaking, but it'd help reduce confusion by making it clear what needs to be awaited and what doesn't.
• Split the websocket and REST parts of the client for API communication. No effect on end-user, but will make classes smaller and easier to maintain.
• make DiscordMember inherit from DiscordUser rather than wrap it. This is going to make working with members infinitely easier.
• Docs overhaul
• Command overhaul
• More example bots
• Support for different .NET versions, including .NET core
• Discord character limits
• Fix caches
• Sharding support
• Autosharding support

As emzi stated, the lib has grown quite a bit, and its code organization is messy.

If any of you have any other ideas, leave them as comments.
Also: if anything listed gets implemented, also leave a comment so i can edit the main message.

Thank you

I have to admit, the way I implemented rate limiting was cheap. I'm sorry for that. We still have to improve on it.

A few resources that are relevant:
discord/discord-api-docs#108
https://github.com/hammerandchisel/discord-api-docs/blob/master/docs/topics/Rate_Limits.md
Please comment with any other resources that could help developing rate limiting for DSharpPlus

• Naamloos

If my Bot starts at all; I write a test message but it´s getting duplicated. (and then is going to crash.)