Comments (1)
Hello!
I can definitely see the omission versus the original source. Just applied the recommended changes, repeated the build, and all of the prior unit tests passed. This change is subtle enough that the uncorrected version really doesn't cause much distortion except in the specific situations identified.
Give the following JAR a spin, it's the current version of Newhall with the one amended line above, you should be able to run it with "java -jar Newhall-1.6.0-TESTBUILD-A.jar": https://s3-us-west-1.amazonaws.com/drww/Newhall-1.6.0-TESTBUILD-A.jar
If you find it works out better on some of the affected sets, I can fold this change into a new release, and increment the version counter accordingly. "1.6.1" has a good ring to it. If you can provide some datasets that demonstrate the problem (2-3 would be fine), I can also fold those into the unit test framework, to make sure this fix never regresses.
from newhall.
Related Issues (19)
- Convert the BASIC NSM source code into psudocode for porting template. HOT 1
- Generate a 1:1 Java translation from psudocode template. HOT 1
- Write JUnit tests to ensure simulation consistency with DOS version. HOT 2
- Create Swing GUI for Newhall HOT 1
- Replace the word "degree(s)" with the ASCII degree symbol. HOT 1
- Add Precip/Evapo Delta on Results Tab HOT 1
- Add <nettype> tag to XML format. HOT 1
- Add source unit system tag, <srcunitsys>. HOT 4
- Verify quality of connector post-structure changes to XML format. HOT 2
- Batch Mode HOT 3
- Degree symbols have become corrupted. Fix cross-platform interoperability. HOT 2
- <srcunitsys> should not be altered and instead passed through. HOT 1
- Move <srcunitsys> into <metadata>. HOT 1
- Create summarizer tool to compile directories of run XML files into a flat CSV file. HOT 1
- Edge case on high-temp, southern locations. Tempcal ntd[] is full of nulls out of the model. HOT 6
- Investigate Anomalous Soil Temps HOT 3
- Add Years and total pet to csv summary tool
- BIO5 moist calculation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from newhall.