Code Monkey home page Code Monkey logo

Comments (6)

GoogleCodeExporter avatar GoogleCodeExporter commented on August 30, 2024
None of the conditions to set ntd[] variables in BasicSimulationModel are being 
hit during the execution of these datasets.  These population routines are all 
inside an if() block that checks to see if:

if (tc != 0 || tu != 0) {

These conditions are not being satisfied.

Original comment by [email protected] on 26 Jul 2011 at 8:06

from newhall.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 30, 2024
In one of the test datasets, MEAD89, the following is true for its run:

tc = -1, tu = 0

Original comment by [email protected] on 26 Jul 2011 at 8:08

from newhall.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 30, 2024
In MEAD89, the tc variable is only ever modified twice, two set it to -1 both 
times.  Conditions to set tc to -1 does not occur in 169013 and 20080.

The condition skipTo890 has been flagged true, setting tc to 0.  Again around 
920, tc is getting set to 0 again, this is because tempUnder8C has been flagged 
false, which speaks toward the kind of datasets that we are encountering this.

Two conditions cause skipTo890 to occur:  np = 0 and wt <= 5

Original comment by [email protected] on 26 Jul 2011 at 8:21

from newhall.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 30, 2024
The temperature calculator is short circuiting because no temperatures under 8 
degrees Celsius are being detected.  As such, the entire temperature calendar 
would be full of 8's for "in excess of 8C".

What should occur is the total population of the temperature calendar with 8's. 
 However, I will verify what the BASIC model does under DOS with these datasets.

Original comment by [email protected] on 26 Jul 2011 at 8:25

from newhall.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 30, 2024
Added special behavior for this edge case in the model.  Seems to fix 
everything and match FLEXNSM behavior.  Unit tests still required.

Original comment by [email protected] on 26 Jul 2011 at 9:29

  • Changed state: Started

from newhall.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 30, 2024
Unit tests added, and they pass.  Problem fixed in 1.4.5.

Original comment by [email protected] on 26 Jul 2011 at 9:38

  • Changed state: Fixed

from newhall.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.