Code Monkey home page Code Monkey logo

Comments (5)

drwpow avatar drwpow commented on May 27, 2024 1

Ah if you’re looking to bundle schemas, then you should use the Redocly CLI bundle command. That needs to be run before openapi-typescript.

I’d welcome an addition to the docs that clarifies this (perhaps something like a tip added):

::: tip

This will preserve schemas 1:1 input:output. To bundle multiple schemas into one, use Redocly’s [bundle command](https://redocly.com/docs/resources/multi-file-definitions/#bundle)

:::

Feel free to adjust the wording 🙂

from openapi-typescript.

mariusflorescu avatar mariusflorescu commented on May 27, 2024

On the same topic what if we have:

  • reference.json - which contains $defs
  • openapi.yaml file that references the defs from the reference.json file

Is it possible to make it work? I don't see an example of this use case in the docs.

from openapi-typescript.

melissag avatar melissag commented on May 27, 2024

@drwpow Thanks for your response. In particular your call out that This will preserve schemas 1:1 input:output suggests to me that the existing documentation example should be updated in the following way:

Current

apis:
  core@v2:
    root: ./openapi/openapi.yaml
    x-openapi-ts:
      output: ./openapi/openapi.ts
  external@v1:
    root: ./openapi/external.yaml
    x-openapi-ts:
      output: ./openapi/openapi.ts

Updated

apis:
  core@v2:
    root: ./openapi/openapi.yaml
    x-openapi-ts:
      output: ./openapi/openapi.ts
  external@v1:
    root: ./openapi/external.yaml
    x-openapi-ts:
      output: ./openapi/external.ts  # note updated name

Does this make sense to you, or am I still confused on how this is meant to work?

from openapi-typescript.

drwpow avatar drwpow commented on May 27, 2024

@melissag yes! Apologies for not even noticing the typo in the docs. Yes that’s confusing, and your proposal is exactly how it should work. Would welcome a PR if you have time!

from openapi-typescript.

melissag avatar melissag commented on May 27, 2024

Done, thanks for the guidance! Let me know if I goofed on anything in the PR process, not super familiar.

from openapi-typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.