Comments (4)
Yes it is not easy. Maybe it should be more finer grained. Array and object serialization can be different. I created a serializer for formExplode for object. It may help someone.
const serializePrimitive = (key, value) => `${key}=${encodeURIComponent(String(value))}`;
const serializeArray = (key, value, serializer) => {
if (!value.length) return undefined;
return value
.map((item) => serializer(key, item))
.filter(Boolean)
.join('&');
};
const serializeObject = (value, serializer) => {
const entries = Object.entries(value).filter(([_, v]) => v !== undefined && v !== null);
if (!entries.length) return undefined;
return entries
.map(([k, v]) => serializer(k, v))
.filter(Boolean)
.join('&');
};
const queryParamSerializer = (key, value) => {
if (value === null || value === undefined) return undefined;
const type = typeof value;
if (type === 'string' || type === 'number' || type === 'boolean') return serializePrimitive(key, value);
if (Array.isArray(value)) return serializeArray(key, value, queryParamSerializer);
if (type === 'object') return serializeObject(value, queryParamSerializer);
return undefined;
};
export const querySerializer = (q) => {
const search: string[] = [];
if (q && typeof q === 'object') {
for (const [k, v] of Object.entries(q)) {
const value = queryParamSerializer(k, v);
if (value) {
search.push(value);
}
}
}
return search.join('&');
};
from openapi-typescript.
You are right the docs are incorrect and says the default is form/explode when it’s deepObject. The docs should be fixed, but I’m unsure if the default should be changed again, because there were many issues opened about simpler serializers being used.
No matter what the default is, there will always be a large number of users whose backends implement a different style. In that vein, would it be worthwhile to ship some additional querySerializers that handle alternate syntaxes? Perhaps something like:
import createClient from 'openapi-fetch';
import { formExplode } from 'openapi/serializers';
createClient({
querySerializer: formExplode
});
from openapi-typescript.
I really like the idea of separating object + array serialization! I don’t think anyone’s suggested that before. Adding that would make it easier for people to customize their own serializers for sure, and that could be added in a backwards-compatible way.
from openapi-typescript.
Also digging into this, I realize that we don’t support path serialization very well either, but should. Will add a minor breaking change to the library to handle this (and provide for easier overrides).
Since this is a breaking change, this will probably be released in 0.9.0
along with #1521.
from openapi-typescript.
Related Issues (20)
- openapi-typescript cmd idle when using redocly.yaml HOT 2
- Empty object inside of allOf creates Record<string, never> in a type intersection HOT 2
- Query param type safety only works for the first param. HOT 5
- client["/endpoint"].GET style call pattern to enable go-to-definition HOT 2
- immutable option and readonly arrays HOT 1
- failure on attempting to GET a binary image response HOT 3
- `--exclude-deprecated` flag is not applied to query and path HOT 2
- Redocly not using auth headers from env var when trying to pull a yaml from a private repo HOT 3
- Operation types are being mapped incorrectly (v7) HOT 3
- Add an option to generate type aliases for schemas HOT 2
- Exception in catch block: `TypeError: Response.text: Body has already been consumed.` HOT 2
- Request Header 'Content-Type' no longer set for requests with body serialized as FormData HOT 3
- after upgrade from 0.8.2 to 0.9.1, receiving several errors all inside openapi-fetch HOT 5
- transforming enum to delete the pathname at the enum name HOT 4
- Copy the API version to output file HOT 1
- proposal: openapi-fetch new send function HOT 5
- Document Chinese support HOT 8
- Allow providing custom `Request` and `Response` HOT 1
- 7.x nullable enum bug HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openapi-typescript.