Request to remove ?ver query string about libvmod-querystring HOT 7 CLOSED

Actually, the point of regfilter is to match the parameter itself, so that you don't need to take care of the separators. When I asked for an example I meant VCL code, sorry for the ambiguity. But from your two log records you could probably use regfilter this way:

querystring.regfilter(req.url, "v|ver")

It may be a bit too inclusive, so you way want to harden it this way:

querystring.regfilter(req.url, "^(v|ver)$")

It is more readable and should actually work with both examples. And as a matter of fact your second example didn't work, the query string is still there in the returned value.

When in doubt, you can instead rely on the more verbose filter:

querystring.filter(req.url, "v" + querystring.filtersep() + "ver");

But this one can grow out of control if you have too many parameters like all the one you can get if you have a google analytics campaign.

from libvmod-querystring.

Could you please either show me a test case or the varnishlog output of such a transaction?

At first glance I would say that your first regex looks wrong, it contains spaces that probably prevent you from reaching line 3.

from libvmod-querystring.

Sorry that was a typo, I can see the querystring.remove working

30 VCL_call     c vmod_remove("/wp-content/themes/generatepress/style.css?devbproto-refresh=0.4084768013563007") "/wp-content/themes/generatepress/style.css"

However the regfilter is not removing for this and I'm struggling to catch a varnishlog since my filters aren't working

http://www.htpcguides.com/wp-content/plugins/simple-share-buttons-plus/js/ssbp_page.js?ver=4.3.1

I did notice a regex error, it should be -+, however this hasn't changed anything

from libvmod-querystring.

Can you show me a regfilter example instead? Unlike remove that is quite straightforward, regfilter can be tricky.

from libvmod-querystring.

That's the thing, there seems to be nothing done to .js files

31 RxURL        c /wp-content/themes/generatepress/js/superfish.min.js?ver=1.3.19
 31 RxProtocol   c HTTP/1.1
 31 RxHeader     c Host: www.htpcguides.com

from libvmod-querystring.

Finally found one

VCL_call     c vmod_regfilter("/?sccss=1&ver=4.3.1", "(\?|\&)ver\=.+") "/?sccss=1&ver=4.3.1"

and this, I do realize the regex needs to be tweaked for this (this (?|&)v(er)?=.+ will match it)

 20 VCL_call     c vmod_regfilter("/wp-content/themes/generatepress/fonts/fontawesome-webfont.woff2?v=4.4.0", "(\?|\&)ver\=.+") "/wp-content/themes/generatepress/fonts/fontawesome-webfont.woff2?v=4.4.0"

from libvmod-querystring.

This issue just timed out. Feel free to reopen it if you still have issues.

from libvmod-querystring.