Comments (6)
glensc
commented on June 3, 2024
Thanks for the patch! fffe758 fixes the build.
And a reminder to make new release ;)
from libvmod-querystring.
e2-robert
commented on June 3, 2024
Seems to fail again with same error when building upon varnish 7.0.0 with patch from #49:
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `build-aux'.
libtoolize: copying file `build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
configure.ac:30: installing 'build-aux/ar-lib'
configure.ac:33: installing 'build-aux/config.guess'
configure.ac:33: installing 'build-aux/config.sub'
configure.ac:29: installing 'build-aux/install-sh'
configure.ac:29: installing 'build-aux/missing'
src/Makefile.am:26: error: 'vmod_LTLIBRARIES' is used but 'vmoddir' is undefined
parallel-tests: installing 'build-aux/test-driver'
automake: warnings are treated as errors
src/Makefile.am:33: warning: variable 'nodist_libvmod_querystring_la_SOURCES' is defined but no program or
src/Makefile.am:33: library has 'libvmod_querystring_la' as canonical name (possible typo)
src/Makefile.am:30: warning: variable 'libvmod_querystring_la_SOURCES' is defined but no program or
src/Makefile.am:30: library has 'libvmod_querystring_la' as canonical name (possible typo)
from libvmod-querystring.
Dridi
commented on June 3, 2024
Is this fixed by the 2.0.3 release?
from libvmod-querystring.
glensc
commented on June 3, 2024
@Dridi yes, if you read the release notes:
It has:
- "Varnish 6.6 support"
from libvmod-querystring.
e2-robert
commented on June 3, 2024
I failed to build it with Varnish 7.0.
I'm using this Dockerfile (excerpt):
FROM centos:7
# TODO: use stable version (non-master) of varnish-cache, modules and pesi
# TODO: clean up build dependencies, since image has got 1G
ENV VARNISH_SIZE 1G
RUN yum install -y python3 python-sphinx
# Install Varnish
# https://github.com/varnishcache/varnish-cache/releases
RUN fetchDeps=' \
git \
'; \
buildDeps=' \
make \
autoconf \
automake \
libedit-devel \
libtool \
libunwind-devel \
ncurses-devel \
pcre2-devel \
'; yum install -y $fetchDeps $buildDeps \
&& git clone --recursive --depth 1 --branch varnish-7.0.0 https://github.com/varnishcache/varnish-cache /usr/src/varnish-cache \
&& cd /usr/src/varnish-cache \
&& sh autogen.sh \
&& sh configure \
&& make \
&& make install \
&& mkdir /etc/varnish \
&& echo -e 'vcl 4.1;\nbackend default none;' > /etc/varnish/default.vcl
# VMOD querystring (https://github.com/Dridi/libvmod-querystring)
# https://github.com/Dridi/libvmod-querystring/releases (#v2.0.3)
ENV VMOD_QUERYSTRING_VERSION 'v2.0.3'
RUN fetchDeps=' \
git \
'; \
buildDeps=' \
make \
autoconf \
automake \
libtool \
patch \
pkgconfig \
python3-docutils \
'; yum install -y $fetchDeps $buildDeps \
&& git clone --recursive --depth 1 --branch $VMOD_QUERYSTRING_VERSION https://github.com/Dridi/libvmod-querystring.git /usr/src/libvmod-querystring \
&& cd /usr/src/libvmod-querystring \
&& sh bootstrap \
&& make -j "$(nproc)" \
&& make check \
&& make install \
&& rm -rf /usr/src/libvmod-querystringIt fails with the very same error message, namely:
src/Makefile.am:26: error: 'vmod_LTLIBRARIES' is used but 'vmoddir' is undefined
from libvmod-querystring.
Dridi
commented on June 3, 2024
@e2-robert the answers were in the README.
You aren't installing Varnish in the /usr prefix so you need to tell pkg-config about that. For reasons that escape me you are cloning the git repositories instead of downloading already-bootstrapped release archives so you also need to bootstrap it. Again, you need to tell aclocal about the non-/usr prefix where Varnish was installed. The bootstrap script enables warnings and one of them is triggering with gcc on el7 so you need to disable them.
@@ -36,6 +36,8 @@
# VMOD querystring (https://github.com/Dridi/libvmod-querystring)
# https://github.com/Dridi/libvmod-querystring/releases (#v2.0.3)
ENV VMOD_QUERYSTRING_VERSION 'v2.0.3'
+ENV ACLOCAL_PATH=/usr/local/share/aclocal
+ENV PKG_CONFIG_PATH=/usr/local/lib/pkgconfig
RUN fetchDeps=' \
git \
'; \
@@ -50,7 +52,7 @@
'; yum install -y $fetchDeps $buildDeps \
&& git clone --recursive --depth 1 --branch $VMOD_QUERYSTRING_VERSION https://github.com/Dridi/libvmod-querystring.git /usr/src/libvmod-querystring \
&& cd /usr/src/libvmod-querystring \
- && sh bootstrap \
+ && sh bootstrap --disable-warnings \
&& make -j "$(nproc)" \
&& make check \
&& make install \from libvmod-querystring.
Related Issues (20)
- Whitelist functionality HOT 2
- v1.0.1 doesn't compile at all HOT 15
- branch 4.0 filter_except generates garbage URL HOT 3
- Varnish 5 support HOT 2
- 1.0.2 using tar-ball does not build on RHEL 7.3 HOT 7
- Debian Jessie compatibility HOT 4
- Symbol not found: 'querystring.regfilter' HOT 3
- Compile fails with Varnish 5.2 HOT 12
- Compile time warnings on el7 HOT 2
- Release for Varnish 6? HOT 8
- Failing when running /usr/share/varnish-plus/vmodtool.py on varnisn-plus-6 HOT 2
- Compile fails varnish 6.2 HOT 5
- Correct LICENSE and COPYING HOT 1
- Correct LICENSE and COPYING HOT 1
- src build fails with varnish 6.5.0; 'WS_Reserve()' removed HOT 7
- failed build w/ varnish 6.6: " 'VRT_re_fini' undeclared" HOT 3
- Add bootstrap script to release tarball HOT 4
- failed build w/ varnish 7.0: "vmod_querystring.c:589:42: error: passing argument 3 of 'VRE_compile' from incompatible pointer type'" HOT 3
- make install fails on 7.3 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libvmod-querystring.