The phpfmt8 from driade

2 spaces are formatted after the callable type declaration

before format

<?php

class Server
{
    protected array $handlers = [];

    public function withHandler(callable | string $handler): static
    {
        $this->handlers[] = $this->createHandlerItem($handler);

        return $this;
    }
}

after format

<?php

class Server
{
    protected array $handlers = [];

    public function withHandler(callable  | string $handler): static
    {
        $this->handlers[] = $this->createHandlerItem($handler);

        return $this;
    }
}

2 spaces are formatted after the callable type declaration

Typed classes and properties not being saves properly

This is a code breaking bug.

Basically if you have something like this:


class Cache extends BaseConfig
{
    /**
     * --------------------------------------------------------------------------
     * Primary Handler
     * --------------------------------------------------------------------------
     *
     * The name of the preferred handler that should be used. If for some reason
     * it is not available, the $backupHandler will be used in its place.
     */
    public string $handler = 'file';

    /**
     * --------------------------------------------------------------------------
     * Backup Handler
     * --------------------------------------------------------------------------
     *
     * The name of the handler that will be used in case the first one is
     * unreachable. Often, 'file' is used here since the filesystem is
     * always available, though that's not always practical for the app.
     */
    public string $backupHandler = 'dummy';
}

In turn this will be changed into this:

class Cache extends BaseConfig
{
    /**
     * --------------------------------------------------------------------------
     * Primary Handler
     * --------------------------------------------------------------------------
     *
     * The name of the preferred handler that should be used. If for some reason
     * it is not available, the $backupHandler will be used in its place.
     */
    stringpublic $handler = 'file';

    /**
     * --------------------------------------------------------------------------
     * Backup Handler
     * --------------------------------------------------------------------------
     *
     * The name of the handler that will be used in case the first one is
     * unreachable. Often, 'file' is used here since the filesystem is
     * always available, though that's not always practical for the app.
     */
    stringpublic $backupHandler = 'dummy';
}

Enum format error.

before format

<?php

namespace App\Enums;

enum Mq: string
{
    case ORDER_PAYMENT_EXPIRED = 'order-payment-expired';

    public function getExchangeName(Mq $queue)
    {
        return 'ex-'.$queue->value;
    }
}

after format

<?php

namespace App\Enums;

enum Mq:string {
    case ORDER_PAYMENT_EXPIRED = 'order-payment-expired';

        public function getExchangeName(Mq $queue)
    {
            return 'ex-' . $queue->value;
        }
}

Problem with null as variable type

<?php

class B
{
    public int|string $a;
    public null|string $b;
    public ?|string $b;
    public null|\stdClass $b;
}

becomes

<?php

class B
{
    public int|string $a;
    public null|string $b;
    ?public |string $b;
    \stdClasspublic null| $b;
}

Else incorrectly processed

ICollection::ELSE

becomes

ICollection::ELSE{
;
}

Unindenting the break; in the switch statement

I just installed the phpfmt on my latest update of the Sublime Text and I appreciate the developers for the work done thus far.

Some of my switch cases are like this:

switch ($action_to_perform) {
    case 'save_dataload':
        // Code for 'save_dataload' case
        break;
}

but I want to achieve this:

switch ($action_to_perform) {
case 'save_dataload':
    // Code for 'save_dataload' case
break;
}

I didn't find a settings to achieve this, so chat-GPT gave me a custom function to add to C:\Users\Michael\AppData\Roaming\Sublime Text\Packages\phpfmt

<?php

use Fmt\AdditionalPass;

class UnindentSwitchCaseBreak extends AdditionalPass
{
    public function candidate($source, $foundTokens)
    {
        // Check if the source code contains switch statements
        return (bool) strpos($source, 'switch');
    }

    public function format($source)
    {
        // Remove indentation from case and break statements
        $source = preg_replace('/\n(\s*)(case|break)/', "\n$1$2", $source);

        return $source;
    }
}

and I added UnindentSwitchCaseBreak to my [passes section], but it throws this error

[08-Aug-2023 11:00:31 Europe/Berlin] PHP Warning:  Undefined array key "_" in C:\Users\Michael\AppData\Roaming\Sublime Text\Packages\phpfmt\fmt.stub.php on line 3397
[08-Aug-2023 11:00:31 Europe/Berlin] PHP Notice:  fwrite(): Write of 56371 bytes failed with errno=32 Broken pipe in C:\Users\Michael\AppData\Roaming\Sublime Text\Packages\phpfmt\fmt.stub.php on line 3412

This is my settings file

{
    "excludes":
    [
        "PSR2ModifierVisibilityStaticOrder"
    ],
    "passes":
    [
        "UnindentSwitchCaseBreak",
    ],
    "php_bin": "C:/xampp/php/php.exe",

    "switch_case_space" : 1,
}

I am on a windows 11 machine running PHP 8.1.2

Pls help

RemoveSemicolonAfterCurly removes semicolon after match() expression in php8

AutoSemicolon bad inside match

match ($x) {
	$a => function () {
	};
};

$a = function () {
	function () {
	};
};

instead of

match ($x) {
	$a => function () {
	}
};

$a = function () {
	function () {
	}
};

Bad indentation with attributes and missing visibility

class foo
{
    #[JsonSerialize('call it Jackson')]
public string $myValue;

function a()
    {
}
}

instead of

class foo
{
    #[JsonSerialize('call it Jackson')]
    public string $myValue;

    public function a()
    {
    }
}

There is an empty line after the inheritance namespace class

before format

<?php

class Message extends App\Services\Kernel\Message
{

}

after format

<?php

class Message extends App\Services\Kernel\Message

{

}

AutoSemicolon missing semicolon after match if curly is in the last line

match ($x) {
    $a => 1,
    $b => 2,
};

match ($x) {
    $a => 1,
    $b => 2,
}

expected

match ($x) {
    $a => 1,
    $b => 2,
};

match ($x) {
    $a => 1,
    $b => 2,
};

Check what ExternalPass is for

There're references in the code to this "fmt-external.php" call, also seen in phpfmt-next, but it's utility seem to got lost.

default value in match doesn't get correctly aligned

$expressionResult = match ($condition) {
    1, 2   => foo(),
default=> baz(),
};

instead of

$expressionResult = match ($condition) {
    1, 2   => foo(),
    default => baz(),
};

optional arguments, there are space between question mark.

before format

<?php

class Server
{
    protected ServerRequestInterface $request;

    public function __construct(protected Merchant $merchant, ?ServerRequestInterface $request)
    {
        $this->request = $request ?? RequestUtil::createDefaultServerRequest();
    }
}

after format

<?php

class Server
{
    protected ServerRequestInterface $request;

    public function __construct(protected Merchant $merchant,  ? ServerRequestInterface $request)
    {
        $this->request = $request ?? RequestUtil::createDefaultServerRequest();
    }
}

optional arguments, there are space between question mark.

Check T_NAME_FULLY_QUALIFIED

T_NAME_FULLY_QUALIFIED was added in php 8. Check if the formatted needs to use it in any rule

Constant arrays on classes causes all keywords before function to be removed

kokororin/vscode-phpfmt#42

Space after "class" as a named parameter

This

return $action->handle(
    id: intval($id), class: TicketApiClassEnum::from($class)
);

becomes

return $action->handle(
    id: intval($id), class :TicketApiClassEnum::from($class)
);

Correctly align comments inside match

match ($a) {
    1       => 2,
    3       => 4,
// comment
/** comment **/
    default => 5
};

Missing semicolon before last curly

function a()
{
    $this->call()
}

insteadof

function a()
{
    $this->call();
}

Namespaces issues

use Vendor\Package\SomeNamespace\{
    SubnamespaceOne\ClassA,
    SubnamespaceOne\ClassB,
    SubnamespaceTwo\ClassY,
    ClassZ,
};

becomes

use Vendor\Package\SomeNamespace\SubnamespaceTwo\ClassY;

Named Arguments: There are no spaces between parameters and naming

before format

<?php

class Message
{
    protected $merchant;

    public function getMerchant(): Merchant
    {
        if (!$this->merchant) {
            $this->merchant = new Merchant(
                mchId: $this->config['mch_id'],
                serial: $this->config['serial']
            );
        }

        return $this->merchant;
    }
}

after format

<?php

class Message
{
    protected $merchant;

    public function getMerchant(): Merchant
    {
        if (!$this->merchant) {
            $this->merchant = new Merchant(
                mchId:$this->config['mch_id'],
                serial:$this->config['serial']
            );
        }

        return $this->merchant;
    }
}

Add additional tests

Check https://github.com/Shaked/php.tools (already in a branch) and make them work

Add auto semicolon after anonymous class

$instance = new class {}

should become

$instance = new class {};

auto format stops working when using the following sintax

Using typed functions where I want a fallback return or the params will have more than one type it does not work.

Example:

protected function allData(object|null $proposal): object|null
{
    return $proposal;
}

Basically it says that I have a syntax error and it does not run the auto format in this file.

My current local PHP version being used by FMT is the following:

php -v
PHP 8.2.2 (cli) (built: Feb  1 2023 08:33:04) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.2, Copyright (c) Zend Technologies

Space after enum is removed

enumA {
    
}

instead of

enum A {
    
}

not support Class constant visibility modifiers

class Foo {
    public const BAR = 'bar';
    private const BAZ = 'baz';
}

After format

class Foo
{
    const='bar';const='baz';}

RemoveSemicolonAfterCurly removes semicolon in anonymous classes

return new class {

}

instead of

return new class {

};

8.x - Fully qualified namespace not correctly formated

If the class if now a FQN, it formats this way

try {

} catch (Exception $e) {
}

but if we use a FQN the whitespace between the classname and the variable is removed

try {

} catch (\Exception$e) {
}

Add PSR12 standard

https://www.php-fig.org/psr/psr-12/

Issues with formatting of Arrays and Array Access for WordPress Coding Standards

Issues:

As per WordPress Coding Standard, an array should be defined like this: (space at the beginning and closing of parentheses or square brackets)

Source: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#declaring-arrays
As per WordPress Coding Standard, spaces while accessing array items will be like this:

Source: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#space-usage

Please, solve this issue by introducing some configurations regarding "[]" (Square brackets) so that WordPress Developers can write PHP and use the vscode-phpfmt with more ease.

Thank you.

Extra return after curly close when anonymous class

$instance = new class {};

becomes

$instance = new class
{};

default config file still pointing to old plugin

In the settings when I do:

Preferences / Package Settings / Phpfmt-8/default settings

Its still trying to open the phpfmt instead of phpfmt-8 default settings file.

Condition shorthand issue

Before

<?php

class Message
{
    public function test()
    {
        $campaign_data = ['enabled' = false];
        $campaign->status = $campaign_data['enabled'] ? Campaign::STATUS_ACTIVE : Campaign::STATUS_PAUSED;

        return $campaign;
    }
}

After

<?php

class Test
{
    public function test()
    {
        $campaign_data = ['enabled' = false];
        $campaign->status = $campaign_data['enabled']?Campaign::STATUS_ACTIVE: Campaign::STATUS_PAUSED;

        return $campaign;
    }
}

Configs:

{
	"version": 4,
	"php_bin": "/opt/homebrew/opt/php@7.4/bin/php",
	"format_on_save": false,
	"autocomplete": true,
	"autoimport": true,
	"disable_auto_align": true,
	"indent_with_space": true,
	"passes":
	[
		"StripExtraCommaInArray",
		"RemoveSemicolonAfterCurly",
		"NewLineBeforeReturn",
		"AddMissingParentheses",
		"ReindentSwitchBlocks",
		"OrderAndRemoveUseClauses",
		"DocBlockToComment",
		"PSR2EmptyFunction",
		"StripSpaceWithinControlStructures",
		"ShortArray",
		"AutoSemicolon",
		"OrderMethod", // 2023-06-05
		"OrganizeClass", // 2023-06-05
		"OrderMethodAndVisibility", // 2023-06-05
		"SortUseNameSpace", // 2023-06-05
		"SpaceBetweenMethods", // 2023-06-05
		"TrimSpaceBeforeSemicolon", // 2023-06-05
		"DoubleToSingleQuote"
	],
	"psr1": false,
	"psr2": true,
	"smart_linebreak_after_curly": true,
	"visibility_order": true,
	"yoda": false,
}

AutoSemicolon bad semicolon on match

    match ($x) {
        $a => function () {
        };
    }

instead of

    match ($x) {
        $a => function () {
        }
    };

Invalid space between :: and (

Route::namespace ('App\Http\Controllers\Admin\Leads');

instead of

Route::namespace('App\Http\Controllers\Admin\Leads');

PSR2ModifierVisibilityStaticOrder Enum deletes function visibility

enum MyEnum:string {
    case FINISH = 'finish';
        public function a()
    {}
}

instead of

enum MyEnum:string {
    case FINISH = 'finish';
        function a()
    {}
}

Unneeded semicolon added after attribute - Uneeded spaces inside attribute

#[.   \AllowDynamicProperties ];
class foo {
    
}

instead of

#[\AllowDynamicProperties]
class foo {
    
}

Format error with passes

When running cmd:

php fmt.stub.php --psr2 --indent_with_space=4 --passes=SpaceAfterExclamationMark --exclude=PSR2ModifierVisibilityStaticOrder

it prints Could not open input file: xxx/fmt-external.stub.php

Improve AutoSemicolon

Add semicolon in theses cases

$data['total'] = 1
/** comment **/

$data['total'] = 1
// comment

Infinite loop

When formatting

Collection::FOREACH;

We get into an infinite loop

Remove semicolon after default option inside match

 match ($x) {
 	$a => 1,
 	$b => 2,
        default=> true
 };

instead of

 match ($x) {
 	$a => 1,
 	$b => 2,
        default=> true;
 };

AutoSemicolon adds a semicolon inside a match()

$foo = function () {
    match ($x) {
        $a => function () {
        };
    };
};

instead of

$foo = function () {
   match ($x) {
       $a => function () {
       }
   };
};

Class Type declaration, T|null error

before format

<?php

class Application
{
    protected Qrcode|null $qrcode = null;
}

after format

<?php

class Application
{
    |protected Qrcodenull $qrcode = null;
}

Keyword dissapears

Collection::PUBLIC;

becomes

Collection::;

Tried to change to this version of the plugin but auto-format was not working

Basically I uninstalled the other plugin. Installed this one by cloning the repo into the packages folder.

Added the user config file.

Changed the path to php 8.

Format on save was not working and there was no errors in the console.

Environment: Linux

What more info can I give you about the system?

ResizeSpaces Add Coalesce Equal

$a ??= ($b = 4) + 5;

instead of

$a??=($b = 4) + 5;

AutoSemicolon must add semicolon after anonymous class

return new class {

};

insteadof

return new class {

}

Constant arrays on classes causes all keywords before function to be removed (2)

kokororin/vscode-phpfmt#42

PHP 5.6 support

According to php7mar these arre the only issues to fix if we want this tool to work with php 5.6

# nuance
#### /Users/davidfernandez/htdocs/phpfmt8/fmt.stub.php
* funcGetArg
 * Line 863: `				$params = array_slice(func_get_args(), 1);`
 * Line 2215: `			$args = func_get_args();`
 * Line 2240: `			$args = func_get_args();`

Improve AutoSemicolon

This

$a = []

(new

should become

$a = [];

(new

driade / phpfmt8 Goto Github PK

phpfmt8's People

Contributors

Stargazers

Watchers

Forkers

phpfmt8's Issues

Issues:

Recommend Projects

Recommend Topics

Recommend Org