drewdorris / powder Goto Github PK

View Code? Open in Web Editor NEW

15.0 15.0 3.0 9.5 MB

A Spigot plugin which utilizes particles & sound effects to allow for incredibly customizable pictures and animations

License: Other

Java 100.00%

powder's Introduction

👋

powder's People

Contributors

Stargazers

Watchers

Forkers

projectedengg tominous kas-tle

powder's Issues

Move playerdata stuff from ConfigUtil into a separate instantiable class

1.15+ support, new noteblock sounds, changes with Bukkit particle API

https://github.com/Ruinscraft/Powder/blob/master/src/main/java/com/ruinscraft/powder/PowderPlugin.java#L37 will need to be changed

Log Spam from loadAllAttached in ConfigUtil

>.... [13:13:45 WARN]: [Powder] Task #61 for Powder v0.2.1 generated an exception
java.lang.NullPointerException: null
at com.ruinscraft.powder.util.ConfigUtil.loadAllAttached(ConfigUtil.java:841) ~[?:?]
at com.ruinscraft.powder.PowderHandler.lambda$new$0(PowderHandler.java:56) ~[?:?]
at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftTask.run(CraftTask.java:84) ~[patched_1.15.2.jar:git-Paper-105]
at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:452) ~[patched_1.15.2.jar:git-Paper-105]
at net.minecraft.server.v1_15_R1.MinecraftServer.b(MinecraftServer.java:1185) ~[patched_1.15.2.jar:git-Paper-105]
at net.minecraft.server.v1_15_R1.DedicatedServer.b(DedicatedServer.java:430) ~[patched_1.15.2.jar:git-Paper-105]
at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:1112) ~[patched_1.15.2.jar:git-Paper-105]
at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:934) ~[patched_1.15.2.jar:git-Paper-105]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]

It seems it assumes that a playerdata file has already been created on first time loading since PowderHandler triggers loadAllAttached, which relies on a player data file. I did a temp fix for myself by adding the following at 840 of ConfigUtil:

		if (playerDataFile == null) {
			PowderPlugin instance = PowderPlugin.get();
			File file = new File(instance.getDataFolder(), PLAYER_DATA_FILE);
			try {
				file.createNewFile();
			} catch (IOException e) {
				e.printStackTrace();
			}
			playerDataFile = YamlConfiguration.loadConfiguration(file);
			instance.setPlayerDataFile(playerDataFile);
		}

StackOverflowError with /powder help

More BaseComponent comparing to TextComponent issues

Caused by: java.lang.StackOverflowError
	at net.md_5.bungee.api.chat.BaseComponent.equals(BaseComponent.java:17) ~[patched_1.13.2.jar:git-Paper-90772ce8]```

Minecraft /playsound + Powders

It would be cool if there was a section in /powders that allowed players to play default Minecraft sounds and music. This could perhaps be done with the default minecraft /playsound command.

Example syntax: /playsound [sound] player @A[r=?]
This would be the command (with the sound depending on the sound which they choose) which the player would run through the powders menu once they have navigated to the Minecraft section in Powders.

Note: Unsure of the powders radius so I put a question mark for the radius.

Clean up config value placement

Right now, config values are referenced through instance variables in PowderPlugin, through direct retrieving from the config object, or through other methods. Messy and need a cleaner solution

readURL only creates https URL

readURL should be able to use http or https

https://github.com/Ruinscraft/Powder/blob/master/src/main/java/com/ruinscraft/powder/PowderPlugin.java#L510

Some Powders don't "end"

An example; the "Bomb" Powder can be cancelled after it ends

Ability to disable powder effects/sounds until next server restart

Instead of playing effects/sounds to world, play to all users except ones who are added to /powder disable list. Resets on server restart because usually only need to disable for temporary events

Update soundEnum for 1.13+

The soundEnum option in the default powders.yml is using old 1.12 enum values. A lot of them, especially relating to note sounds have broken. There should be some compatibility between 1.12 and 1.13+ here

Stationary Powders can cause hang on load

Import new Note Block Studio files

Music note particle broken in 1.13

addedTilt and addedRotation for PowderMatrices are wonky

source location
addedTilt doesn't keep the shape of the original untilted shape, making it look stretched the further tilted it is:

addedRotation doesn't stay over the head when looking straight down/up:

vs.

Exception error when running on 1.18 paper (fork) server

Tried the async setting on config.yml, but I still get the same error.

17:09:32 ERROR]: Thread Craft Scheduler Thread - 15 - Powder failed main thread check: Chunk getEntities call
java.lang.Throwable: null
	at org.spigotmc.AsyncCatcher.catchOp(AsyncCatcher.java:15) ~[purpur-1.18.2.jar:git-Purpur-1609]
	at net.minecraft.server.level.ServerLevel.getEntities(ServerLevel.java:2435) ~[?:?]
	at net.minecraft.server.level.ServerLevel.getEntity(ServerLevel.java:1872) ~[?:?]
	at org.bukkit.craftbukkit.v1_18_R2.CraftServer.getEntity(CraftServer.java:2482) ~[purpur-1.18.2.jar:git-Purpur-1609]
	at org.bukkit.Bukkit.getEntity(Bukkit.java:1983) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.jar:?]
	at com.ruinscraft.powder.model.tracker.EntityTracker.getEntityLocation(EntityTracker.java:78) ~[Powder-0.2.1(1).jar:?]
	at com.ruinscraft.powder.model.tracker.EntityTracker.refreshLocation(EntityTracker.java:64) ~[Powder-0.2.1(1).jar:?]
	at com.ruinscraft.powder.model.tracker.EntityTracker.<init>(EntityTracker.java:29) ~[Powder-0.2.1(1).jar:?]
	at com.ruinscraft.powder.model.Powder.lambda$1(Powder.java:270) ~[Powder-0.2.1(1).jar:?]
	at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftTask.run(CraftTask.java:101) ~[purpur-1.18.2.jar:git-Purpur-1609]
	at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[purpur-1.18.2.jar:git-Purpur-1609]
	at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[purpur-1.18.2.jar:git-Purpur-1609]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]
[17:09:32 WARN]: [Powder] Plugin Powder v0.2.1 generated an exception while executing task 496
java.lang.IllegalStateException: Asynchronous Chunk getEntities call!
	at org.spigotmc.AsyncCatcher.catchOp(AsyncCatcher.java:16) ~[purpur-1.18.2.jar:git-Purpur-1609]
	at net.minecraft.server.level.ServerLevel.getEntities(ServerLevel.java:2435) ~[?:?]
	at net.minecraft.server.level.ServerLevel.getEntity(ServerLevel.java:1872) ~[?:?]
	at org.bukkit.craftbukkit.v1_18_R2.CraftServer.getEntity(CraftServer.java:2482) ~[purpur-1.18.2.jar:git-Purpur-1609]
	at org.bukkit.Bukkit.getEntity(Bukkit.java:1983) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.jar:?]
	at com.ruinscraft.powder.model.tracker.EntityTracker.getEntityLocation(EntityTracker.java:78) ~[Powder-0.2.1(1).jar:?]
	at com.ruinscraft.powder.model.tracker.EntityTracker.refreshLocation(EntityTracker.java:64) ~[Powder-0.2.1(1).jar:?]
	at com.ruinscraft.powder.model.tracker.EntityTracker.<init>(EntityTracker.java:29) ~[Powder-0.2.1(1).jar:?]
	at com.ruinscraft.powder.model.Powder.lambda$1(Powder.java:270) ~[Powder-0.2.1(1).jar:?]
	at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftTask.run(CraftTask.java:101) ~[purpur-1.18.2.jar:git-Purpur-1609]
	at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[purpur-1.18.2.jar:git-Purpur-1609]
	at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[purpur-1.18.2.jar:git-Purpur-1609]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]
	```

I also tried using a version built from source, but it wouldn't start at all