dreipol / djangocms-spa Goto Github PK

• djangocms_spa version: @73322d
• Django version: 1.11
• Python version: 3.6
• Operating System: -

Description

The class ReCaptchaFormMixin has the following init method:

def __init__(self, *args, **kwargs):
        self.request = kwargs.pop('request', None)
        super(ReCaptchaFormMixin, self).__init__(*args, **kwargs)

Why is the request popped rather then getted from kwargs. This is possibly dangerous if another Mixin or the form itself needs access to the request.

Are there any reason for the pop or should we exchange it with a get?

• djangocms_spa version: f49db45
• Django version: 1.11.11
• Python version: 3.5.5
• Operating System: macOS High Sierra (10.13.4)

Description

Since this is just an arbitrary name used by the client side code, we should add an option to customise these. Possible solutions:

• define the prefix cmp in the settings (probably this is enough for most use cases)
• specify the names for each fieldtype manually in a settings dict or similar
• do nothing and let the user overwrite the function every time he want's to have a custom name

• djangocms_spa version: 0.1.15
• Django version: 1.10
• Python version: 3.5
• Operating System: macOS 10.12

Description

I tried to add djangocms-spa as described. Unfortunately the package has a missing dependency: django-appconf

Quickfix

pip install django-appconf==1.0.2

Todo

Add dependency to pypi package.

• djangocms_spa version: 0.1.20
• Django version: 1.8.18
• Python version: 2.7
• Operating System: macOS High Sierra 10.13.2

Description

Describe what you were trying to get done.
Being trying to integrate the pkg into my djangocms project. Following README.md step-by-step.

Tell us what happened, what went wrong, and what you expected to happen.
Not sure where some of those parts should go. Need help with the initial setup. Please provide a sample project.

What I Did

Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

• djangocms_spa version: 0.1.3
• Django version: 1.11
• Python version: 3.6
• Operating System: macos

Description

The class DjangoCmsMixin is not really a mixin, because it inherits from Model. We have two possibilities here:

1. Renaming DjangoCmsMixin to something like DjangoCmsSPABaseModel
2. Remove Model inheritance
3. A combination -> Renaming and removing the inheritance

With the last option we could guarantee backwards compatibility by creating a "new" class DjangoCmsMixin with a deprecation warning

In the render pool objects are added. Maybe it would be better to register classes and then create a new renderer every time when using it.
djangocms does it this way with its plugin renderers.