dreamerdragon / ped Goto Github PK

While the UG actually states " The name or a substring of the name of the patient you want to look for. It may not be the full name of the patient. Any patient with the entered sub-name could be displayed. It is case-insensitive."

When I entered: searchpatient n/davi or searchpatient n/da, it shows " No patient matching the criteria has been found." but in fact David Li is inside which can be found by
searchpatient n/david. This contradicts the instructions which shows that substring can be used. Perhaps could either modify the UG guideline or change the implementation to match the guideline

editpatient john p/91234567 t/363.2
editpatient john p/91234567 t/- 36

entering the above command give me the error:" Temperature should only contain numbers, and it should be to one decimal place. (E.g. 36.0)"

While the above temperature input is not gonna be given by the user, but if the user mis typed the value and the error shown is actually as above, this is still an inconsistency that didnt really reaport the issue, perhaps can modify the error message?

When I enter the command : addtask d/Remind John to return his bedsheets r/3 dd/20200928 2359
for more than 1 time, it is still added successfully, but same as checking duplicate person, duplicate tasks should be detected as well

This command is still executed despite the room already being empty, the team may consider to show an message to the user instead.

while initroom is meant to initialise the rooms for the first time, however, when i want to add in more rooms or modify the room numbers, there is no way to do this, initroom will simply clears all the previous room data. The team may consider add in the relevant commands for such purposes that may be needed in the real world. Also might need a field to store the address of the room instead of simply a room number.

When i type in the command:
addpatient n/John Doe t/37.1 d/20220910-20210924 p/98765432 a/35
The user may not know the order of that time duration ( backwards or forward) or he might accidently mis type the number,

the error shown is "Period of stay should be in the format YYYYMMDD-YYYYMMDD." which didnt really reflect the error here that might confuse the user, perhaps could specify the error message for this scenario?

when i type searchtask dd/12/1/2021 from the UG as an example, nothing shows up and even the error messages. So confuses me whether this is an actual implementation, perhaps could check this again.

when i entered searchroom r/6.0, the error is actually shown as " Please only enter positive numbers." which actually misaligns with the actual bug, so might be more specific in the message saying it must be an positive integer, in the UG as well, specifying the format

The team might want to keep track of the patients temperature and warn the system if the temperature is too high. The past temperatures should also be recorded to show the trend. The team might want to have a command to list all that are in fever and hence may need extra care.

when i entered: searchpatient tr/35-39 or searchpatient tr/35.1-39 or searchpatient tr/35- 39.0, error is shown which tells me "Temperature range should contain temperature-temperature" but this barely states the issue as 35-39 is a temperature range, or 35 - 39.0 or 35.1 - 39, while the UG states the requirement, the error shown here still mismatches the real issues, what if the user fail to read the UG carefully and obtain such bug, it would be better to tell the specific bug.

When I try to add in two different people with the same name but actually different details, exception is thrown and shows the patient already exists, which in real world application should not be this case, as there are a lot of people with the same name. Perhaps could improve the implementation?

e.g. entering addpatient n/John Doe t/37.1 d/20200910-20210924 p/98765432 a/35

and addpatient n/John Doe t/36.1 d/20200911-20210925 p/68165435 a/31

will give me the error

When I entered initroom 222222, which is a large number that may actually be needed in the real world, however, the app that lags and dies off, maybe this is an issue for my computer, but should state the requirements for the computer to be able to run this as this will definitely be needed in the real world

When i type addtask d/Remind John to return his bedsheets r/3 d d/20200928 2359

the error shows Please only enter positive numbers.

but in fact the error should be d d should be together or dd field is missing, might want consider correcting this as the user may accidentally type an extra space