Combine with built in integration about fronius_solarweb HOT 7 OPEN

Hi, prior to creating this repo I approached the existing repo owners suggesting the two be combined. They preferred keeping it separate. Happy for you to raise it again with them.

from fronius_solarweb.

I had the same thought, yes it would be perfect if they were combined. I suspected they may not want to change theirs, so thought I'd ask if you would consider changing yours to only update any missing data?
This way the existing one is installed to get live data, and your integration if installed as well only adds missing data.

from fronius_solarweb.

I don't know how that would work. Happy to review a PR if you've got a workable solution.

from fronius_solarweb.

Hi 👋!

They preferred keeping it separate.

If I remember correctly, my suggestion was to keep the communication libs (pyfronius and your python-fronius-web) separate as they used a very different tech stack (httpx vs aiohttp, pydantic vs custom parser). I still think this is a good idea so each can individually be updated, tested and be used in other projects.

I do not have any objections to import and use both libraries in the HA core Fronius integration.

That said, the local SolarAPI pyfronius uses does provide historical data as well, however using this endpoint is not implemented currently.

from fronius_solarweb.

I'd be happy if it was incorporated into the core HA fronius integration using @farmio's approach, this repo could then be sunset.

from fronius_solarweb.

Great! @JCalvi are you planning on working on this? I'd be happy to do reviews or answer questions along the way (if I can 🙃).

from fronius_solarweb.

Hi @farmio, no I was just hoping to see some merging of these two projects.
Happy to help test, but coding it was not in my plans.

from fronius_solarweb.