draganbabic / uni-form Goto Github PK

First off I'm new to github so sorry if I'm posting this on the wrong section of this project. But I've noticed a specific behavior that should be revised. When declaring two uni-form's on a page, on the submit of one form, both forms are validated. This means that pages with a register and login form (for example) will not pass validation unless all registration and login infos are added.

A simple fix would be to scope down the validation (and search of inputs) to the focuses form instead of the entire page. Should also make the validation more efficient.

I don't dare making the change myself because I don't know if i can/don't know how :) Again, please let me know if I should submit this somewhere else.

Thanks.

Running the latest from the repo.
I believe I'm in jQuery.noConflict mode, so there's no global $, just jQuery. When I fire $('.whatever.').uniform(), I run into errors on the second line here:

form.find(settings.field_selector).each(function () {
        var $input = $(this),

Looking through the rest of this plugin, you use jQuery instead of $, so I think this was just an oversight. If I globalize $ before calling .uniform(), the issue goes away.

Readme says it contains info on how to initialize, but that info is missing!

I don't want to download the repo in order to see static demo files...
you can use gh-pages which is hosting for free

When using the script in a spring based application which might have nested objects as form fields; we have to use the notation as follows

        <spring:bind path="demographicInfo.gender">
          <c:forEach var="gender" items="${genderList}">
            <li><label for=""><input name="demographicInfo.gender" type="radio" class="required" value="${gender}">${gender.gender}</input></label></li>
          </c:forEach>
        </spring:bind>

this currently fails for the validation plugin required method

        if (field.is(':radio')) {
            name = field.attr('name');
            if ($("input[name=" + name + "]:checked").length) {
                return true;
            }
            return i18n('req_radio', caption);
        }
        if (field.is(':checkbox')) {
            name = field.attr('name');
            if (field.is(":checked")) {
                return true;
            }
            return i18n('req_checkbox', caption);

I changed the method to add this snippet

        var name;
        if (field.is(':radio')) {
            var rawName = field.attr('name');
            if (~rawName.indexOf('.')) {
                console.log("escaping . chanracter");
                name = rawName.replace(".", "\\.");
                console.log(name);
            } else
                name = rawName;
            if ($("input[name=" + name + "]:checked").length) {
                return true;
            }
            return i18n('req_radio', caption);
        }
        if (field.is(':checkbox')) {
            if (field.is(":checked")) {
                return true;
            }
            return i18n('req_checkbox', caption);
        }

Not sure if this is the best way to do it; but this support should be there IMHO. Also the expression name = field.attr('name') is unnecessary in the if block for checkbox.