dr-skot / oscp5 Goto Github PK

What steps will reproduce the problem?
I try to send some image data from a client to server. both use the oscp5 lib 
(0.9.8). this is the sending part:

------
  OscMessage myMessage = new OscMessage("/OSC_GENERATOR");

  byte[] bfr = new byte[4096];
//  int[] bfr = new int[4096];
  myMessage.add(bfr); /* add an int array to the osc message */
print("snd");
  /* send the message */
  oscP5.send(myMessage, myRemoteLocation); 
println("dne");

------

What is the expected output? What do you see instead?
not an exception, if i use a byte array I see the error

### [2013/2/4 19:32:12] ERROR @ UdpServer.run() ArrayIndexOutOfBoundsException: 
 java.lang.ArrayIndexOutOfBoundsException

if i use an int array, nothing is visible.

What version of the product are you using? On what operating system?
osx 10.8

Please provide any additional information below.
I checked with wireshark that packets are sent.

ArrayIndexOutOfBoundsException occurs when using OSC-Bundle via TCP.

What steps will reproduce the problem?

see attached oscP5bundleTcp.pde file.
1. Initialize oscP5 for TCP
2. Send OSC-Bundle to the server
3. The server occurs ArrayIndexOutOfBoundsException when parsing OSC-Bundle


What is the expected output? What do you see instead?

the expected output is OSC-Bundle was parsed normally.
following error occurs instead.

### EXCEPTION java.lang.ArrayIndexOutOfBoundsException
### [2012/6/17 7:46:7] PROCESS @ TcpClient.dispose TcpClient closed.
### [2012/6/17 7:46:7] PROCESS @ TcpServer removing TcpClient.
### [2012/6/17 7:46:7] PROCESS @ TcpClient.dispose TcpClient closed.


What version of the product are you using? On what operating system?
0.9.8


Please provide any additional information below.

attached oscP5bundleTcp.pde file is a code to represent the issue,
and OscPatcher.java is a version of fix the issue.

What steps will reproduce the problem?
1. install oscPS
2. open the "Broadcast Tester" example
3. try to run it

What is the expected output? What do you see instead?

The example doesn't compile because it needs another library, controlP5.

The most basic examples provided with a library should not depend on other 
libraries unless strictly necessary.
If that is the case (i.e. it's necessary), then you should consider to either:
- distribute both libraries in a single bundle, or
- mention this dependency in the readme and in the official library webpage, so 
that the user installing the library knows that it depends on another in order 
to be able to run even the basic examples.

Nothing is said about this dependency anywhere. One figures out when compiling 
the example fails.

What version of the product are you using? On what operating system?
http://www.sojamo.de/libraries/oscp5/download/oscP5-0.9.9.zip
on Ubuntu 14.04 with processing 2.1.1

Please provide any additional information below.

The oscP5 library is useful outside of Processing as well. By adding a pom.xml 
file, the library could be universally useful for other people to include in 
their projects using Maven.

I've included an example pom.xml file for the project that could be used to 
deploy to Maven central. Further instructions for deploying to the Central 
Repository are here: 
http://maven.apache.org/guides/mini/guide-central-repository-upload.html

What steps will reproduce the problem?
1. Create a new OscP5 instance in TCP mode: tcp = new OscP5(this, TCP_PORT, 
OscP5.TCP);
2. Try to list the listeners: println(tcp.tcpServer().getListeners());
3. TaDa! Exception in thread "Animation Thread" java.lang.NullPointerException
    at netP5.TcpServer.getListeners(Unknown Source)

What is the expected output? What do you see instead?
I would expect to listeners list to be printed. I would want to listen for 
event and status updates,
especially when a new TcpClient connects. I have yet to find a way to do so.

What version of the product are you using? On what operating system?
OscP5 0.9.8 on OSX 10.8.4

Please provide any additional information below.
I'd like to simple have a callback/event when a new TcpClient connects to a 
TcpServer using the above constructor.

I would like to use the OscP5 library in java code that does not have a 
dependency on Processing.

OscP5 works fine when constructed like

OscP5 oscP5 = new OscP5(new Object(), ...);

If a new constructor

public OscP5(final OscProperties properties)

were added without the if (parent instanceof PApplet) check and references to 
the parent field in OscP5.java were null-checked, I don't believe a runtime 
dependency on Processing would be necessary.