dpc / async-readline Goto Github PK

• restore normal mode on exit (on drop)
• ability to finish the
• detect Ctrl+C, Ctrl+D and pass to the user #1
• arrow keys support
• Windows support #3
• detect TTY fallback to non-interactive mode

Afterwards:

• history
• some form of autocompletion

Hello @dpc , I am wondering if we could publish the current master as 0.1.0 on crates.io.

Although this is currently only a prototype, and there are many desirable fixes and improvements we can make on current codebase to make it better suited for a public release, it would be beneficial for crates that current depends on current master:

• To remove the dependency on this particular git repository (deleting current git repo would not cause issue for exsiting user)
• To facilitate publishing crates in alternative repositories (currently it does not play nice with respect of alternative repo)

Is this possible to do, or is there any better alternatives now?

When I run cargo run --example readline and then press Ctrl-C or Ctrl-D, nothing happens.

I think this is missing the check for zero in lib.rs:127.

From the linux man page:

On success, the number of bytes read is returned (zero indicates end of file)

• https://linux.die.net/man/2/read

I tried simply returning an Err::new(UnexpectedEof, ...) but that gets ignored. I'm not sure how to tell tokio to handle errors here but maybe you know :)

Currently depends on std::os::unix

Thank you for this awesome work/proof of concept!

There's a discussion at rustyline, which is basically a more-or-less complete readline library without async support.

It would be terrific to port the work you have done here to rustyline, such that people can benefit from getting the tight tokio/readline integration!

I am very willing to help, but I don't think I'm really able to do it on my own :-)