double-great / theme Goto Github PK

View Code? Open in Web Editor NEW

11.0 11.0 3.0 2.32 MB

💅 Jekyll theme for doublegreat.dev

Home Page: https://doublegreat.dev/theme/

Ruby 2.92% HTML 50.43% JavaScript 3.25% SCSS 43.13% Shell 0.27%

jekyll-theme

theme's People

Contributors

Stargazers

Watchers

Forkers

aliou fastidious

theme's Issues

Create custom 404 page

It should be very cool, ideally.

Replace Inter webfont with a modern system font stack

via https://modernfontstacks.com/

Add post-list and post-list-cards to styleguide

Use GitHub release to better version theme

Right now we use whatever is on the main branch to build the site.

remote_theme: double-great/great-great-jekyll-theme@main

Instead, we could create releases via GitHub to better version the site's theme:

remote_theme: double-great/[email protected]

This would also allow us to keep a changelog via release.

Our new process for release could look like:

npm version <major|minor|version>
git push --tags
Create new release via https://github.com/double-great/great-great-jekyll-theme/releases
Update the remote_theme value to reference the tag number in each dependent site.

@jsnmrs what do you think? Example of this in use: https://github.com/katydecorah/theme/releases

Add `img { max-width: 100% }`

Rename this repository to just `theme`

We could save a few characters by renaming this repository to theme. Not urgent, but cleaner and easier to type!

Add favicon

We should add a default favicon that can be included in the theme (but overridden if defined by the site)

Dark and high contrast themes

We should explore dark and high contrast themes.

Icons in site title are not perfectly vertically centered

Create color themes

Would be great to have a couple theme options for different sites:

Default: blue
Pink
Purple
Green

jekyll-seo prevents generation of site

Hello! Following #34, I tried installing great-great-jekyll-theme in a new Jekyll blog. However, I run into this issue:

Liquid Exception: Liquid syntax error (/private/var/folders/2w/pnktcdh12h90f262tg8b9f1c0000gn/T/jekyll-remote-theme-20201218-32417-1kt0xth/_includes/head.html line 4):
Unknown tag 'seo' included in /private/var/folders/2w/pnktcdh12h90f262tg8b9f1c0000gn/T/jekyll-
remote-theme-20201218-32417-1kt0xth/_layouts/default.html
bundler: failed to load command: jekyll (/usr/local/var/rbenv/versions/2.6.6/bin/jekyll)
...
/usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/document.rb:23:in `unknown_tag':
Liquid syntax error (/private/var/folders/2w/pnktcdh12h90f262tg8b9f1c0000gn/T/jekyll-remote-theme-20201218-32417-1kt0xth/_includes/head.html line 4):
Unknown tag 'seo' included  (Liquid::SyntaxError)

Full backtrace:

$ bundle exec jekyll build --trace
Configuration file: /Users/alioudiallo/code/tmp/test/_config.yml
      Remote Theme: Using theme double-great/great-great-jekyll-theme
            Source: /Users/alioudiallo/code/tmp/test
       Destination: /Users/alioudiallo/code/tmp/test/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
      Remote Theme: Using theme double-great/great-great-jekyll-theme
       Jekyll Feed: Generating feed for posts
  Liquid Exception: Liquid syntax error (/private/var/folders/2w/pnktcdh12h90f262tg8b9f1c0000gn/T/jekyll-remote-theme-20201218-32980-ic04yp/_includes/head.html line 4): Unknown tag 'seo' included in /private/var/folders/2w/pnktcdh12h90f262tg8b9f1c0000gn/T/jekyll-remote-theme-20201218-32980-ic04yp/_layouts/default.html
bundler: failed to load command: jekyll (/usr/local/var/rbenv/versions/2.6.6/bin/jekyll)
Traceback (most recent call last):
        69: from /usr/local/var/rbenv/versions/2.6.6/bin/bundle:23:in `'
        68: from /usr/local/var/rbenv/versions/2.6.6/bin/bundle:23:in `load'
        67: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/exe/bundle:37:in `'
        66: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/lib/bundler/friendly_errors.rb:130:in `with_friendly_errors'
        65: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/exe/bundle:49:in `block in '
        64: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/lib/bundler/cli.rb:24:in `start'
        63: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
        62: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/lib/bundler/cli.rb:30:in `dispatch'
        61: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
        60: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
        59: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
        58: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/lib/bundler/cli.rb:497:in `exec'
        57: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/lib/bundler/cli/exec.rb:28:in `run'
        56: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/lib/bundler/cli/exec.rb:63:in `kernel_load'
        55: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.2.0/lib/bundler/cli/exec.rb:63:in `load'
        54: from /usr/local/var/rbenv/versions/2.6.6/bin/jekyll:23:in `'
        53: from /usr/local/var/rbenv/versions/2.6.6/bin/jekyll:23:in `load'
        52: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/exe/jekyll:15:in `'
        51: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/mercenary-0.4.0/lib/mercenary.rb:21:in `program'
        50: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/mercenary-0.4.0/lib/mercenary/program.rb:44:in `go'
        49: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `execute'
        48: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `each'
        47: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `block in execute'
        46: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/commands/build.rb:18:in `block (2 levels) in init_with_program'
        45: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/command.rb:91:in `process_with_graceful_fail'
        44: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/command.rb:91:in `each'
        43: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/command.rb:91:in `block in process_with_graceful_fail'
        42: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/commands/build.rb:36:in `process'
        41: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/commands/build.rb:65:in `build'
        40: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/command.rb:28:in `process_site'
        39: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/site.rb:80:in `process'
        38: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/site.rb:210:in `render'
        37: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/site.rb:530:in `render_docs'
        36: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/site.rb:530:in `each_value'
        35: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/site.rb:531:in `block in render_docs'
        34: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/site.rb:531:in `each'
        33: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/site.rb:532:in `block (2 levels) in render_docs'
        32: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/site.rb:547:in `render_regenerated'
        31: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/renderer.rb:63:in `run'
        30: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/renderer.rb:93:in `render_document'
        29: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/renderer.rb:163:in `place_in_layouts'
        28: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/renderer.rb:194:in `render_layout'
        27: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/renderer.rb:131:in `render_liquid'
        26: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/liquid_renderer/file.rb:36:in `render!'
        25: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/liquid_renderer/file.rb:70:in `measure_time'
        24: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/liquid_renderer/file.rb:37:in `block in render!'
        23: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/liquid_renderer/file.rb:63:in `measure_bytes'
        22: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/liquid_renderer/file.rb:38:in `block (2 levels) in render!'
        21: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/liquid_renderer/file.rb:59:in `measure_counts'
        20: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/liquid_renderer/file.rb:39:in `block (3 levels) in render!'
        19: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/template.rb:220:in `render!'
        18: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/template.rb:207:in `render'
        17: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/template.rb:242:in `with_profiling'
        16: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/template.rb:208:in `block in render'
        15: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/block_body.rb:91:in `render'
        14: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/block_body.rb:103:in `render_node_to_output'
        13: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/tags/include.rb:206:in `render'
        12: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/context.rb:123:in `stack'
        11: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/tags/include.rb:208:in `block in render'
        10: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/inclusion.rb:15:in `render'
         9: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/liquid_renderer/file.rb:12:in `parse'
         8: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/liquid_renderer/file.rb:70:in `measure_time'
         7: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/jekyll-4.2.0/lib/jekyll/liquid_renderer/file.rb:13:in `block in parse'
         6: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/template.rb:116:in `parse'
         5: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/template.rb:132:in `parse'
         4: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/document.rb:5:in `parse'
         3: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/document.rb:10:in `parse'
         2: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/block_body.rb:32:in `parse'
         1: from /usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/document.rb:11:in `block in parse'
/usr/local/var/rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/liquid-4.0.3/lib/liquid/document.rb:23:in `unknown_tag': Liquid syntax error (/private/var/folders/2w/pnktcdh12h90f262tg8b9f1c0000gn/T/jekyll-remote-theme-20201218-32980-ic04yp/_includes/head.html line 4): Unknown tag 'seo' included  (Liquid::SyntaxError)

It seems like Liquid doesn't know the seo tag when generating a layout including the head include.

I tried directly adding the jekyll-seo plugin in the jekyll_plugins block in the Gemfile and in the array of plugins in _config.yml but I have the same issue.

I took a look at the double-great.github.io which uses the theme but I can build the blog locally without any issue.

Do you know if I'm missing something to make this work with a new blog?

Thanks!

Improve site navigation

I'd love to find a more elegant site navigation solution. Our current solution is robust, however it causes the page to shift.

📝 Document config and page/post options in README.md

Examples

logo
show_excerpts
list_type

Add a cards list option for home page

This is used by the Feedback Library

Add `stylelint-config-prettier`

The styelintrc should extend stylelint-config-prettier to avoid styling conflicts

https://github.com/double-great/great-great-jekyll-theme/blob/4e42cda0e0d4e25a69dd1fdedfd0b0268eb33ae5/.stylelintrc#L2

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.