Code Monkey home page Code Monkey logo

Comments (8)

dom111 avatar dom111 commented on May 27, 2024 1

I've updated this to be just remove jQuery dependency.

The comment about gLightbox is a useful jump-off point to save rebuilding lightbox functionality!

from webdav-js.

dom111 avatar dom111 commented on May 27, 2024 1

@chrysn I've got an updated version that is hopefully working with most functionality. I've not tested hugely, but I think I've got it working on the basics:

javascript:["https://cdn.jsdelivr.net/gh/dom111/webdav-js@feature%2Fconvert-to-modules/assets/css/style-min.css","https://cdn.jsdelivr.net/gh/dom111/webdav-js@feature%2Fconvert-to-modules/src/webdav-min.js"].forEach((function(e,t){/css$/.test(e)?((t=document.createElement("link")).href=e,t.rel="stylesheet"):(t=document.createElement("script")).src=e,document.head.appendChild(t)}));

from webdav-js.

dom111 avatar dom111 commented on May 27, 2024

This is a good idea for sure and would reduce the overhead. jQuery is used extensively in the main module so it'd be worthwhile rewriting that functionality as well for sure!

from webdav-js.

chrysn avatar chrysn commented on May 27, 2024

Is there a short bookmarks-bar-style JS snippet with which I could test this branch? The README of feature/30-remove-jquery-dependency still imports jQuery.

from webdav-js.

dom111 avatar dom111 commented on May 27, 2024

@chrysn

Is there a short bookmarks-bar-style JS snippet with which I could test this branch?

I'm afraid I'm still not much closer to that point, but I've re-worked this under a new branch of feature/convert-to-modules (which forked from feature/30-remove-jquery-dependency. I'm not sure when I'll have time to work on this again, but as soon as there's a testable version, I'll update here.

Thanks for your interest!

from webdav-js.

chrysn avatar chrysn commented on May 27, 2024

Thanks! I've tested it on viewing only (my WebDAV server is read-only), but there it rendered all directory listings well, including a bunch of exotic character cases.

from webdav-js.

dom111 avatar dom111 commented on May 27, 2024

Hey @chrysn, I've made a few more changes (quite a few actually!) it should properly handle errors now and let you know what was wrong. If you have time to test, that would be great!

javascript:["https://cdn.jsdelivr.net/gh/dom111/webdav-js@feature/convert-to-modules/assets/css/style-min.css","https://cdn.jsdelivr.net/gh/dom111/webdav-js@feature/convert-to-modules/src/webdav-min.js"].forEach((function(e,s){/css$/.test(e)?((s=document.createElement("link")).href=e,s.rel="stylesheet"):(s=document.createElement("script")).src=e,document.head.appendChild(s)}));

from webdav-js.

dom111 avatar dom111 commented on May 27, 2024

Fixed in v2.0.0!

from webdav-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.