Comments (3)
I figured out this was caused by a missing <!-- at the end of the scripts, which was being used as a hack to hide the existing static page.
A more rigorous approach would be to use the tag at the end of the HeaderName file, and a closing tag in the ReadmeName file.
This means when javascript is switched off, the page still works.
from webdav-js.
Hey there,
Thanks for the valuable feedback! The examples provided are just provided as-is for a starting point rather than a fully fledged integration so, yeah, definitely a hack to make it look 'right' without much in the way of configuration.
Sounds like a sensible idea to me, also potentially just obliterating the DOM entirely would be another option, but I was worried about lack of flexibility (lets say you wanted to display a disclaimer or whatever in the Header) afforded by those options. If you have time would you mind having a go at those changes and setting up a PR? If not I'll come back to take a look at this as time allows.
Thanks for your kind words too!
Dom
from webdav-js.
We can just clear an existing body with:
console.log("Clear existing body if any")
document.body.innerHTML = ""
from webdav-js.
Related Issues (20)
- Wishlist: Display Folder Path at Top HOT 2
- Propfind Not Allowed: Fall back to regular link
- Add copy/move
- Use XMLHttpRequest for file uploads (PUT method) to show progress indicator HOT 4
- Deleting a file which was not overwritten leaves an entry behind
- Online PWA app that can work with CORS
- MOVE not working on Apache
- Bug, critical: PROPFIND requires for Depth header HOT 8
- [discussion] github.com/perry-mitchell/webdav-client
- [Bug] IIS error when click on back button <-
- Customize dav root
- Chrome extension HOT 1
- Detect if the current URL has a WebDAV share HOT 2
- nginx example non-functional
- Creating Directory, Uploading File & Refresh HOT 2
- MOVE WebDav Vert not working IIS HOT 2
- Enhancement: thumbnails support HOT 15
- Add plugin mechanism
- Convert to TypeScript and replace webpack with esbuild HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webdav-js.