Comments (8)
ruebot
commented on July 18, 2024
1
I've put the torstar account on pause until we can figure this one out since it's putting out so many false positives.
from diffengine.
edsu
commented on July 18, 2024
1
That's a wise move. Definitely leaving it open because I bet we run up against this type of issue with other sites.
from diffengine.
edsu
commented on July 18, 2024
Should be interesting to compare Python readability with the JavaScript version that it is based on.
from diffengine.
ruebot
commented on July 18, 2024
Weird. I just ran the above, and I get:
<html><body><div><div class="nav-news-content" data-reactid="411"><h3 class="nav-news-headline" data-reactid="412"><span class="nav-news-category" data-reactid="413"/>The Good Wife spinoff The Good Fight takes on Donald Trump</h3><p class="nav-news-abstract show-for-medium-up" data-reactid="415">The Good Fight will feature themes critical about the new presidency as well as satirize the Liberal reaction. Trump seems to take opposition by entertainers more seriously than traditional press coverage, creator Robert King says</p></div></div></body></html
If I view the source of https://www.thestar.com/news/world/2017/01/11/uk-teen-charged-with-murder-of-7-year-old-girl.html I see that text in a large chunk of JavaScript here ...or just ctrl+F "Good Wife"
from diffengine.
ruebot
commented on July 18, 2024
Run the same thing a few minutes later and I get:
<html><body><div><div class="nav-news-content" data-reactid="411"><h3 class="nav-news-headline" data-reactid="412"><span class="nav-news-category" data-reactid="413"/>Late-night hosts mock Trump for calling Meryl Streep ‘overrated’ on Twitter </h3><p class="nav-news-abstract show-for-medium-up" data-reactid="415">On Jimmy Kimmel Live, there was an exchange between Ben Affleck and Kimmel about Trump's tweet with Affleck saying 'if you look up in the encyclopedia ‘great actress,’ it’s a picture of Meryl Streep.’ </p></div></div></body></html>
from diffengine.
edsu
commented on July 18, 2024
Wild. I guess now we know why we're getting the diffs. What the heck is going on? Could they be serving advertisements randomly to people?
from diffengine.
ruebot
commented on July 18, 2024
Looks like it isn't actually grabbing the body consistently. I'm not seeing a way to really tweak Readability either.
.content() is going to return too much, and lead to more false positives, right?
from diffengine.
ruebot
commented on July 18, 2024
@edsu I think things have resolved themselves for the most part with the recent commits. What we were seeing before is now coming through like this tweet: https://twitter.com/torstar_diff/status/842119916958453762 -- So, maybe resolving #28 might fully resolve this issue?
from diffengine.
Related Issues (20)
- Photo changes HOT 1
- Can we use it for personal use only? HOT 3
- Info HOT 1
- pip 19 breaks install HOT 14
- Error message: WARNING - not tweeting without archive urls HOT 8
- SavePageNow 503 Service Unavailable HOT 1
- Link to Wayback Diff? HOT 3
- Unable to complete setup HOT 1
- 'EntryVersion' object has no attribute 'save_url' HOT 2
- Screenshot truncated
- Python code formatter integration HOT 4
- Change summary lang key default value to "the page" HOT 2
- Make `time.sleep` configurable and default to zero
- Remove Entry.blogged HOT 1
- Database migrations HOT 1
- Why tweet_status_id_str on EntryVersion and not Diff? HOT 1
- Avoid messages per entry from the handlers when they're not configured
- exceptions directory not copied during setup HOT 3
- update_with_media deprecated
- Interested in getting this project running. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from diffengine.