Code Monkey home page Code Monkey logo

Comments (14)

edsu avatar edsu commented on July 18, 2024 2

This has gone on long enough. I guess we'll just fork it.

from diffengine.

edsu avatar edsu commented on July 18, 2024 1

Yes, it does look like the python3 support was merged, but it was never pushed to PyPI. I guess I can open a ticket on the htmldiff repository to ask for a new release. I'm not sure @mitsuhiko will notice it here...

from diffengine.

edsu avatar edsu commented on July 18, 2024

I actually forgot about --process-dependency-links when I was re-creating my environment with pip v19.3.1. I noticed that I get a build error about failing to remove htmldiff's build directory:

ERROR: Failed cleaning build dir for htmldiff

... but that the tests pass just fine, as they also do on Travis (which doesn't do --process-dependency-links).

So I wonder if we can remove that part of the diffengine documentation?

from diffengine.

maehr avatar maehr commented on July 18, 2024

I failed to install it via pip3 install --process-dependency-links diffengine on osx 10.14.6 and python 3.7.5. (And I guess travis does not use the latest pip version.) Shall I investigate further?

from diffengine.

edsu avatar edsu commented on July 18, 2024

Sorry, I guess I wasn't clear. Try without the --process-dependency-links.

from diffengine.

maehr avatar maehr commented on July 18, 2024

That didn't work either.

Collecting htmldiff==0.2 (from diffengine)
  Could not find a version that satisfies the requirement htmldiff==0.2 (from diffengine) (from versions: 0.1)
No matching distribution found for htmldiff==0.2 (from diffengine)

from diffengine.

edsu avatar edsu commented on July 18, 2024

Oh, I was actually doing a pip install -r requirements.txt which is what Travis does as well. But this isn't useful for people who don't have a git clone of the repo--which is most people.

from diffengine.

edsu avatar edsu commented on July 18, 2024

Maybe this is tilting at windmills, but the solution I'd like to aim for here is to get htmldiff in shape so it can be installed properly.

from diffengine.

maehr avatar maehr commented on July 18, 2024

Tell me how I can help you to fix htmldiff.

from diffengine.

edsu avatar edsu commented on July 18, 2024

diffengine usings python3 and there was a small problem with htmldiff that prevented it from running on python3 edsu/htmldiff@a2ae66b

If that problem has been fixed upstream diffengine's requirements can just be pointed at that, and I believe --process-dependency-links can go away. Would you be willing to check on that?

from diffengine.

maehr avatar maehr commented on July 18, 2024

@mitsuhiko can you release a new version to the PyPi repo https://pypi.org/project/htmldiff/ ? @edsu I guess this would fix the problem?

from diffengine.

maehr avatar maehr commented on July 18, 2024

@edsu how about integrate the htmldiff source directly? For the license check https://github.com/mitsuhiko/htmldiff/blob/master/LICENSE

from diffengine.

weitzman avatar weitzman commented on July 18, 2024

Still broken, fyi.

from diffengine.

edsu avatar edsu commented on July 18, 2024

@weitzman it would be helpful if you could also comment over on mitsuhiko/htmldiff#7 to try to move this along without us forking or copying the code.

from diffengine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.