dnowacki-usgs / nwis Goto Github PK

nwis has almost everything I like in a package:

• single purpose
• simple and direct
• well written and easy to read/hack on it

However, the name of the function, nwis_json, has json on it but the default return is a pandas DataFrame. There is also an option to change that to a xarray Dataset. That is quite confusing and I would like to propose to return only the JSON and add to extra functions to perform the conversion. To be 100% honest I would be OK with only the json return I would deal with the conversions myself but I can see how users will want that build in.

What do you think @dnowacki-usgs?
I think it is an overkill but I would be OK with a class that has the json and the two methods to convert.

There is only a binary wheel on PyPI and no tags on GitHub. It would be nice to get a source distribution tagged/published so downstream packagers can use this.