dmt021 / btceapi Goto Github PK

@@ -270,7 +270,7 @@ private static string QueryIgnoreInvalid(string method, BtcePair[] pairlist, Dic
{
var newargs = new Dictionary<string,string>() { {"ignore_invalid", "1"} };
if (args != null)

•            newargs.Concat(args);
  

•            newargs = newargs.Union(args).ToDictionary(k => k.Key, v => v.Value);
       return Query(method, pairlist, newargs);
   } 
  

Is there a recommended way to check to see if a trade is complete? I was thinking you would place an order, keep the resulting OrderID, and then check the TradeHistory for the OrderID to appear.

THis code returns empty list:
List = o.OfType<KeyValuePair<string, JToken>>().ToDictionary(item => int.Parse(item.Key), item => Order.ReadFromJObject(item.Value as JObject))

I recomend replace to:
List = ((ICollection<KeyValuePair<string, JToken>>)o).ToDictionary(item => int.Parse(item.Key), item => Order.ReadFromJObject(item.Value as JObject))

To the guys that have developed this: Thank you. It looks really good but I am having a problem with the GetTradeHistory() and GetTransHistory().

When I call these methods: var transHistory = btceApi.GetTransHistory();

I can see that all the records have been retrieved from BTC-e : example below.

result = {
"success": 1,
"return": {
"12345698746632": {
"type": 4,
"amount": 10.79682553,
"currency": "BTC",
"desc": "Bought 1093.93204463 PPC from your order :order:111888285: by price
.......

However after the return statement :

 return TransHistory.ReadFromJObject(result["return"] as JObject);

 There are no records returned:   List = Count = 0

I cannot for the life of me work it out. Have spend several hours on this but I'm stumped.

Any advice would be greatly appreciated. Thank you muchly. Pete.

PS. in Funds.cs there are some typos for the currency codes:

            Btc = o.Value<decimal>("btc"),
            Ltc = o.Value<decimal>("ltc"),
            Nmc = o.Value<decimal>("ntc"),   <---Should be nmc
            Nvc = o.Value<decimal>("nvc"),
            Trc = o.Value<decimal>("trc"),
            Ppc = o.Value<decimal>("ppc"),
            Ftc = o.Value<decimal>("Ftc"),   <---Should be ftc
            Usd = o.Value<decimal>("Usd"),   <---Should be usd
            Rur = o.Value<decimal>("rur"),
            Eur = o.Value<decimal>("eur")

The current implementation is not compatible with the requirements for Windows 8 apps. There are some references that don't exist in the Metro API.

Case in point would be Query(string url), which uses HttpWebRequest. There is no GetResponse() anymore, but instead only an asynchronous BeginGetResponse() that requires a callback when the operation completes.

Supporting an asynchronous model would be helpful.

[email protected]

The data returned from the server is failing to properly parse at this function:
public static TransHistory ReadFromJObject(JObject o)

Hi -- is this project still alive.

It's broken in that there are a number of bugs, and the usage of JSON.NET is wrong (it should be using JsonProperty attributes, rather than the ReadFromJObject calls that are on the DTOs).

I'm happy to fix it if you'll allow pull requests, otherwise I'll just start again?

Thanks,
Matt

https://luuquocviet79.github.io/BtceApi/

Wrong keys for read fonds

            Nmc = o.Value<decimal>("ntc"),
            Ftc = o.Value<decimal>("Ftc"),
            Usd = o.Value<decimal>("Usd"),

A call to getingo gets me the correct balance for BTC, LTC but I get zero for NMC.

Thank you very much for your BTC-e API. I'd like to use your work but I cannot see under which license you published your code? Please select a license for your code.

Some pointers regarding OSS licenses:

https://help.github.com/articles/open-source-licensing
http://www.techrepublic.com/blog/web-designer/choosing-an-open-source-software-license-for-your-development-project/

Thanks for a great API!

Api cho btc-e.com