Code Monkey home page Code Monkey logo

Comments (8)

dmsurti avatar dmsurti commented on June 18, 2024

@jirisamek I am working on a fix for this problem, thanks for reporting this. See PR #59. I think I may have to split the elements into smaller buffers internally, as this fix works for #56, but right now not for #58; but this is the correct fix with more implementation tweaks required for your case.

Are you OK with me using the model you have provided as part of AssimpKit test cases? The AssimpKit licenses explicitly mention the usage of such files only for testing purpose. Let me know. Thanks!

from assimpkit.

jirisamek avatar jirisamek commented on June 18, 2024

@dmsurti thank you very much for quick response. The model is not mine. I have downloaded it from https://free3d.com/3d-model/cyprys-house-23761.html, and the licence tag says: "Commercial use License". I didn't find actual text of license so I don't know if it is possible to use it in open source as model in test cases. Also this specific dae seems to have broken textures/materials.

from assimpkit.

dmsurti avatar dmsurti commented on June 18, 2024

Fixed in #59. In addition to mallocing scene buffers, it also requires ignoring the faces which are not triangulated!

This model contains material colors and/or embedded textures, which is being fixed in #62 and #64.

screenshot 2017-09-01 15 48 41

from assimpkit.

dmsurti avatar dmsurti commented on June 18, 2024

With #64, the house now has textures as well.

Also this specific dae seems to have broken textures/materials.

@jirisamek Actually this file has all colors for material properties, #64 ensure correct texture and colors are applied to material properties.

screenshot 2017-09-02 18 06 24

from assimpkit.

azolyoung avatar azolyoung commented on June 18, 2024

Hi, I've same issue with newest code in master branch .

It's throw exc_bad_access in the makeTangentGeometrySourceForNode:
SCNGeometrySource *tangentSource = [SCNGeometrySource geometrySourceWithData:[NSData dataWithBytes:scnTangents length:nVertices * 3 * sizeof(float)] semantic:SCNGeometrySourceSemanticTangent vectorCount:nVertices floatComponents:YES componentsPerVector:3 bytesPerComponent:sizeof(float) dataOffset:0 dataStride:3 * sizeof(float)];
But this crash is only happen on iOS8, if I running it in iOS11, everything work fine

from assimpkit.

azolyoung avatar azolyoung commented on June 18, 2024

I'm using a model by obj+mtl+jpg

from assimpkit.

azolyoung avatar azolyoung commented on June 18, 2024

oh, I found the reason why it would crash on iOS 8, because in , it using a constant that only available after iOS 10, it is SCNGeometrySourceSemanticTangent, here is the define:
FOUNDATION_EXTERN SCNGeometrySourceSemantic const SCNGeometrySourceSemanticTangent API_AVAILABLE(macos(10.12), ios(10.0), tvos(10.0));

from assimpkit.

dmsurti avatar dmsurti commented on June 18, 2024

@azolyoung AssimpKit minimum iOS requirement is iOS 10.0 or later, which is listed in the README.md and in the project home page.

from assimpkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.