dmnsgn / primitive-geometry Goto Github PK

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please click the 'fix repo' button on account.greenkeeper.io.

When specifying cube or plane with sx:1 we are creating 2x2x2 cube not 1x1x1 cube. Therefore sx is closer to rx. I know that is consistent with primitive-* modules but would be good to clarify that. Especially that default values are 1 not 0.5.

primitive-plane had quads option that would return quads instead of triangles https://www.npmjs.com/package/primitive-plane

I used it a lot for grids generation.

It would be nice to have compact list of all the functions and their params

I'll work on proper PR as autogenerated dump is missing some values

quad({ scale = 0.5 )
plane({ sx = 1, sy = sx, nx = 1, ny = nx )q
cube({ sx = 1, sy = sx, sz = sx, nx = 1, ny = nx, nz = nx )
roundedCube({  sx = 1,  sy = sx,  sz = sx,  nx = 16,  ny = nx,  nz = nx,  radius = sx * 0.25,)
cylinder({  height = 1,  radius = 0.25,  nx = 16,  ny = 1,  radiusApex = radius,  capSegments = 1,  capApex = true,  capBase = true,)
cone({ height, radius, nx, ny, capSegments, capBase )
capsule({ height = 0.5, radius = 0.25, nx = 16, ny = 32 )
sphere({ radius = 0.5, nx = 32, ny = 16 )
icosphere({ radius = 0.5, subdivisions = 2 )
ellipsoid({  radius = 1,  nx = 32,  ny = 16,  rx = 0.5,  ry = 0.25,  rz = ry,)
torus({  radius = 0.3,  segments = 64,  minorRadius = 0.1,  minorSegments = 32,  arc = _utils_js__WEBPACK_IMPORTED_MODULE_0__.TAU,)
box({ sx = 1, sy = sx, sz = sx )
circle({ radius = 0.5, segments = 32 )

Unexpected identifier 'as'. Expected 'from' before exported module name because webkit still can't understand reexport export { default as bla } from "./bla.js";

https://github.com/tc39/proposal-export-default-from#common-concerns

Track status: https://caniuse.com/mdn-javascript_statements_export_namespace

When using with old code that uses parameters instead of options object all functions fail silently as all parameters deconstruct to undefined. This is very hard to debug as all returned data is valid just always contains default mesh.

As those functions are used sparingly (i.e. not every frame usually) consider issuing console.warn('Using parameters is deprecated, please use options object instead') on invalid use to ease transition.

Would be a nice help to have this in the generated data so that it can be used more directly with normal maps etc.

Probably unrelated, but when I try to use the gltf-spec implementation to compute it in the fragment shader, using the supplied vertices, normals, and uvs, I end up with a bump at the sphere poles:

Happened with other libs too though, probably not a bug here, just another motivation why it would be cool to have it baked in, maybe passing the tangent down will magically make my problem disappear ;)

What about adding seamless box https://github.com/vorg/primitive-box useful for AABB rendering.

The devDependency dat.gui was updated from 0.7.5 to 0.7.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

dat.gui is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency browserify was updated from 16.3.0 to 16.4.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

browserify is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Current implementation produces cylinder with apex radius 0, degenerated triangles and 12 faces instead of 4.