dmackgl / gcphone-rewritten Goto Github PK

Describe the bug
WHILE! constantly spammed in console.

Sentry Issue: APP-2

NavigationDuplicated: Avoided redundant navigation to current location: "/".
  at createRouterError (webpack-internal:///8345:1950:15)
  at createNavigationDuplicatedError (webpack-internal:///8345:1920:15)
  at HashHistory.confirmTransition (webpack-internal:///8345:2213:18)
  at HashHistory.transitionTo (webpack-internal:///8345:2145:8)
  at HashHistory.push (webpack-internal:///8345:2589:10)
...
(8 additional frame(s) were not displayed)

Is your feature request related to a problem? Please describe.
it is a bit tiring to be manually copying a link from an image, which could enable the function to directly copy and paste the link in "Change avatar (URL) (in Twitter app)"

Describe the solution you'd like
You can add the esx_menu instead of the actual modal. Or just enable the CTRL + C CTRL + V

Describe alternatives you've considered
Enable the CTRL + C CTRL + V

Unpaid bill can pay through phone
Check bank balance, transfer, transfer history etc

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Integrate SaltyChat to the phone

Describe alternatives you've considered
TokoVoIP (Not famous)

Additional context
https://forum.cfx.re/t/free-optimized-gcphone-rewritten/2530569/16?u=dmack

Is your feature request related to a problem? Please describe.
Using multi-character resources keeps the same Twitter user logged in.

Describe the solution you'd like
Recognizing when the user changes (Comparing licenses should work)

Describe alternatives you've considered
Log out user every time

Additional context
https://forum.cfx.re/t/free-optimized-gcphone-rewritten/2530569/17?u=dmack

Describe the bug
When I press F1 the map gets big and nothing more happen, there no errors in the consol

To Reproduce
Steps to reproduce the behavior:

1. F1
2. Map gets big

Expected behavior
Map gets big

Screenshots

FiVEM(please complete the following information):

• SaltyChat

Additional context

Describe the bug
Unable to send messages or receive messages

To Reproduce
I just try to send message but it doesnt send it and gives me error

Expected behavior
I expected the message to be sent

Screenshots
https://gyazo.com/dace22634e9d2aa2fa3a8a64d25191c5

FiVEM(please complete the following information):
I use mumble-voip and the newest artifact

Additional context

Is your feature request related to a problem? Please describe.
The leak of discord webhook in clientside script

Describe the solution you'd like
Move webhook to serverside

Describe alternatives you've considered
None

Additional context
https://forum.cfx.re/t/free-optimized-gcphone-rewritten/2530569/28?u=dmack

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Settings'
2. Click on 'Enable Mouse Mod (true)'
3. i tried to set the mode to false and nothing happens

Expected behavior
Set mouse mod in false ?

Screenshots
I dont have sorry

FiVEM(please complete the following information):

• Artifact [sorry, i dont have my version.]
• Voice Software [Mumble Voip]

I found a solution to fix bugs:

• phone animation when u get message
• calling people

I don't know why but you need to delete if hasPhone() then in line 331

and replace event in line 441

RegisterNetEvent("gcPhone:waitingCall")
AddEventHandler("gcPhone:waitingCall", function(infoCall, initiator)
  SendNUIMessage({event = 'waitingCall', infoCall = infoCall, initiator = initiator})
  if initiator == true then
    PhonePlayCall()
    if menuIsOpen == false then
      TooglePhone()
    end
  end
end)

Also i found a new bug, when u have phone open and u receive a message - animation will trigger... dont know how to fix it

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
I think a nopixel like call/text/tweet notification would be cool. Where the phone slightly pops up enough to see the drop down from the top of the phone with the notification.

i get this error with the new release

Originally posted by @HezimX in #45 (comment)

Hello,

Since yesterday I have a problem when I want to make the action of calling.

When I want the old action to call (by clicking on the button) nothing happens and I turned everything around.

I did the test with 4 different phones, 4 different server bases, one of which was empty and also 3 different artifacts and nothing ever changed.

I have no errors, nothing that can point me to this problem that only my friends and I encounter.

Do you have a solution?

Thank you for reading and looking forward to your answer. Thank you in advance.

Describe the bug
Hi guys how you doing? I get some UI errors (IN-GAME) after try the npm run build command, Looks like the bundle is not correct or (also a possibility) I'm doing something bad in the build process. Have a good day guys!

To Reproduce
Steps to reproduce the behavior:

1. Build the project
2. Use HTML folder in your fivem server
3. Try to open contacts or something like that
4. Press F8 and see those javavascript errors.

Expected behavior
The UI should render in the phone

Screenshots

Additional context
No more additional context

Is your feature request related to a problem? Please describe.
Since the actual api link was removed, maybe you can implement the same functionality with this docs: https://apidocs.imgur.com/

Describe the solution you'd like
You can use this file as a good "example": https://gist.github.com/eirikb/7404666 . But obviously without using jquery because (like) it won't be necessary since we have vue tools and axios method. After implement this approach, you can include in the config file the client ID, the cliente secret, the token and the refresh token to generate the URL.

Describe alternatives you've considered
Probably another solution will be that each user create a self-hosted image server, with nodeJS or Java.

I've selected index.js:src_htmlPhone/src/router/index.js for refactoring, which is a unit of 103 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

Hi

When i using ghamattimysql twitter notification doesn't work?

Thanks

Describe the bug
UI interface is bug when "create a new contact"

To Reproduce
Steps to reproduce the behavior:

1. Go to Menu
2. Click on Contact
3. Click on "New Contact"
4. See the bug

Expected behavior
Input and labels should render with a friendly space between them

Screenshots

Additional context
The problem should be solved after remove "absolute" value for position property in:

But I don't know if you use the same CSS identifier for other components. After removing absolute:

Mesagges (dispatch) works only for Police, EMS doesn't work.
Where can I find event which create this message?

Would be great to have an app to join Jobs from instead of using other job listing scripts.

Is your feature request related to a problem? Please describe.
GPS Coords sent as a waypoint.

Describe the solution you'd like
Create a "ping" system (share location)

Describe alternatives you've considered
None

Additional context
https://forum.cfx.re/t/free-optimized-gcphone-rewritten/2530569/21?u=dmack

Describe the bug
From reading SaltyChat Documentation and doing a quick code review, the current way is not a valide use case.

EstablishCall
EndCall

Are both server side export, so should not be able to be called from client side, and should not be called twice should only be triggered once.

Solution
On call accept call server side trigger, send over user id's and trigger the export, same goes for ending call.

Sentry Issue: APP-T

TypeError: _this5.newTweet is not a function
  at _callee3$ (webpack-internal:///5757:414:24)
  at tryCatch (webpack-internal:///5666:63:40)
  at Generator.invoke [as _invoke] (webpack-internal:///5666:293:22)
  at Generator.eval [as next] (webpack-internal:///5666:118:21)
  at asyncGeneratorStep (webpack-internal:///2137:6:24)
...
(8 additional frame(s) were not displayed)

*Describe the bug
Twitter, message notification sound not working

To Reproduce
Steps to reproduce the behavior
1 try to send message .
2 try to send distress signal
Message is coming currently but no notification sound

**Expected.

Describe the bug
Testing the notifications I realize the animations aren't consistent in all the zooms.

To Reproduce
Steps to reproduce the behavior:

1. Go to Settings
2. Click on Zoom
3. Change the zoom
4. Close the phone
5. Run testnotification in F8
6. Change the zoom
7. Run testnotification again
8. Check the difference between both

Expected behavior
Notification animation consistent in all zooms

Screenshots
If applicable, add screenshots to help explain your problem. See the difference in the trash bins

FiVEM(please complete the following information):

• Artifact 3674
• Voice Software Mumble-Voip

Additional context
Add any other context about the problem here.
None

Unable to use phone booths by pressing E, an example of the message that comes up when near a phone booth.
Also unable to use the police department phone.

Describe the bug
When trying to call someone, the person will not get a notification at all of the incoming call and this error appears clientside.
SCRIPT ERROR: @gcphone/client/client.lua:37: attempt to call a nil value (local 'cb')
handler client/client.lue: 433

To Reproduce
Steps to reproduce the behavior:
Attempt to call someone

Expected behavior
Other person's phone to ring and give a notification

Screenshots
If applicable, add screenshots to help explain your problem.

FiVEM(please complete the following information):

• Artifact: Latest (as of 4/6/21)
• Voice Software TokoVoip

Additional context
None

When i open race menu its fully blank i can see just Header.
Can't create race etc... also can leave menu only with f1.

Is your feature request related to a problem? Please describe.
No advertisement app

Describe the solution you'd like
Create a yellow pages app.

Describe alternatives you've considered
None.

Additional context
https://forum.cfx.re/t/free-optimized-gcphone-rewritten/2530569/21?u=dmack

Describe the bug
The item check is not performed when receiving messages/calls

To Reproduce
Steps to reproduce the behavior:

1. Check if you have the phone item
   1.2. If you have it, drop it
2. Send a message from another player to you
3. See an error

Expected behavior
Check should be performed.

Screenshots
None.

Additional context
https://forum.cfx.re/t/free-optimized-gcphone-rewritten/2530569/28?u=dmack

Sentry Issue: APP-3

TypeError: Cannot read property 'id' of undefined
  at _callee$ (webpack-internal:///1040:690:63)
  at tryCatch (webpack-internal:///5666:63:40)
  at Generator.invoke [as _invoke] (webpack-internal:///5666:293:22)
  at Generator.eval [as next] (webpack-internal:///5666:118:21)
  at asyncGeneratorStep (webpack-internal:///2137:6:24)
...
(18 additional frame(s) were not displayed)

Hello,
If you are in the camera app and you then close your phone with esc you stay in the camera position and you have to restart the script.

Sentry Issue: APP-1D

Error: UserCancel

UserCancel

Sentry Issue: APP-X

TypeError: Cannot read property 'toLowerCase' of undefined
  at Store.addTweet (webpack-internal:///7776:1127:90)
  at Array.wrappedActionHandler (webpack-internal:///629:796:23)
  at Store.dispatch (webpack-internal:///629:488:15)
  at Store.boundDispatch [as dispatch] (webpack-internal:///629:393:21)
  at PhoneAPI.ontwitter_newTweet (webpack-internal:///9265:1612:37)
...
(1 additional frame(s) were not displayed)