Libdparse parseModule reentrant about libdparse HOT 6 CLOSED

It's probably not safe using the same rollback allocator across multiple threads.

Having an allocator per thread should be safe, assuming the internally used global Mallocator.instance it is using is thread-safe

from libdparse.

I found the problem. The StringCache went out of scope too early. Holding on to it fixed the problem. Right now libdparse is running fine in multiple threads. No more memory issues.

from libdparse.

Thanks for raising this issue. I think we can enable the discussions feature on the repo and there would be more appropriate place to ask, but I see no harm in asking here, of course.

Q: Is libdparse or the RollBackAllocator (and its dependencies) reentrant?

How do you define reentrant? Or do you mean thread-safe?

In a single threaded environment, reentrancy is usually about a library calling a user-defined callback and whether the code inside the callback is allowed to call the library. E.g.

library A -> callback -> library A

If the question is about thread safety, I'd say that unless you see a method explicitly marked as shared, then it's likely not thread-safe.

So the question is: what data do you share between the threads and how do you synchronize the access to it?

This seems to happen when the GC kicks in (either manually or automatically.

I have heard of similar issues (though I haven't had the chance to investigate any of them), so it's likely a bug in this library (or its dependencies). Most likely caused by missing calls to GC.addRange.

from libdparse.

there were fixes in the latest release of libdparse about the rollback allocator and GC breakage, but it's already release since quite a while ago so I would assume you already have it installed (v0.18.1)

from libdparse.

How do you define reentrant? Or do you mean thread-safe?

Yes, I did mean thread safe.

I would assume you already have it installed (v0.18.1)

I do. I'm using the master branch as my dependency( which is 0.18.1)

I'll see if I can do some debugging on my end. Thanks for the help!

from libdparse.

It all seems thread-safe. The D docs state that Mallocator is thread safe. I'll keep debugging.

from libdparse.