Code Monkey home page Code Monkey logo

Comments (3)

WebFreak001 avatar WebFreak001 commented on July 4, 2024

Exiting with a non-zero status seems to be correct when it's not found? Anyway xmllint is not a utility we make, so for issues with that you would need to check there.

The ci script also works properly, if you add paths that aren't found to the test txt files, the ci script properly aborts, optionally also printing the XML if you run it with environment variable VERBOSE=1.

from libdparse.

Mai-Lapyst avatar Mai-Lapyst commented on July 4, 2024

It was a long time, atleast until like 11 months ago where this was removed: https://gitlab.gnome.org/GNOME/libxml2/-/commit/e85f9b98a5389c69167176ae6600091e719ec38f

Which aparently was a long standing decision, since --xpath isnt intended to use for scripting: https://gitlab.gnome.org/GNOME/libxml2/-/issues/180

For me the ci script dosnt works at all and also dosnt aborts; atleast when using a newer version of xmllint.

from libdparse.

WebFreak001 avatar WebFreak001 commented on July 4, 2024

for now you can work around this through this patch:

diff --git a/test/run_tests.sh b/test/run_tests.sh
index 1e267d2..c2d6609 100755
--- a/test/run_tests.sh
+++ b/test/run_tests.sh
@@ -88,12 +88,12 @@ if [[ ${BUILDKITE:-} != "true" ]]; then
                                expectParseFailure=1
                        elif [[ "$line" =~ ^# ]]; then
                                true # comment line
-                       elif echo "$AST" | xmllint --xpath "${line}" - 2>/dev/null > /dev/null; then
-                               ((currentPasses=currentPasses+1))
-                       else
+                       elif echo "$AST" | xmllint --xpath "${line}" - 2>&1 | grep 'XPath set is empty' >/dev/null; then
                                echo
                                echo -e "    ${RED}Check on line $lineCount of $queryFile failed.${NORMAL}"
                                ((currentFailures=currentFailures+1))
+                       else
+                               ((currentPasses=currentPasses+1))
                        fi
                        ((lineCount=lineCount+1))
                done < "$queryFile"

however we will need to find a permanent solution, although it really sucks they removed this feature

from libdparse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.