dlandon / recycle.bin Goto Github PK

If the logging-option is enabled some files are apearing twice in the log.

The logged file in the screenshot was only deleted once, but logged twice.

When I exclude a share and delete files it still goes to the bin.

Without excluding a share the Recyle Bin plugin works as expected.
But I only want to enable recycle bin on 1 share. So I started excluding shares.
As soon when I did this and next I delete files on the exluded shares I see a ".Recycle" folder.

• Using the plugin without excluding shares => ".Recycle.Bin" folder
• Using the plugin with excluded shares => ".Recycle" folder

Unraid version: 6.12.4
Recycle Bin plugin version: 2023.08.12

I took a look at the recycle bin script but I don't understand some of the stuff:

       elif [[ `cat /boot/config/smb-extra.conf | grep "vfs objects"` == '' ]]; then
               if [ -e "/boot/config/smb-extra.conf" ]; then
                       sed '/#vfs_recycle_start/,/#vfs_recycle_end/{//d}' /boot/config/smb-extra.conf >> smb.tmp
                       printf %s "$(< smb.tmp)" > /boot/config/smb-extra.conf
                       rm smb.tmp
                       printf "\n" >> /boot/config/smb-extra.conf
                       cat /boot/config/plugins/recycle.bin/config/smb-extra.conf >> /boot/config/smb-extra.conf
               fi

What is the sed trying to do? delete all the lines between the #vfs_recycle_*?
the way you went about it is rather inefficient and quite confusing for me.

Then the crontab has these:

                if [[ `crontab -l | grep "# Purge recycle bin"` != "" ]]; then
                        crontab -l > /tmp/file; sed '/# Purge recycle bin/,/\/mnt\/user\/.Recycle.Bin/d' /tmp/file >> /tmp/cron; crontab /tmp/cron; rm /tmp/file; rm /tmp/cron

But shouldn't /mnt/user/.Recycle.Bin not exist anywhere?

Also we are running as root and sudo is quite unnecessary.