dlande000 / fakebook Goto Github PK

Hey David,

Great job on your sample state! One quick point:

• If you choose to incorporate likes as reflected in your schema, we'll need to keep track of these in the frontend state. Like friendships, it may not be necessary to store actual like objects in state. You could instead store arrays of likers' ids within a given post or comment.

Let me know if you have questions about this.

• Login errors display at the bottom of the page - can we have these display near the login form for now? Perhaps to the left of the form, in the nav bar?
• Profiles are looking great! The section header (below the banner picture) is missing thin grey lines between sections
• The big F button on the logged in navbar should direct the user to /feed, and styling could be improved

Hey David,

Good job setting up your fullstack project repo! Moving forward, we will be using Github issues to track outstanding points to addressed (alongside Slack, etc.). Please see below for a few notes regarding your preliminary design documents:

• users should also have a column for birthday and gender, as reflected on Facebook's signup/login page. You may also wish to consider adding profile-based columns such as bio, hometown, etc. Let's discuss this before next week.
• How will you keep track of where a post is posted (i.e., different users' walls, or on their own timeline)?
• Your comments table features comment_id and parent_id foreign keys, but states that post_id references posts and parent_id references comments. It also indexes on author_id twice.
• likes features a likeable_type column, which would suggest a polymorphic association. Do you plan to implement this? If so, please add a note detailing what resources will be involved.

Let me know if you have any questions!

• No errors display when I attempt to sign up/log in with faulty credentials
• Birthday input field looks different than Facebook's (which is three separate fields)
• Gender field looks different than Facebook's (which is a series of radio buttons)
• Can't sign up - no error messages either
• Styling is off to a great start, but needs additional work

Hey David - great work on friendships. Two prominent bugs I am still noticing:

• When I delete a friend, my photo still appears in their 'friend box' until I navigate to a different route and return
• I am automatically logged out when I refresh the page