Code Monkey home page Code Monkey logo

beach-rendezvous's People

Contributors

aphilay avatar chaitanya-40 avatar djtai avatar jeremysellem avatar patrickly avatar sukhleendhillon avatar

Watchers

 avatar  avatar  avatar  avatar

beach-rendezvous's Issues

Implement Movies Section

Implement the "Movies" section. For now, there should be two: one for when the users want to CREATE a Movies event, and one for when the users want to FIND a Movies event.

NOTE: The main difference is the text displayed. Ideally, the UI should be the same.

Implement Sports Section

Implement the "Sports" section. For now, there should be two: one for when the users want to CREATE a sports event, and one for when the users want to FIND a sports event.

NOTE: The main difference is the text displayed. Ideally, the UI should be the same.

Backstack should be empty after joining/creating an event

Bug: When the user joins/creates an event, they are brought back to the home screen BUT are still allowed to press back - this shouldn't be.

Likely Issue: The MainMenu fragment is added to the backstack after joining/creating an event.

Possible Fix: Instead of adding MainMenu to the backstack, just pop the backstack until the user is at home.

Close App After Fragment Stack Is Empty

After the user presses back enough, the app should close. Instead, they are brought back to the login activity - this should not happen. The following needs to be fixed:

  • Store login access token after signing in*
  • Check access token when app is opened

*Figure a way to access the auth token via Office 365 code (found in auth package)

Implement Food Section

Implement the "Food" section. For now, there should be two: one for when the users want to CREATE a food event, and one for when the users want to FIND a food event.

NOTE: The main difference is the text displayed. Ideally, the UI should be the same.

App crashes when trying to join a Movie event

Bug: When a user tries to join a Movie event, the app crashes

Likely Issue: Since the code was somewhat copied from the Sports classes, it could be a variable issue, a NPE (null-pointer exception), or a Database issue.

Possible Fix: Data validation will help prevent NPE's; the FirebaseDatabase reference is created as final - this could be an issue, although I haven't tested it.

Create Database

The database for Sport events needs to be created and, eventually, linked to the "Search -> Sports" and "Create -> Sports" feature.

Ideally, the database will be created/managed using the Room Persistence library.

Red Circle Warning Persists After Date Selection

Issue: The red circle warning doesn't disappear after the user selects an appropriate date

How to replicate:

  1. Go to "Create" section of the app
  2. With the "Date:" box empty, click "Create" button so that the red circle warning appears next to date
  3. Select a valid date (i.e., a date that is in the future). The red circle warning should still persists.

UI Issues

The following need to be addressed

MOST IMPORTANT

  • Add ListView to home screen (via MainMenu fragment & it's relative .xml) to house the sports events the user has created. The layout of MainMenu should look similar to fragment_sportsevent.xml.
    NOTE: Just do the UI, @vooradi1993 will handle the logic.

LESS IMPORTANT

  • Padding b/w arrow and edge of screen
  • Change arrow icon to something simpler; make icon smaller
  • Change green icons to a lighter shade of grey
  • Test different fonts
  • Add date picker next to Date text box // fixed with #42
  • Add time picker next to Time text box // fixed with #42

Launcher Icon & Login Logo

Update the launcher icon, i.e., make it look up-to-date.

Also, the colors of the logo (seen on the login screen) do not match the colors found in the colors.xml.

NOTE: Not as important, but nonetheless should be considered if you have the time.

Update Bottom Nav Bar & Implement Sections

Currently, the bottom navigation bar displays the wrong information. The navigation bar should display, in order:

  • Info
  • My Profile
  • Settings

This could, and might, change in the future. For now it will suffice for our "Dummy App" project.

  1. Update info
  2. Implement sections

Change Name of Create Button

It has come to my attention that the "Create" button should probably have a different name - maybe "Submit". Why? Well...when a user is in the "Create" section and they are about to create an event, the "Create" button is located directly above the "Create" nav bar button - do you see the problem?

It's not truly a problem - I just think it would make more sense.

Bug: Update bottom nav bar selection upon backpress

When navigating via bottom navigation bar, it shows which fragment is currently open by making the icon bold.

The issue is when a user presses the back button on their phone - it doesn't update the icon, i.e., if you click Search, then click Create, and then hit the back button, even though you are back on the Search fragment, the Create icon is still bolded.

NOTE: I assigned this issue to everyone but only one of us needs to work on it really...I just thought I'd bring this to everyone's attention.

Develop "Search -> Sports"

Further develop the search feature for the Sports fragment.

NOTE: The classes might need to be renamed so that our App's naming convention is the same.

Food section

The infrastructure is there, but the features have not been implemented yet. The overall task should be relatively simple:

  • Fix the .xml files to look similar to their Sports counterparts
  • Add the logic to each fragment, again mimicking their Sports counterparts

Since Sports is almost done, we can look to those files to see the similarities and differences.

If there is any confusion, please let it be known - we are all here to help each other, especially in these final days! Happy coding.

UI Issues

Issues:

  • TimePicker doesn't properly show time selected, e.g., 11:01 appears as 11:1 (the first 0 never appears)
  • Alignment of arrows (@SukhleenDhillon needs to push this code first)
  • Make the Sports events not capitalized, e.g., Soccer instead of SOCCER

Implement Login Activity

Application has no login activity. The login activity should ideally be implemented using Okta's API's - a secondary choice could be using students' BeachMail (i.e., Microsoft).

Implement Main Menu

Create the main menu of our application, i.e., implement the "Create/Find Events" page.

ListViews Empty on Back Press

The ListViews that show data pulled from Firebase aren't repopulated when the Fragments are popped off of the back stack.

I think I have a fix for this on one of the dev branches - I'll commit it, cherrypick it to the master, and test it out.

Data Validation

Bugs:

  • Users shouldn't be allowed to select dates prior to the present date (this includes TIME)
  • Events shouldn't be allowed to be created if the following fields are empty:
    • Date, Place, Time, Number of people, and Duration
  • Duration should follow normal time constraints, i.e., users shouldn't be allowed to set a minute duration past 59 (e.g., 2:61)
  • Users shouldn't be able to re-join an event they've already created (this could be solved by making the join button invisible if they've already joined it, or not displaying it, or something else)
  • Check to see if someone has already joined an event

Fix "Home" section

The "Home" section (accessed via the bottom navigation bar) should display two things:

  1. Events joined
  2. Events created

For now, placeholders will suffice, seeing as the database has yet to be implemented.

Events should have names

Enhancement: Some users have requested that they be allowed to name their events.

Possible Fix: Fixing the DB-related classes/entities, i.e., adding the parameters that allow naming events.

Localize App

Using the strings.xml files that @jeremysellem has supplied, localize the app.

NOTE: Not as important. This issue can probably wait until the weekend, or even until next Monday/Tuesday (13th/14th).

Movies section

The infrastructure is there, but the features have not been implemented yet. The overall task should be relatively simple:

  • Fix the .xml files to look similar to their Sports counterparts
  • Add the logic to each fragment, again mimicking their Sports counterparts

Since Sports is almost done, we can look to those files to see the similarities and differences.

If there is any confusion, please let it be known - we are all here to help each other, especially in these final days! Happy coding.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.