djbrown / hbscorez Goto Github PK

HbScorez is a web application, which processes handball game reports of diverse handball associations, districts, and leagues. It analyzes the player scores and displays the statistics and rankings.

Home Page: https://hbscorez.de

License: MIT License

Python 34.15% Dockerfile 0.08% HTML 55.91% Shell 0.18% JavaScript 1.40% CSS 0.11% Jinja 8.19%

django handball statistics

hbscorez's Introduction

Hi there 👋

hbscorez's People

Contributors

Stargazers

Watchers

Forkers

fossabot codacy-badger jupadin

hbscorez's Issues

[H4A] Seperation of Fourth Division Districts

Fourth Divisions used to be listed as districts in related Associations.
Now the Fourth Division Leagues are only listed directly in the Fourth Division Associations without visible District.

The District "BWOL" used to be listed the Asscociaton HVW.
Now it is only visible in the dedicated Association HBW.

Therefore importing Fourth Divisions is not possible:
setup -a 3 -d 4 -s 2018 -l 35068 -> no Districs and Leagues found.

Also the Navigation should be updated to resemble this relation, e.g. like in the new H4A-Portal.

Description

As a Viewer I want to have meaningful URLs so I know which content I would visit before actually going there.

Display Player portraits on Team page

portrait and summary data

Dynamic page caching

django caching...
invalidate chache after importing data

Feature: Team Logos

As a Club or Team Associate I want to specify a Club or Team Logo by uploading the Image File.

`src/teams/models.py`

logo = models.ImageField(upload_to=os.path.join(settings.MEDIA_ROOT, 'club-logos'))

Games not updated if only certain properties have changed

Steps to reproduce

import game
change home_goals, guest_goals or report_number
import game (again)
⚠️ game not updated!

Relevant Code

The game is only saved if properties have changed.
For deleting Scores the properties are split into two groups. First one is:

hbscorez/src/base/logic.py

Lines 86 to 91 in 685f122

    
           defaults: dict[str, Any | None] = { 
        
               "home_goals": home_goals, 
        
               "guest_goals": guest_goals, 
        
               "report_number": report_number, 
        
           } 
        
           updated = ensure_defaults(game, defaults)

The problem ist, that the updated flag is overwritten and set only if following properties have changed:

hbscorez/src/base/logic.py

Lines 97 to 105 in 685f122

    
           defaults = { 
        
               "opening_whistle": opening_whistle, 
        
               "sports_hall": sports_hall, 
        
               "forfeiting_team": forfeiting_team, 
        
           } 
        
           updated = ensure_defaults(game, defaults) 
        
           if updated: 
        
               game.save()

So if only the former properties have changed, the game isn't updated in the database.

Problem with missing report folder

Hey,
i have some problems with the import_scores.py file. The script will crash if the report folder is missing at line 91.
I solve the problem by adding the following line of code above.
os.makedirs(os.path.dirname(game.report_path()), exist_ok=True)

Search Engine Optimization

'Player' object is not iterable

Hey,
all first I want to thank you for your great Job.
I also know that you want to use Redmine (I don't know why), but here it is easier to connect this issue to code.
I think in the code below is a little bug, since the last update. I get follow exception: "TypeError: 'Player' object is not iterable".

hbscorez/base/management/commands/import_scores.py

Line 107 in a585b37

    
           player, created = models.Player.objects.get_or_create(name=player_name, team=team)[0]

The fix is to remove the call for the first array element.

I came across this when I want to change the Team based "Torjäger" list to display also Player with zero goals. (Maybe this is also a nice Feature =) )

Thanks and have a nice Sunday

Use Log Rotation

Logging | Django documentation
TimedRotatingFileHandler | Python documentation
store logs in seperate directory
deployment: mount log directory

Player Scores missing Report url

https://hbscorez.de/spieler/146538/

Static file caching

Doppelverwendung der Variablen für Tore

Hi @djbrown,

s. Anzahl der Spiele für die aktuelle Saison 23/24 bei https://hbscorez.de/spieler/414186/.
Hier dürften (Stand heute 24.10.23) lediglich 5 Spiele stehen, wird aber die Variable für die Anzahl der geworfenen Tore verwendet:

hbscorez/src/players/jinja2/players/detail.j2

Lines 22 to 25 in 45c49fa

    
           <h2>Statistiken</h1> 
        
           <p>Spiele: {{scorer.total_goals}} 
        
           <p>Tore: {{scorer.total_goals}} 
        
           <p>7m: {{scorer.total_penalty_goals}} von {{scorer.total_penalty_tries}}

PR-Fix kann ich gerne erstellen - Issue ansonsten auch gerne einfach direkt schließen, falls du das schon erledigt hast bzw. machst.

Viele Grüße

Run pylint in ci-build and pr-build

pipenv run pylint should be executed for every push
already documented in README.md:

hbscorez/.github/CONTRIBUTING.md

Lines 30 to 39 in 2f2c426

    
           ## Code Formatting and Style Guide 
        
           You may contribute to this Project using any IDE, Editor or Terminal you like, as long as your modifications obey the conventions defined by the [Style Guide for Python Code (PEP8)](https://www.python.org/dev/peps/pep-0008/). 
        
           The following command will clean your code accordingly: `pipenv run autopep8` 
        
           Also make sure to check messages from the following commands before proposing: 
        
           - `pipenv run mypy src` 
        
           - `pipenv run flake8` 
        
           - `pipenv run pylint src`

scrape new Portal instead of old one

Handball4all Portal instead of spo.handball4all.de

Verbandsabkürzungen in Großbuchstaben

Hi @djbrown,

wie findest Du die Idee, die Abkürzungen des jeweiligen Verbands als Großbuchstaben darzustellen ?

hbscorez/src/base/parsing.py

Lines 28 to 29 in 013af77

    
           def parse_association_abbreviation(association_url: str) -> str: 
        
               return association_url.rsplit('/', 1)[1]

Mit entsprechender Anpassung des folgenden Tests

hbscorez/src/base/tests/unit/test_parsing.py

Lines 39 to 45 in 013af77

    
           def test_abbreviation(self): 
        
               url = 'https://www.handball4all.de/home/portal/bhv' 
        
               actual = parsing.parse_association_abbreviation(url) 
        
               expected = 'bhv' 
        
               self.assertEqual(expected, actual)

Ggfs. würde ich hier noch eine Anpassung des Funktionsnamens zu test_parse_association_abbreviation vorschlagen. Wie siehst Du das ?

Viele Grüße

Feature: Scorer Year of Birth

Currently there is an empty Column Jahrgang in Game Reports.
This would ideally contain the Year of Birth of the respective Participant.

`src/players/management/commands/import_reports.py`

def import_scores(table, game: Game, team: Team):
    player_year_of_birth = row_data[2]

Alternative: allow Users to enter their Year (or Date) of Birth in their Profile.

Evaluate PDF parsing libraries

currently using https://github.com/chezou/tabula-py/tree/master
problems:

needs Java
doesn't handle some corner cases well

Alternatives:

	defaults: dict[str, Any \| None] = {
	"home_goals": home_goals,
	"guest_goals": guest_goals,
	"report_number": report_number,
	}
	updated = ensure_defaults(game, defaults)

	defaults = {
	"opening_whistle": opening_whistle,
	"sports_hall": sports_hall,
	"forfeiting_team": forfeiting_team,
	}
	updated = ensure_defaults(game, defaults)

	if updated:
	game.save()

	<h2>Statistiken</h1>
	<p>Spiele: {{scorer.total_goals}}
	<p>Tore: {{scorer.total_goals}}
	<p>7m: {{scorer.total_penalty_goals}} von {{scorer.total_penalty_tries}}

	## Code Formatting and Style Guide

	You may contribute to this Project using any IDE, Editor or Terminal you like, as long as your modifications obey the conventions defined by the [Style Guide for Python Code (PEP8)](https://www.python.org/dev/peps/pep-0008/).
	The following command will clean your code accordingly: `pipenv run autopep8`

	Also make sure to check messages from the following commands before proposing:

	- `pipenv run mypy src`
	- `pipenv run flake8`
	- `pipenv run pylint src`

	def parse_association_abbreviation(association_url: str) -> str:
	return association_url.rsplit('/', 1)[1]

	def test_abbreviation(self):
	url = 'https://www.handball4all.de/home/portal/bhv'

	actual = parsing.parse_association_abbreviation(url)

	expected = 'bhv'
	self.assertEqual(expected, actual)