MPTTModelAdmin (0.6.0) indents children using an inline padding-left on the th. However this is overwritten by djangocms-admin-style's CSS (0.2.2) with:

.module table th {
    padding: 2px 5px !important;
    [...]
}

see django-cms/django-cms#2853 as reference

The version was bumped but there isn't a git tag for 0.2.3

I have a dark system theme and so all text boxes in websites are dark too. As #id_username on the login page has no style (or at least no background colour) the text is black on dark, as you can see in the screenshot:

Text should have the same indent as "A new...".

It looks like the two boxes which are used within the default admin have disappeared. It would be nice to have them back, as the current m2m multiselect field is hardly usable (especially with more than, say, 20 options in it):

Additional: it is mainly because when you've selected 60 out of 150 options, and you accidentally click without control/command, you lose the whole selection...

Also you can't see in one view which options are selected and which are not. And last but not least the scrolling doesn't really work in the sidebar of the frontend (like everything scrolls a bit: the actual page, the admin sidebar and the multiselect field.

I noticed that source map creation has been disabled in gruntfile.js due to file size concerns:

// Sourcemaps are disabled by default to reduce filesize
// .pipe(sourcemaps.init())
    ...
// Sourcemaps are disabled by default to reduce filesize
// .pipe(sourcemaps.write())

Using sourcemaps.write() without an argument creates inline source maps within the destination .css files, thereby inflating those files; however, sourcemaps.write('.') will create external source maps at the same level as the destination .css files and leave the those .css files alone.

It seems that external source maps are only loaded if developer tools are opened, so you can have source maps without worrying about the source map file sizes.

Hi there!

I see some strange stylings in the plugin editor.
First I don't like the table titles to be uppercased, but that's a matter of opinion of course.

Other than that - can you have a look at the icons near "SlideshowImage object"?
What's the "edit pen" icon for? It's not clickable.

Last point: Too me, nofile_48x48.png (image symbol with questionmark) looks like an error - wouldn't the icon work without the questionmark?

Thanks!
Florian

In projects with a lot of stuff in the admin, it can be difficult to find what you are looking for as headings don't really stand out.

Just my thoughts :)

For example if there is filter by FK to model with on hundred or more elements

In an app that coexists with django-cms on my site, the admin declares:

fieldsets = (
(None, {
'fields': (('shortname', 'published', 'notfeature'),),
}),
...

I get

I want

Looks to me like djangocms-admin-style sets float to none and removes horizontal margins:

form .form-row .field-box {
float: none;
margin-right: 0 !important;
margin-top: 20px;
}

Am I doing something wrong? Without djangocms-admin-style, the admin form looks right, but I'm also using django-cms, and it's a requirement.

Hi all,

I recently upgraded to Django 1.9 and DjangoCMS 3.2.1. I also updated djangocms-admin-style to the latest current version, 1.0.9. Upon doing so, the search bar in the admin interface breaks for all instances where search_fields is set in the ModelAdmin. I'm not able to click on the search box to make it active, and it appears broken in the layout. I have reproduced this in Firefox (44.0) and in Chrome (50.0.2633.3)

See the screenshot below.

I've run a collectstatic and have migrated everything upon doing this upgrade. Here are the apps that I have installed.

$ pip freeze
beautifulsoup4==4.4.0
dj-database-url==0.3.0 
Django==1.9.1
django-classy-tags==0.6.2
django-cms==3.2.1
django-extensions==1.6.1
django-formtools==1.0
django-htmlmin==0.9.0
django-nocaptcha-recaptcha==0.0.18
django-reversion==1.10.1
django-sekizai==0.9.0
Django-Select2==4.3.1
django-treebeard==4.0
djangocms-admin-style==1.0.9
djangocms-inherit==0.1.1
djangocms-link==1.7.1
djangocms-snippet==1.7.1
djangocms-teaser==0.2.0
djangocms-text-ckeditor==2.8.1
html5lib==0.999999
Pillow==3.1.0
psycopg2==2.6.1
six==1.9.0
sorl-thumbnail==12.3
wheel==0.24.0

EDIT: My proposed solution does not work, the "nofile" image / icon is too big then.

Hey,

I am having trouble with the clear icon size of the filer image. When removing the image size it looks good, but I am not sure if this is the correct way to fix it.

Thank you in advance

Jakob

Versions

django-cms==3.2.0
djangocms-admin-style==1.0.7
django-filer==1.0.2

Screenshots

static files should be all namespaced inside a app folder inside static. Anything placed directly in static might clash with other static assets of the project.

So all djangocms-admin-style staticfiles should be in static/djangocms_admin_style/. Of course with the exception of static files that are overridden for other apps.

• static/js should be in static/djangocms_admin_style/js/.
• once django-filer 1.2.0 is released, static/icons and static/filer/icons can be removed

Currently,
.form-row input, .form-row textarea { width: 250px; }

This limits size of TextInput fields like CharField, SlugField etc. Default django admin uses html size attribute which allows to customize size of html input. Since fixed with is added, it's not possible anymore.

Hi, when I use the action drop-down list to bulk delete objects in the admin panel, I get this error.

However, deleting items individually works.

I've got an m2m field in the admin that is overflowing the container on Chrome (works great on Firefox).

I believe the issue is this line: https://github.com/divio/djangocms-admin-style/blob/master/djangocms_admin_style/sass/libs/html5-boilerplate/_styles.scss#L80

Maybe add a rule for select[multiple]?? and do overflow: hidden or overflow: auto. CSS in not my forté.

I'm upgrading from djangocms-admin-style==0.2.5 and noticed that the admin's filter_vertical setting for many-to-many fields is no longer respected.

A vertical filter is actually horizontal in djangocms-admin-style==1.0.4:

Also, vanilla Django admin and the older django CMS admin kept the filter box sizes consistent. It seems weird having them lopsided like this.

/static/admin/img/icon-no.gif and /static/admin/img/icon-yes.gif are not scaled down to 16px:

Here is what the display looks like with admin actions enabled:

Here's what it looks like with actions = None:

These screenshots are from 1.0.7 but I also tested this on master @121a91d97c8fa0fa953c35274b44d976a6a5e50a

With djangocms-admin-style, when I open the image upload dialog, the two buttons at the top are not visible anymore (and few more other visual quirks). This is happening in version 1.0.4 and 1.0.6 in django-cms 3.1.3.

There is no translation for {% trans 'Open' %} in Transifex - Django - admin project.
From 'djangocms_admin_style/templates/admin/inc/branding.html' - line 27

I've got a multiple select field with the max-width set at 240px and the overflow visible.

This is surely an issue as it constrains the select box and then spills out all of it's options in the form?!

We may want to exclude these boxes from the max-width css rule added in 8739a5cb?

see: django-cms/django-cms#3004

styling for m2m fields is not so cute.

As you can see in the following screenshot the table gets 2 inner scrollbars, while the filters part gets another vertical scrollbar, and the whole page also has a (disabled) scrollbar.

I think this is quite confusing. Wouldn't there be a better way of displaying such information?

Under certain conditions (eg Ubuntu using fallback font Verdana), the line height (12px) for input and select elements can be too low for the font size (12px), causing descenders and underscores to be cropped by the padding:

120% line height should resolve this, which would be 14.4px, so I tried increasing the line height to large font size (16px) and reducing the vertical padding accordingly, but it caused problems in IE. This will therefore either need further css hackery to fix those issues, or it becomes a design decision around input element sizes and padding.

the .module class styles all the inner html. But when using custom html or wysiwygs it also overrides those styles.

.module table td for example adds unrequired padding to the ckeditor.

django-cms/django-cms#2666

On above screenshot, first field is search field on foreignkey relation

Presumably this is due to template changes in 1.7 but admin.site.site_header, admin.site.site_title aren't respected when djangocms-admin-style is installed.

https://docs.djangoproject.com/en/dev/ref/contrib/admin/#django.contrib.admin.AdminSite.site_header

Hi there. When show_change_link = True in an admin.TabularInline class, the corresponding change link is styled improperly.

It looks like this:

It should look like this:

The inlinechangelink class normally has a padding-left of 12px:

However, this is overridden and set to 0 with the .tabular table td a selector:

Thanks!

Hi,
I'm looking at the new admin interface. Nice work btw.

The top right button "Open website name" requires site to be an attribute of request object.
I couldn't find any reference in the documentation.
This can be achieved with django.contrib.sites.middleware.CurrentSiteMiddleware .
The only concern is that the middleware was added to Django 1.7, but Django-CMS 3.2 still supports Django 1.6.

Hey,

You should consider using {% static %} to support alternative storage engines, like Amazon S3, instead of {{ STATIC_URL }}. Example: https://github.com/divio/djangocms-admin-style/blob/master/djangocms_admin_style/templates/admin/base_site.html#L6

http://cl.ly/image/1E3w1M2Y2f3c

.vLargeTextField, .vXMLLargeTextField { width: 48em; }

I recommend that you make it more clear that V1.10 is not compatible with older versions of django anymore. It really needs django 1.9 - at least the admin styles of django 1.9. Otherwise the change forms don't really look well (submit row, inlines)

Workaround for django 1.8: from django 1.9, copy forms.css to your local static/admin/css folder (create, if not existing yet) and fix the style for .submit-row:

.submit-row {
    padding: 12px 14px !important;
    margin: 0 0 20px;
    background: #f8f8f8;
    border: 1px solid #eee;
    border-radius: 4px;
    text-align: right;
    overflow: hidden;
}

(padding needs an !important)

As solve, add:

@media only screen and (max-width: 768px), print {
    .selector ul.selector-chooser {margin: 0!important;}
}

Apologies if I'm not doing this right but it appears I'm the first person to use this on a retina screen? This is what the admin looks like for me in an essentially base install. I'm running the latest Yosemite.

Since Compass 1.x release comes with a lot of deprecations, this is breaking scss compilation for most project built with Compass 0.x.

If i try to compile djangocms-admin-style scss with my Compass 1.x install it fails with some errors:

$ compass compile --force -c config_admin-style.rb
 modified config.rb
    clean /home/work/projects/pims/try-it/project/webapp_statics/djangocms_admin_style/css
   delete /home/work/projects/pims/try-it/project/webapp_statics/djangocms_admin_style/css/djangocms-admin-frontend.css
   delete /home/work/projects/pims/try-it/project/webapp_statics/djangocms_admin_style/css/djangocms-admin.css
   delete /home/work/projects/pims/try-it/project/webapp_statics/djangocms_admin_style/css/ie.css
    write /home/work/projects/pims/try-it/project/webapp_statics/djangocms_admin_style/css/djangocms-admin-frontend.css
WARNING: $base-line-height must resolve to a pixel unit.
         on line 47 of /home/work/.rvm/gems/ruby-2.1.1@foundation55/gems/compass-core-1.0.3/stylesheets/compass/typography/_vertical_rhythm.scss
         from line 4 of /home/work/.rvm/gems/ruby-2.1.1@foundation55/gems/compass-core-1.0.3/stylesheets/compass/_typography.scss
         from line 152 of /home/work/projects/pims/try-it/compass/admin_style/_settings.scss
         from line 1 of /home/work/projects/pims/try-it/compass/admin_style/djangocms-admin.scss

I didn't try to fix it yet, so there is probably more errors to fix.

You should put a notice about that (Scss require Compass 0.x to compile) in your Readme or if you are interested to use Compass 1.x, i may be able to fix your scss within a pull request.

Full list should be available.

Just installed 1.0.4 and now have a blank header in the admin. Browser inspection says djangocms-admin.css is display: none;-ing both the #user-tools and #header #branding h1.

Hi, I am overriding the admin/base_site.html template, this is my code:

{% extends "admin/base.html" %}
{% load i18n staticfiles %}

{% block extrastyle %}{% include 'admin/inc/extrastyle.html' %}{% endblock %}

{% block extrahead %}<link rel="stylesheet" type="text/css" href="{% static 'djangocms_admin_style/css/djangocms-admin.css' %}" />
<meta name="viewport" content="width=device-width,initial-scale=1" />
<script type="text/javascript">
if (window.self!==window.top) { document.write('<link rel="stylesheet" type="text/css" href="{% static 'djangocms_admin_style/css/djangocms-admin-frontend.css' %}" />'); }
</script>
{% include 'admin/inc/extrahead.html' %}{% endblock %}

{% block title %}{% include 'admin/inc/title.html' %}{% endblock %}

{% block branding %}{% include 'admin/inc/branding.html' %}{% endblock %}

{% block usertools %}{% include 'admin/inc/usertools.html' %}{% endblock %}

Everything looks good, but I cant seem to display the {% block usertools %}{% include 'admin/inc/usertools.html' %}{% endblock %} part.

My usertools.html looks like this.

{# usertools #}
usertools

I cant get it to show. Using Django 1.7 Any ideas?

The extrastyle.html path in the readme is wrong:
templates/admin/extrastyle.html

The correct path is:
templates/admin/inc/extrastyle.html

Whenever you try to delete an object from the admin with Django 1.7 and Python 2.7, you end up with a NoReverseMatch exception raised in

djangocms_admin_style/templates/admin/delete_selected_confirmation.html

The traceback says

Reverse for 'app_list' with arguments '()' and keyword arguments '{u'app_label': ''}' not found.

and this is related to line 11 of the template which renders the nested menu (depicted below).

I can provide a fix that was successfully tested under Django 1.7 and Python 2.7 in a pull request if one of the contributors agrees.

This app would be a perfect fit to use django-sass-processor instead of compass.

@yakky remember, you asked a while ago to allow offsite compilation, so that djangocms-admin-style can be shipped with precompiled .css files, rather than having them to compile in a productive environment. Well, django-sass-processor can do that now.

If desired, I can create a PR for this. Would help during development to get rid of a Ruby dependency and having to run a directory watching process.

I think, good idea is to have option to make dropdown filter menu as django-cms page list:

Option may be like that:

@admin.register(Example)
class ExampleAdmin(DjangocmsAdminStyleMix, admin.ModelAdmin):
    ...
    dropdown_filter_list = True