dipeshdulal / clean-gin Goto Github PK

Currently used folder structure looks not appropriate. API services are used for listeners and cron jobs.

• Remove previously added Automigrate implementation.

I see that https://github.com/casbin/casbin supports user rights management very much, can you support it?

Using gin + gorm + casbin + ... to build a more perfect template

Thank you, author.

Try to create a file upload middleware that is extensible (plug and playable) similar to multer in express.

CLI support with cobra command manager.

https://github.com/spf13/cobra

When I tried to create migration without starting the server on docker, it throws the following error

I think creating migration should not depend on whether the server is started or not and more importantly it's started on docker or not.

Readme should contain:

• How to run the template project and some other configuration information that is missing.

Lesser code duplication as possible

https://github.com/rubenv/sql-migrate

Enabling unit testing with go-fx

Repo seems to be providing more modern approach to configuration management with multiple config formats support.
https://github.com/spf13/viper

The newLogger function env parameter is never used. This results in the LOG_LEVEL from config never being applied.

Default logging level always remains set to zap.PanicLevel

Thank for the great template, but a bit inconsistent with the logger, each module has use it own logger instead of lib.Logger

• main app: zap
• gorm: gorm logger
• fx and viper may be unable to use the same logger

So can you make the gorm use lib.Logger for this template?

Reference issue: wesionaryTEAM/go_clean_architecture#63

Load docker variables from env instead of putting them at two places.

Implement pagination middleware

Swagger Documentation for clean-gin

Hey all, wanted to reach out regarding a license for this template.

Currently, with no license it's by default "All right reserved" see sveltejs/template#78 and sveltejs/template#201 for more info on a similar situation - project with a public template on github and no license. Copy pasting from Svelte issue #78:

From the GitHub guidance on licensing:

You're under no obligation to choose a license. However, without a license, the default copyright laws apply, meaning that you retain all rights to your source code and no one may reproduce, distribute, or create derivative works from your work. If you're creating an open source project, we strongly encourage you to include an open source license. The Open Source Guide provides additional guidance on choosing the correct license for your project.

If you don't want to restrict things you can Use the 0BSD license - https://opensource.org/licenses/0BSD, alternatively you can go the path of Gorm and Gin, which both use the MIT license - https://opensource.org/licenses/MIT. These are just suggestions, of course, and the decision is ultimately up to you

Created #32 for 0BSD and #33 for MIT License. Feel free to merge either of them if you like those choices

Modular Folder Structures

Currently, routes, services, repository, etc have been added in their separate folders.
This make it less modular, harder to re-use and less maintainability.

Thinking of making this structure something like this;

pkg
  |-- authentication (model, handler, service, route, repository, serializer etc.)
  |-- users
  |-- .... 
  |-- common (some common things re-usable by multiple modules)
internal
  |-- framework's internal wiring code 
domain
  |-- users.go (interfaces for users package)
  |-- authentication.go (interfaces for authentication package)

While we are at it, we need to look at the go's recommended folder structure for packages.
Following something like this

Check after looking at the tutorial for gin framework.

https://medium.com/wesionary-team/authorization-in-golang-projects-using-casbin-f8fad744dae5

Another discussion PR about the access control with casbin can also be seen in #7.

Error after executing migration make create

What is the name of migration?test
/bin/sh: 2: migrate: not found
Makefile:20: recipe for target 'create' failed
make: *** [create] Error 127