dinoex / iroffer-dinoex Goto Github PK

Hi, and thanks for your project!

I'm one of the maintainers of https://github.com/oragono/oragono, and we got a report that iroffer wasn't interoperating correctly with oragono, specifically that oragono was disconnecting it due to ping timeout. Upon further investigation, the original reporter determined that Oragono was sending lines of the form PING bot_nickname\r\n, where bot_nickname is the nickname used by the iroffer instance, and iroffer wasn't responding to them.

This appears to be due to a bug in iroffer's message parsing:

This line assumes that the parameter to PING will be an RFC1459 trailing parameter, i.e., prefixed with :. But in fact this is not a requirement of the protocol, and it is valid for oragono to send PING bot_nickname\r\n without the colon.

I haven't tested it, but I think this patch will work:

diff --git a/src/dinoex_irc.c b/src/dinoex_irc.c
index 5224af25..94d31a70 100644
--- a/src/dinoex_irc.c
+++ b/src/dinoex_irc.c
@@ -1286,7 +1286,7 @@ static void ir_parseline2(ir_parseline_t *ipl)
 
 #if PING_SRVR
   /* server ping */
-  if (strncmp(ipl->line, "PING :", 6) == 0) {
+  if (strncmp(ipl->line, "PING ", 5) == 0) {
     if (gdata.debug > 0)
       ioutput(OUT_S, COLOR_NO_COLOR,
               "Server Ping on %s: %s",

Thanks for your time.

Feature request as it were: Suppress (or add a verbosity level) to reduce the output to the console when iroffer adds files. Would be great to just see the newly added ones instead when autoadd/adddir etc etc is used, or when the bot does its routine scan if configured.

I believe this is this responsible for it:

using cygwin 1.7.24 and ruby 1.9.3-p429-1 there is a fork error complaining about cygruby191.dll please see attached log. compiled using
./Configure -geoip -upnp -curl -ruby

LOG:
Welcome to iroffer-dinoex - http://iroffer.dinoex.net/ - geoip,upnp,curl,openssl ,ruby
Version 3.30 (Win32) 1.7.24

** iroffer-dinoex is distributed under the GNU General Public License.
** please see the LICENSE for more information.

** Starting up...
** Window Size: 80x24
** Started on: 2013-08-17 22:34
** Loading bfsvc.ini ...
** Checking for completeness of config file ...
** You Are Running CYGWIN_NT-6.1-WOW64 1.7.24(0.269/5/3) on a i686, Good
** 2013-08-17 22:34: Loading State File...
** 2013-08-17 22:34: [Version 2 State File]
** 2013-08-17 22:34: [Written by iroffer-dinoex 3.30 (Win32) 1.7.24, CYGWIN_NT -6.1-WOW64 1.7.24(0.269/5/3)]
** 2013-08-17 22:34: [Written on 2013-08-17 22:30]
** 2013-08-17 22:34: [Record 0.0kB/s]
** 2013-08-17 22:34: [Bandwidth Record 0.0kB/s]
** 2013-08-17 22:34: [Total Transferred 0]
** 2013-08-17 22:34: [Total Runtime 0 Days 0 Hrs and 1 Min]
** 2013-08-17 22:34: [Last Log Rotate 2013-08-17 21:49]
** 2013-08-17 22:34: [Daily Transfer Limit Used 0]
** 2013-08-17 22:34: [Daily Transfer Limit Ends 2013-08-18 00:00]
** 2013-08-17 22:34: [Weekly Transfer Limit Used 0]
** 2013-08-17 22:34: [Weekly Transfer Limit Ends 2013-08-18 00:00]
** 2013-08-17 22:34: [Monthly Transfer Limit Used 0]
** 2013-08-17 22:34: [Monthly Transfer Limit Ends 2013-09-01 00:00]
** 2013-08-17 22:34: [Found 0 ignores]
** 2013-08-17 22:34: [Found 0 messages]
** 2013-08-17 22:34: [Found 0 packs]
** 2013-08-17 22:34: [Found 0 queues]
** 2013-08-17 22:34: [Found 0 queues]
** 2013-08-17 22:34: [Done]
** 2013-08-17 22:34: Writing pid file...
** 2013-08-17 22:34: Attempting Connection to irc.xeromem.com:6697 (ssl)
0 [main] iroffer 5148 child_info_fork::abort: C:\cygwin\bin\cygruby191.dll : Loaded to different address: parent(0x9B0000) != child(0x630000)
** 2013-08-17 22:34: WARNING: fork(): Resource temporarily unavailable
ruby 1.9.3p429 (2013-05-15) [i386-cygwin]
** 2013-08-17 22:34: UPnP discover
** 2013-08-17 22:34: UPnP device : desc: http://10.10.10.1:2869/IGatewayDeviceDe scDoc
st: urn:schemas-upnp-org:device:InternetGatewayDevice:1
** 2013-08-17 22:34: Startup running: 2163 ms
** 2013-08-17 22:34: Reconnecting to server (7 seconds) on 1
** 2013-08-17 22:34: Attempting Connection to irc.xeromem.com:6697 (ssl)
0 [main] iroffer 3716 child_info_fork::abort: C:\cygwin\bin\cygruby191.dll : Loaded to different address: parent(0x9B0000) != child(0x610000)
** 2013-08-17 22:34: WARNING: fork(): Resource temporarily unavailable
** 2013-08-17 22:35: Shutting Down
** 2013-08-17 22:35: Saving State File...
** 2013-08-17 22:35: Done

Hi!
I maintain your package in Gentoo Linux. But we have a problem. Your package has automagic NSS dependency. NSS found, even if we have USE="-chroot"
It should be fixed in buildsystem.

Thanks.

Been trying to write a javascript parser for the packlist, and found that json.txt.rb is not putting out a valid JSON-formatted file.

After a little research and experimentation, I've made some changes to the ruby script to output a file that is JSON friendly, which is attached..

json.txt

I've been attempting to create a Docker image with ruby support but so far I've only gotten 3.30 to enable while the snapshot will refuse no matter the libruby version.

Got any tips?

As soon as I write this, I happen to land on the right combination:
Debian Wheezy with ruby1.8-dev, ruby1.8 and libruby1.8