dinel / metadiscourse-annotator Goto Github PK

in src/AppBundle/Controller/DefaultController.php, line 18

This texts local variable is declared but never used. You should remove it.

    /**
     * @Route("/", name="homepage")
     */
    public function indexAction(Request $request)
    {
        $texts = $this->getDoctrine()
                      ->getRepository('AppBundle:Text')
                       ->findAll();
        /*
        return $this->render('FrontPage/index.html.twig', array(
            'texts' => $texts,

Posted from SensioLabsInsight

When clicking "Edit category" the program goes back to the admin screen

in app/Resources/views/Annotator/annotation.css.twig, line 11

Using the |raw filter or the {% autoescape false %} block in a Twig template exposes users to Cross-Site Scripting (XSS) attacks

    font-size: 12px;
}

{% for sense in senses %}
    span.sense{{sense.id}} {
      background-color: {{ sense.bgcolor | raw}};
      color: {{ sense.fgcolor | raw}};
      border: dotted thin black;
      padding: 2px;
    }
{% endfor %}

Posted from SensioLabsInsight

in web

This config.php file should only be used to bootstrap a Symfony application. Before releasing to production, you should remove it, otherwise attackers could get valuable insight about your application.

web/
├── css/
├── font-awesome/
├── jquery/
├── js/
├── app.php
├── app_dev.php
├── apple-touch-icon.png
├── config.php
├── favicon.ico
├── robots.txt
└── test.html

Posted from SensioLabsInsight

in src/AppBundle/Entity/Markable.php, line 61

Method names should be declared in camelCase. You should rename this method to comply with PSR-1.

    protected $domains;
    
    /**
     * The constructor
     */
    public function _construct() {
        $this->senses = new \Doctrine\Common\Collections\ArrayCollection();
        $this->domains = new \Doctrine\Common\Collections\ArrayCollection();
    }

    /**

Posted from SensioLabsInsight

in src/AppBundle/Controller/CategoryAdminController.php, line 68

The Category class resolves to the following class: AppBundle\Entity\Category.
Did you forget to add a corresponding use statement?

    /**
     * Creates a new category
     * @Route("/admin/category/add", name="admin_category_add")
     */
    public function addCategoryAction(Request $request) {
        $category = new Category();
        
        return $this->editCategory_intern($request, $category, false);
    }    
    
    /**

Posted from SensioLabsInsight

Currently it is not possible to edit/delete categories.

Calculate various statistics for corpora and display them

in src/AppBundle/Controller/CategoryAdminController.php, line 99

Method names should be declared in camelCase. You should rename this method to comply with PSR-1.

     * @param Request $request the request
     * @param Category $category an object Category that will be edited
     * @param bool $editing true if it edits an existing category
     * @return type
     */
    private function editCategory_intern($request, $category, $editing) {
        $form = $this->createForm(new CategoryType(), $category);
        
        $form->handleRequest($request);
        
        if($form->isValid()) {

Posted from SensioLabsInsight

Be able to deal with "Section X", "As X argues"

getSubcategory and getDataBySenseAction should be moved to more appropriate controllers

Currently if a user accesses the document to annotate directly using the URL, but without being authenticated an exception happens

in app/Resources/views/Search/search_term.html.twig, line 28

Using the |raw filter or the {% autoescape false %} block in a Twig template exposes users to Cross-Site Scripting (XSS) attacks

            </div></div><div id="results" class="row voffset3"><div class="col-md-8 col-md-offset-2"><h3>The search results for {{ message | raw }}</h3></div><div class="voffset3 text-center">
                {% if stats_for == "category" %}
                    {{ render_hinclude(controller(

Posted from SensioLabsInsight

in app/Resources/views/Search/search_term_intern.html.twig, line 16

Using the |raw filter or the {% autoescape false %} block in a Twig template exposes users to Cross-Site Scripting (XSS) attacks

{% block body %}
    <div class="container"><div class="row voffset3"><div class="col-md-8 col-md-offset-2"><div><div><i>The statistics and annotation are from {{ search_scope|raw }}</i></div><h4>Statistics</h4><table class="table table-hover"><tr><td>Show</td><td>User</td>

Posted from SensioLabsInsight

Enable annotation of multiword expressions. The most likely way to address this is to merge the relevant tokens into one.

29% of all your controllers have more than 10 actions, the threshold is 5%.

• AdminController has 15 actions
• WebAnnotatorController has 11 actions

Posted from SensioLabsInsight

The route "search_category" should have a routing method (GET/POST/PUT). It is mandatory.

Posted from SensioLabsInsight

Currently it is possible to have the same marker twice. This messes up the system.

In cases where a marker has only one sense add a button that copies the only sense available to speed up the annotation.

in app/Resources/views/Annotator/annotation.css.twig, line 12

Using the |raw filter or the {% autoescape false %} block in a Twig template exposes users to Cross-Site Scripting (XSS) attacks

}

{% for sense in senses %}
    span.sense{{sense.id}} {
      background-color: {{ sense.bgcolor | raw}};
      color: {{ sense.fgcolor | raw}};
      border: dotted thin black;
      padding: 2px;
    }
{% endfor %}

Posted from SensioLabsInsight

Currently the program make several assumptions about the state of the database. Create an action that makes all the necessary initialisation.

• insert "No parent category" category

in src/AppBundle/Controller/AdminController.php, line 284

Non-action public method found in controller class

    }
    
    /**
     * @Route("/admin/corpus/category/{corpus_id}/{value_id}")
     */
    public function editCorpusCategory(\Symfony\Component\HttpFoundation\Request $request, 
            $corpus_id, $value_id) {
        if($request->isXmlHttpRequest()) {
            $em = $this->getDoctrine()->getManager();
            
            $value = $this->getDoctrine()

Posted from SensioLabsInsight

Currently it is possible to click submit even if the user does not select a file. As a result an exception is thrown.

in src/AppBundle/Controller/AdminController.php, line 134

Calling flush is a resource intensive operation, especially when a lot of entities are managed by Doctrine. You should pass the entity you want to flush as parameter, or avoid flushing inside a loop.

                        ->getRepository('AppBundle:Domain')
                        ->findBy(array('name' => $name));
                    if(count($domain_name) == 0) {
                        $em = $this->getDoctrine()->getManager();
                        $em->persist($domain);
                        $em->flush();                        
                    }                                        
                } else {
                    break;
                }                
            }

Posted from SensioLabsInsight

During the annotation the "Save" button does not become enabled when only the subcategory is being changed.

in app/Resources/views/Admin/marker/marker_report.html.twig

Template too complex, depth of 6 is reached but only 5 is allowed.

Posted from SensioLabsInsight

in src/AppBundle/Controller/AdminController.php, line 134

Calling flush is a resource intensive operation, especially when a lot of entities are managed by Doctrine. You should pass the entity you want to flush as parameter, or avoid flushing inside a loop.

                        ->getRepository('AppBundle:Domain')
                        ->findBy(array('name' => $name));
                    if(count($domain_name) == 0) {
                        $em = $this->getDoctrine()->getManager();
                        $em->persist($domain);
                        $em->flush();                        
                    }                                        
                } else {
                    break;
                }                
            }

Posted from SensioLabsInsight

Currently the first level categories are not displayed even when they do not have leaf nodes