dimenwarper / scimitar Goto Github PK

Hi and thanks for the great package!

I would like to lift the munkres dep on the package to make it easier to install. The hungarian algorithm is usedonly once

for idx1, idx2 in zip(scipy.optimize.linear_sum_assignment(state_dist_matrix)):

Moreover, you don't need to make a list anymore, making it faster. Would you accept a PR for changing this line? I can write one overnight!

Thanks!
Fabio

Hello hello,

Interesting package. What's your recommendation for running it? Seems not to have python 3 support (though pyroconductor does now). If I'm doing a new conda environment, which python version is best to use?

-Josh