Code Monkey home page Code Monkey logo

authorizenet's People

Contributors

alchez avatar developermetal avatar dti-deploy avatar vjfalk avatar

Stargazers

avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

developermetal yashodhank samjaninf alchez myuddinkhatri dharmraj-48 erpnext-apps-store govind-jangid zaqoutabed

authorizenet's Issues

[v9][UI UX] Payment request throws "Something could not be processed" message

Steps to recreate:

  1. Go to payment request link
  2. Enter reference number and proceed
  3. Fill all the card details and click on Submit Payment

Expected behavior:

  • Redirected to payment success page

Actual behavior:

  • Something could not be processed message appears but payment is accepted

Screenshot:
image

Stacktrace:

13:01:13 web.1            | Traceback (most recent call last):
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/authorizenet/authorizenet/authorizenet/doctype/authorizenet_settings/authorizenet_settings.py", line 540, in create_request
13:01:13 web.1            |     status)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 702, in run_method
13:01:13 web.1            |     out = Document.hook(fn)(self, *args, **kwargs)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 965, in composer
13:01:13 web.1            |     return composed(self, method, *args, **kwargs)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 948, in runner
13:01:13 web.1            |     add_to_return_value(self, fn(self, *args, **kwargs))
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 696, in <lambda>
13:01:13 web.1            |     fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/erpnext/erpnext/accounts/doctype/payment_request/payment_request.py", line 207, in on_payment_authorized
13:01:13 web.1            |     self.run_method("set_as_paid")
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 702, in run_method
13:01:13 web.1            |     out = Document.hook(fn)(self, *args, **kwargs)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 965, in composer
13:01:13 web.1            |     return composed(self, method, *args, **kwargs)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 948, in runner
13:01:13 web.1            |     add_to_return_value(self, fn(self, *args, **kwargs))
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 696, in <lambda>
13:01:13 web.1            |     fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/erpnext/erpnext/accounts/doctype/payment_request/payment_request.py", line 98, in set_as_paid
13:01:13 web.1            |     self.make_invoice()
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/erpnext/erpnext/accounts/doctype/payment_request/payment_request.py", line 59, in make_invoice
13:01:13 web.1            |     si.submit()
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 778, in submit
13:01:13 web.1            |     self._submit()
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 767, in _submit
13:01:13 web.1            |     self.save()
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 256, in save
13:01:13 web.1            |     return self._save(*args, **kwargs)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 307, in _save
13:01:13 web.1            |     self.run_post_save_methods()
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 831, in run_post_save_methods
13:01:13 web.1            |     self.run_method("on_submit")
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 702, in run_method
13:01:13 web.1            |     out = Document.hook(fn)(self, *args, **kwargs)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 965, in composer
13:01:13 web.1            |     return composed(self, method, *args, **kwargs)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/model/document.py", line 950, in runner
13:01:13 web.1            |     add_to_return_value(self, f(self, method, *args, **kwargs))
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/erpnext_taxjar/erpnext_taxjar/api.py", line 103, in create_transaction
13:01:13 web.1            |     frappe.throw(_(sanitize_error_response(err)))
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/__init__.py", line 319, in throw
13:01:13 web.1            |     msgprint(msg, raise_exception=exc, title=title, indicator='red')
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/__init__.py", line 309, in msgprint
13:01:13 web.1            |     _raise_exception()
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/__init__.py", line 282, in _raise_exception
13:01:13 web.1            |     raise raise_exception(encode(msg))
13:01:13 web.1            | ValidationError: Something could not be processed
13:01:13 web.1            |
13:01:13 web.1            | Traceback (most recent call last):
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/app.py", line 57, in application
13:01:13 web.1            |     response = frappe.handler.handle()
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/handler.py", line 22, in handle
13:01:13 web.1            |     data = execute_cmd(cmd)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/handler.py", line 53, in execute_cmd
13:01:13 web.1            |     return frappe.call(method, **frappe.form_dict)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/frappe/frappe/__init__.py", line 935, in call
13:01:13 web.1            |     return fn(*args, **newargs)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/authorizenet/authorizenet/authorizenet/doctype/authorizenet_settings/authorizenet_settings.py", line 623, in process
13:01:13 web.1            |     data = frappe.get_doc("AuthorizeNet Settings").create_request(data)
13:01:13 web.1            |   File "/Users/sushantnadkar/workbench/frappe-benchv8/apps/authorizenet/authorizenet/authorizenet/doctype/authorizenet_settings/authorizenet_settings.py", line 545, in create_request
13:01:13 web.1            |     raise ex
13:01:13 web.1            | ValidationError: Something could not be processed

Stored payments require authentication

Just documenting here to keep in mind.

The gateway fetches stored payments associated to a contact. This means that only a logged in user should be able to see their stored payments.

Atm, the gateway is locked out to un-authenticated users simply due to fetching country records permissions.

We need to either embed a login form or prompt the user to login if they want to have access to their stored payments.

Though paying should not be restricted to authenticated users.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.