Max Ammann - 17.11.2018, 17:36:31

Fix this in the extracted endpoint module! integreat-api-client

Environment: -
Linked issues:

Max Ammann - 19.3.2019, 18:15:51

None

Environment: -
Linked issues:

steffenkleinle - 9.5.2018, 09:24:02

We have to wait for an enzyme release. Watching this PR:
enzymejs/enzyme#1513

Environment: -
Linked issues:

Sven Seeberg - 6.2.2019, 14:34:42

When exporting PDF from link https://integreat.app/testumgebung/ar/مرحبًا-بكم, a JS error occurs. See screenshots. The error does not seem to influence the outcome, the PDF is being created and the download opens.

Environment: None
Linked issues:

• Duplicate: WEBAPP-598

Max Ammann - 15.3.2019, 14:15:52

Timestamps should be displayed according to the following rule:

Always display time and date in the local time where the event is happending.

If timezone of the event is not equal to the timezone of the user/device display the timezone aswell.

Also remove the following line in the circleCI config: https://github.com/Integreat/integreat-webapp/blob/4f8e85761a9bf7120a079e2fca2ab435c0718f8a/.circleci/config.yml#L79

Environment: -
Linked issues:

• Blocks: IGAPP-281
• Duplicate: WEBAPP-464
• Relates: WEBAPP-453
• Relates: IGAPP-92

Max Ammann - 19.3.2019, 18:14:44

None

Environment: -
Linked issues:

Nikolas Klug - 8.1.2019, 11:46:10

Create a file, e.g. app/constants/routes.js, and define all routes used in Navigator.js. Then only use those variables instead of hard coded strings.

Environment: -
Linked issues:

• Already done: IGAPP-114
• Blocks: APICLIENT-1

Max Ammann - 29.6.2017, 11:23:06

Add next to pdf button.

Use browser api for this.

Environment: -
Linked issues:

Michael Markl - 27.12.2017, 15:05:35

• Check how difficult it is to set it up
• Reflect following (dis)advantages
  • Search Engine Optimization
  • The client can have javascript disabled (!)

Environment: -
Linked issues:

• Blocks: WEBAPP-272
• Relates: WEBAPP-272

Max Ammann - 12.3.2019, 14:00:05

Currently we normalize the path before creating the CategoryModel

This means it is possible to construct a CategoryModel with a non-normalized path.

It would make sense to normalize the path in the constructor or when accessing the path variable.

Also check other models.

Environment: -
Linked issues:

Max Ammann - 8.10.2018, 17:22:14

In order to be accessible our icons should be simple SVGs. The current thumbnails are in the post object like this:

thumbnail: "https://...",

The new post object will look like this:

thumbnail: "https://...",
dynamic_thumbnail: "https://...",
color: '#123456'

If the dynamic_thumnail is non-null we use the color flag to generate a custom thumbnail.

There are the Icons in SVG format: https://drive.google.com/drive/folders/12uBcz3YdiElvB1jRshkvYyoKwoYKQ_-F

Environment: -
Linked issues:

• Duplicate: IGAPP-17
• Relates: IGAPP-117
• Relates: IGAPP-17

Max Ammann - 8.10.2018, 17:13:21

<~fuchs> can create an After Effects animation for the screen (https://github.com/react-community/lottie-react-native).

Environment: -
Linked issues:

• Relates: WEBAPP-114

Max Ammann - 4.10.2018, 22:57:55

This is a security feature and could safe bandwidth.

You can instruct the browser not to load specific content: https://www.html5rocks.com/en/tutorials/security/content-security-policy/

Environment: -
Linked issues:

steffenkleinle - 21.12.2018, 12:06:41

Remove locales:missing script. Also remove task from package.json.

Environment: None
Linked issues:

Max Ammann - 20.12.2018, 18:47:19

See here how to do it: nitaliano/react-native-mapbox-gl#498 (comment)

Bounding boxes should restrict the user within the selected city.

Environment: -
Linked issues:

Max Ammann - 16.11.2018, 13:54:30

The 3 nearest cities should be featured in the city selection. This means they are listed first, before the alphabetical listing of all sites/regions. Nearest cities are based on the location of the device and its distance to all sites/regions

The longitude and latitude for sites/regions (and also for its aliases) is available in the sites endpoint of the APIv3: https://github.com/Integreat/cms/wiki/REST-APIv3-Documentation#response

The app has to calculate the distance to all cities and select the closest ones. A cut off distance of 50 km is useful. That means, if no site/region is closer than 50km, no region is shown.

It could make sense to implement this using an IP-based location lookup as this requires no GPS.
*
The problem with this issue is that most devices (desktop) which use the webapp do no offer a location. Also scrolling down to your home city is not as much of a problem as on mobile.
Therefore this issue is not important right now.*

Environment: -
Linked issues:

Max Ammann - 19.3.2019, 18:13:28

None

Environment: -
Linked issues:

Max Ammann - 19.3.2019, 18:16:06

None

Environment: -
Linked issues:

Max Ammann - 21.10.2018, 20:41:58

https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP

I think we can disable external -iframes-, scritps and stylesheets. Maybe we can also disallow non-https fetches.

Environment: -
Linked issues:

Max Ammann - 17.11.2018, 21:37:01

See WEBAPP-354 for description about the feature.

Environment: -
Linked issues:

• Cloners: IGAPP-17
• Relates: IGAPP-146
• Relates: IGAPP-17

Max Ammann - 24.10.2018, 18:52:59

The task WEBAPP-387, WEBAPP-423 fixed a internal linking problem.

Create a test to detect the problem.

Environment: -
Linked issues:

• Relates: WEBAPP-387
• Relates: WEBAPP-423

Max Ammann - 8.10.2018, 17:10:10

https://developer.chrome.com/multidevice/android/customtabs work in Chrome and Firefox.

External links should be opened in custom tabs. Also add a setting in the app.

Maybe use this library: https://docs.expo.io/versions/v32.0.0/sdk/webbrowser/

Environment: -
Linked issues:

• Already done: IGAPP-130

Max Ammann - 28.11.2018, 23:34:30

Remove all except the material font. Also add documentation about using vector fonts and how to use the removed ones later.

Environment: -
Linked issues:

Max Ammann - 17.11.2018, 17:32:19

Test RemoteContent

Environment: -
Linked issues:

Max Ammann - 17.11.2018, 17:37:59

Add tests

Environment: -
Linked issues:

Max Ammann - 9.10.2018, 16:55:41

The status of the download should be reported. Implement a progressbar to display it.

Environment: -
Linked issues:

• Blocks: NATIVE-1
• Blocks: NATIVE-66
• Relates: IGAPP-30
• Relates: IGAPP-294
• Relates: IGAPP-336
• Relates: IGAPP-440

Nikolas Klug - 13.11.2018, 14:46:25

We want to close the modals by swiping down. Display the background with increasing opacity while swiping down.

See this sample code with react-naviation:

  <Stack.Navigator screenOptions=` headerShown: false ` mode="modal">
        <Stack.Screen name="Home" component={BottomBarNavigation} />
        <Stack.Screen name="Profile" component={ProfileScreen} />
        <Stack.Screen
          name="Add"
          component={AddScreen}
          options={{
            ...TransitionPresets.ModalSlideFromBottomIOS,
            gestureEnabled: true,
            gestureResponseDistance: {
              vertical: 200,
            },
            cardStyle: {
              backgroundColor: 'transparent',
              marginTop: 150,
              flex: 1,
            },
          }}
        />
      </Stack.Navigator>

Environment: -
Linked issues:

• Blocks: IGAPP-114
• Relates: IGAPP-94
• Relates: IGAPP-808

Max Ammann - 17.11.2017, 09:18:34

As a_ developer_, I want to have E2E tests in order to test features.

The main goal of this is:

• Have some kind of integration test between backend and frontend
• Test whether the app runs in browsers we support

You can experiment with a headless-chrome which does not require browserstack.

Acceptance Criteria (Successes/Failures):

• A simple and minimal E2E tests which runs ob browserstack
• The tests should also run in Chrome on developer machines
• A new CI step which runs for integreat
• Run the tests at least in IE11 and Chrome

Environment: -
Linked issues:

• Blocks: IGAPP-494
• Cloners: WEBAPP-28
• Relates: IGAPP-493

Max Ammann - 12.12.2018, 19:01:33

Use checksums to validate cached content.

Do this after initial downloading and when refreshing.

This needs support by the cms which should provide checksums.

Environment: -
Linked issues:

Max Ammann - 22.10.2018, 12:45:39

The APK size is currently ~50MB this should be reduced.

Probably some library update in pushed this size.

Environment: -
Linked issues:

• Relates: IGAPP-98
• Relates: IGAPP-139

Michael Markl - 13.3.2019, 18:01:27

... once this issue is resolved: faceyspacey/redux-first-router#340

Environment: -
Linked issues:

steffenkleinle - 26.11.2018, 23:21:49

Add feedback functionality for pois page.

Environment: -
Linked issues:

• Relates: IGAPP-404

Max Ammann - 17.11.2018, 17:37:40

Add tests

Environment: -
Linked issues:

Max Ammann - 19.3.2019, 18:13:43

None

Environment: -
Linked issues:

Michael Markl - 4.9.2018, 03:11:32

There are two possibilities to implement a high contrast mode:

Adapt everything in the forntends:

For images (icons) try this css-filter:

hue-rotate(207.8deg) saturate(2000%) grayscale(100%)

See attachments for examplary result. Drawbacks only, if city uses (realistic) images instead of icons (see Dormagen)

Adjust text weight, color. Adjust horizontal line color.

Add an entry to the toolbar

We also have the icons in SVG format here: https://drive.google.com/drive/folders/12uBcz3YdiElvB1jRshkvYyoKwoYKQ_-F

Involve the cms:

In order to be accessible our icons should be simple SVGs. The current thumbnails are in the post object like this:

thumbnail: "https://...",

The new post object will look like this:

thumbnail: "https://...",
dynamic_thumbnail: "https://...",
color: '#123456'

If the dynamic_thumnail is non-null we use the color flag to generate a custom thumbnail.

There are the Icons in SVG format: https://drive.google.com/drive/folders/12uBcz3YdiElvB1jRshkvYyoKwoYKQ_-F

Environment: -
Linked issues:

• Cloners: IGAPP-117
• Duplicate: IGAPP-146
• Relates: IGAPP-117
• Relates: IGAPP-138
• Relates: IGAPP-146

Max Ammann - 17.11.2018, 17:34:57

Fix this in the extracted endpoint module! integreat-api-client

Environment: -
Linked issues:

steffenkleinle - 28.3.2018, 22:29:58

Add test

Environment: -
Linked issues:

• Blocks: WEBAPP-234
• Blocks: WEBAPP-288
• Blocks: WEBAPP-211

Max Ammann - 19.3.2019, 18:14:51

None

Environment: -
Linked issues:

Max Ammann - 4.10.2018, 23:00:04

Currently there is no way to update the offline data incrementally. Only a complete refetch updates the data.

Also make sure offline mode is handled properly: https://www.npmjs.com/package/react-native-offline
Split this task if it gets too difficult.
 

We can use the hashes in API v3.

Environment: -
Linked issues:

• Blocks: NATIVE-63

Max Ammann - 8.10.2018, 17:04:37

In order to be able to set the personalized ids for the JPAL evaluation users should be able to set the id by just clicking on a link/scanning a qr code. In order to do that, the app has to support deep linking. It should work on android and iOS, but if this proves as too much work, split the issue.

Corresponding documentation:

https://reactnavigation.org/docs/en/deep-linking.html

 The app should be able to handle integreat:// and https://integreat.app for integreat, https://malteapp.de for malte, https://aschaffenburg.app for aschaffenburg, i.e. it should depend on the build configs if possible. Decide if it makes sense to implement malteapp:// and aschaffenburgapp:// or similar as well.

Environment: -
Linked issues:

• Blocks: IGAPP-263
• Blocks: IGAPP-523

Max Ammann - 19.3.2019, 18:14:08

None

Environment: -
Linked issues:

Max Ammann - 6.12.2018, 20:13:09

At first only upload it to izzy in the repo. Then create issues for things we have to do before actually uploading it to fdroid the normal way.

Maybe the javascript needs to be precompiled.

Example:
https://github.com/lopespm/arxiv-papers-mobile
https://gitlab.com/fdroid/fdroiddata/blob/master/metadata/com.rockbyte.arxiv.txt

Environment: -
Linked issues:

• Blocks: IGAPP-261
• Duplicate: IGAPP-773
• Relates: IGAPP-995
• Relates: IGAPP-996
• Relates: IGAPP-261
• Relates: LUN-151

Max Ammann - 17.11.2018, 16:01:06

Test RemoteContent

Environment: -
Linked issues:

Max Ammann - 19.3.2019, 18:16:00

None

Environment: -
Linked issues:

Michael Markl - 18.11.2017, 10:17:12

sample link: https://web.integreat-app.de/augsburg/de/willkommen/stadtplan/?preview*id=37&preview_nonce=5c2d5d8bdd&_thumbnail*id=253&preview=true

Environment: -
Linked issues:

• Cloners: WEBAPP-71

Michael Markl - 17.10.2017, 12:48:27

Look into whether this is still relevant and then do it or reject the issue.

Currently iPhone displays the status bar in translucent mode, so the content of the web-app floats behind the status bar (looking ugly).
Setting the meta tag apple-mobile-web-app-status-bar-style in index.ejs to black or some other color maybe, then the statusbar is displayed in default mode (I suppose).
Also there's a click delay (bug) in iOS Safari, so we need to do a little refinement there, as well.

Environment: -
Linked issues:

Max Ammann - 9.12.2018, 19:54:12

A tool like https://github.com/s0md3v/XSStrike can be used to generate strings for testing.

Data which comes from the API should all be sanitized!

Environment: -
Linked issues:

Max Ammann - 19.3.2019, 18:14:30

None

Environment: -
Linked issues:

Max Ammann - 16.12.2018, 13:00:09

This is only used for the SearchBar and the Button. Implement it yourself or find a non-beta ui toolkit.

Environment: -
Linked issues:

Max Ammann - 7.12.2018, 13:21:44

To analyse the metro bundle use: https://www.npmjs.com/package/source-map-explorer

If that does not work we can look into haul: https://github.com/callstack/haul

The attachment is a result of source-map-explorer.

Environment: -
Linked issues:

• Relates: IGAPP-139
• Relates: IGAPP-171