digarok / b2d Goto Github PK

Hi,

In June 2020 I found an issue in the LoRes file generation of Bill Buckels' code and fixed it. The code did DoubleLoRes right, but LoRes wrong. Bill accepted my fix and created a new Version 1.2 (c) Copyright Bill Buckels 2020 from it.

Today I tried to incorporate the fix into your code base but didn't succeed. It sort seems to me that your code currently does the opposite, meaning it does LoRes right, but DoubleLoRes wrong. However, I can't really judge - and to be honest I don't have the time to re-test things and actually find out.

Therefore I just send you both the old file and the new file so you can diff them and form your own opinions through.

Regards,
Oliver

b2d.zip

Passed over to this project from Buckshot digarok/buckshot#8

It is showing impossible horizontal color combinations within a byte, like purple<->blue dither.

The sky and some of the balloon patches are good examples of this. Compare the above to the output on an emulator (the emulator pixels are correct, though I'm showing it here as RGB, not NTSC.)

The workflow release.yml is referencing action actions/checkout using references v1. However this reference is missing the commit a6747255bd19d7a757dbdda8c654a9f84db19839 which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.

It seems to capitalize the output path, if this error message is accurate.