Code Monkey home page Code Monkey logo

Comments (2)

billykwok avatar billykwok commented on May 20, 2024

Is the shouldUpdate prop in Container good enough for this use case? Other than than being a syntax shortcut, what benefits would it bring? I just personally think that shouldUpdate is clearer and short enough.

from constate.

diegohaz avatar diegohaz commented on May 20, 2024

I guess the first case using shouldUpdate would look like this:

<Container
  initialState={{ foo: "foo", bar: "bar" }}
  shouldUpdate={({ state, nextState }) => state.foo !== nextState.foo}
/>

But it can get more complex:

// subscribe to "a", "b" and "c.b"
<Container
  initialState={{ a: "a", b: "b", c: { a: "a", b: "b" }, d: "d" }}
  shouldUpdate={({ state, nextState }) => (
    state.a !== nextState.a ||
    state.b !== nextState.b ||
    state.c.b !== nextState.c.b
  )}
/>

// or
<Container
  initialState={{ a: "a", b: "b", c: { a: "a", b: "b" }, d: "d" }}
  shouldUpdate={({ state, nextState }) => (
    state.c.a === nextState.c.a &&
    state.d === nextState.d
  )}
/>

The case above with subscription:

// subscribe to "a", "b" and "c.b"
<Container
  initialState={{ a: "a", b: "b", c: { a: "a", b: "b" }, d: "d" }}
  subscription={{ a: true, b: true, "c.b": true }}
/>

// or
<Container
  initialState={{ a: "a", b: "b", c: { a: "a", b: "b" }, d: "d" }}
  subscription={{ "c.a": false, d: false }}
/>

The problem with shouldUpdate is that it can be hard to read and reason about. At the same time, we need to keep it as a low level API.

But, in the end, it depends on how often people would need something as subscription. For pure, for example, I was using it almost everywhere (I even considered making it true by default, but it could have some silent unintended side effects), so it was worth creating a prop for it.

The only situation I really wanted this subscription was when I was building a complex Form Container.

from constate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.