dialexa / pleco Goto Github PK

When filtering or sorting if the table does not have a column called id, we are unable to perform operations on it

When using the getSortQuery from pleco-knex when making a call with the { mutate: true } flag the original query is not mutated. Instead of calling

getSortQuery({ sort, subqueries }, { knex: this.knex, query, mutate: true })

to change the query, we must now do this:

query = getSortQuery({ sort, subqueries }, { knex: this.knex, query, mutate: true })

Features I would like to see

1. Implicit eq

const filter = { field: 10};

2. Implicit AND

const filter = { field1: 5, field2: 10 };

db-graphql-filter-knex should not just provide KnexQB. It should provide all of the exports from db-graphql-filter and call getFilterQuery, getSortQuery, etc with the specific knex implementation of IQueryBuilder instead of having the user do it. We can rename db-graphql-filter to db-graphql-filter-core perhaps.

The current algorithm can be improved in terms of speed. If the filter wants to just operate on a column on the table, pleco overcomplicates the SQL query. Currently, if we have a table users with columns id and name and we wanted to use pleco to filter on the name, it would generate a SQL query like this:

select * from users where id in (
  select resource_id from (
    select id as resource_id, name as value from users
  ) where value = 'Bob'
)

Proposal:
If the end user passes a filter like { name: 'Bob' } in, it should generate a simpler query like

select * from users where name = 'Bob'

or if that's not possible then something like

select * from users where id in (
  select id from users where name = 'Bob'
)

Since this repo is still private, we only have a limited number of builds with TravisCI

Something like this will not work:

const query = knex.select('model').from('vehicles');
const result = await getSortQuery({ sort, subqueries }, new KnexQB({ knex, query });

We will receive the error column "subquery.id" does not exist