dhis2 / d2-analysis Goto Github PK

View Code? Open in Web Editor NEW

3.0 30.0 2.0 2.61 MB

:no_entry: [DEPRECATED] Please refer to DHIS2 Analytics library

Home Page: https://github.com/dhis2/analytics

JavaScript 99.96% CSS 0.04%

web-lib synced-settings

d2-analysis's Introduction

d2-analysis

Library for building DHIS2 analytics apps.

NB! Needed functionality is being migrated to d2 (https://github.com/dhis2/d2) - this libary will eventually be deprecated.

d2-analysis's People

Contributors

Stargazers

Watchers

Forkers

nagyist eyeseetea

d2-analysis's Issues

Missing code that sets the table LegendSet from appManager.legendsSet

https://github.com/dhis2/d2-analysis/blob/master/src/api/Layout.js

Here we have:

t.legendSet = (new Record(c.legendSet)).val(true);

But this value only holds the id of the legendSet, it seems to be missing some code to get the actual legends from the appManager. Something like this?

    var _appManager = t.klass.appManager;
    ...
    if (_appManager.legendSets && t.legendSet && t.legendSet.id)  {
        for (var i = 0, legendSet; i < _appManager.legendSets.length; i++) {
            legendSet = _appManager.legendSets[i];
            if (legendSet.id === t.legendSet.id) {
                $.extend(t.legendSet, legendSet);
                break;
            }
         }
    }

Org unit search in tree widget

For the org unit tree, add a function for searching for organisation units by name, short name, uid and code.

It is currently not possible to easily find organisation units in the tree.

Use api versioning

Use api versioning, e.g. /api/25/...

Collapse static label on left panel collapse

When collapsing the left panel, also collapse the static label, e.g. "DHIS 2 Data Visualizer". This allows for viewing long favorite names on limited screen sizes.

Save favorite dialog: Include title and description

In the Save / Save as favorite dialog, include fields:

API field	UI Label	Input type
title	Title	Input field
description	Description	Text area

Remove the "title" field under Options as it will now be under favorites.

Plugin support for adding/removing dimensions and items

Save favorite dialog: Collapse and expand list of favorites

In the Save / Save as favorites dialog: By default, collapse the list of favorites. Include a down-arrow icon which allows for expanding the list of favorites (as it currently is). The icon should shift to an up-arrow icon which allows for collapsing the list.

This will make the UI less crowded and bring the "Save" button closer to the input fields.

Write interpretation dialog: Include sharing settings

In the "write interpretation" dialog, include the UI for sharing settings under the interpretation area.

The sharing settings UI should be a mirror of the current sharing settings dialog and reflect the sharing state of the favorite.

In the POST API request for creating the interpretation, include the sharing part in the request body.

The concept is that the sharing state of the favorite should be equal to the sharing state of the interpretation.

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please click the 'fix repo' button on account.greenkeeper.io.

Remove unused properties in plugin requests

The pivot and chart plugins are using fields in field filtering which are no longer in use on the favorite data model. In DHIS 2.25 will have strict validation so this must be corrected.

The fields are:

program
programStage
undefined

404 on hrefs in EmbedWindow

The Embed button generates this HTML head:

<head>
<link rel="stylesheet" href="//dhis2-cdn.org/v222/ext/resources/css/ext-plugin-gray.css" />
<script src="//dhis2-cdn.org/v222/ext/ext-all.js"></script>
<script src="//dhis2-cdn.org/v222/plugin/table.js"></script>
</head>

However, none of those 3 URLs seem to exist (they do exist for older version, i.e. 2.16). Also, not sure where plugin/table.js is to be found in this new version.

https://github.com/dhis2/d2-analysis/blob/master/src/ui/EmbedWindow.js#L23