dhershman1 / simple-card Goto Github PK

The plan is to allow users to bring in and call validation methods they need/want

Example:
How it currently works

import simpleCard from 'simple-card';

simpleCard('4111111111111111'); // Validate single Card Number
simpleCard('333'); // Validate single CVN
simpleCard('1/20'); // Validate single date

Instead we should allow for:
Note The import from values are concepts/placeholders that may change on release

import validNumber from 'simple-card/number';
import validCVN from 'simple-card/cvn';
import validDate from 'simple-card/expire';

validNumber('4111111111111111');
validCVN('333');
validDate('1/20');

With the functionality of #1 we will want to remove sending a single string value to the main function to help make the code base less convoluted and easier to follow

So this example would no longer be valid:

import simpleCard from 'simple-card';

simpleCard('4111111111111111');
simpleCard('333');
simpleCard('09/10');

In favor of calling the individual methods that would be brought on by #1

Hopefully with the introduction of #1 and #2 we can see an improvement to code organization and a less complex code base.

However I don't want to stop there, primarily I want to finish moving internals around if they are only being used in a single spot (then whats the point in having them be in a different file?)

As well as making the code easier to sift through and understand if you want to view the source code.

Like single string support (#2) I would probably like to remove the partial object support, because it might get in the way and create unwarrented overhead when the module is being used.

I would like to remove any overhead for finding the card type to make it as accurate as I can. As well as making the code as maintainable as I can for 2.0.0